Jump to content

[1.7.2]Entity Item spawns client side


Jdb100

Recommended Posts

I have a block replacing itself with an item when clicked but it isn't called server side so any entities added would be client side and the blocks isn't set to air because it is only removed client side then syncs with the server and reappears. i should easily be able to make it spawn client side only with.

if(!world.isRemote)

however the onBlockActivated() seems to only be called client side even though it is supposed to be on both

 

onBlockActivated()

@Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int what, float are, float these, float For)
    {
	if(player.inventory.getCurrentItem() == null || player.inventory.getCurrentItem().getItem() == null)
	{
		return false;
	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && !tileEntity.carved)
    	{
    		tileEntity.carved = true;
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemSoulJar)
    	{
    		if(player.inventory.getCurrentItem().stackTagCompound != null)
    		{
    			if(player.inventory.getCurrentItem().stackTagCompound.getInteger("Entity Id") != 0)
    			{
    				if(tileEntity.carved)
    				{
    					tileEntity.setEntityId(player.inventory.getCurrentItem().stackTagCompound.getInteger("Entity Id"));
    					player.inventory.getCurrentItem().stackTagCompound.setInteger("Entity Id", 0);
    					return true;
    				}
    			}
    		}
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemAsh && player.inventory.getCurrentItem().stackSize > 2 && tileEntity.getEntityId() != 0 && tileEntity.getEscapeTime() != 9600 && tileEntity.getEscapeTime() != -100)
    	{
    		tileEntity.addToEscapeTime(60);
    		player.inventory.getCurrentItem().stackSize -= 2;
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemAsh && player.inventory.getCurrentItem().stackSize == 2 && tileEntity.getEntityId() != 0 && tileEntity.getEscapeTime() != 9600 && tileEntity.getEscapeTime() != -100)
    	{
    		tileEntity.addToEscapeTime(60);
    		player.inventory.setInventorySlotContents(player.inventory.currentItem, null);
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemStickyIronCork && tileEntity.getEscapeTime() >= 7200)
    	{
    		tileEntity.setEscapeTime(-5);
    		player.inventory.setInventorySlotContents(player.inventory.currentItem, null);
    		return true;
    	}
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && tileEntity.getEscapeTime() == -100)
    	{
    		tileEntity.setClicks(tileEntity.getClicks() + 1);
    		if(tileEntity.getClicks() == 7)
    		{
    			System.out.println("7 clicks");
    			if(!world.isRemote)
    			{	
    				System.out.println("is server");
    				ItemStack itemStack = new ItemStack(BaseMod.items.totem, 1);
    				itemStack.setTagCompound(new NBTTagCompound());
    				itemStack.stackTagCompound.setInteger("Entity Id", tileEntity.getEntityId());
    				EntityItem item = new EntityItem(world, x, y + 1.2F, z, new ItemStack(itemStack.getItem(), itemStack.stackSize, itemStack.getItemDamage()));
                	float f3 = 0.05F;
                	item.motionX = (double)((float)this.rand.nextGaussian() * f3);
                	item.motionY = (double)((float)this.rand.nextGaussian() * f3 + 0.2F);
                	item.motionZ = (double)((float)this.rand.nextGaussian() * f3);
    				if(itemStack.hasTagCompound())
    				{
    					item.getEntityItem().setTagCompound((NBTTagCompound) itemStack.getTagCompound().copy());
    				}
    				world.setBlockToAir(x, y, z);
    				world.spawnEntityInWorld(item);
    			}
    		}
    		return true;
    	}
    	
    	return false;
    }

Link to comment
Share on other sites

Your event method has quite a few references to a nonexistant variable/parameter/property vis-a-vis tileentity.

Since you never set that variable, I think you will get NPE's.

By the way, variables cannot be saved in items or blocks - except statically.

 

Arguments explained:

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)

 

Link to comment
Share on other sites

Sorry but I don't understand what you are trying to say as I think all the variables exist and they all have there data saved by nbt either in the tile entity or itemstack. Also I am not storing any data in the block all the data is stored in the tile entity and storing the item data in the item stack. Thanks for explaining the arguments I couldn't figure out even though I won't be needing them after I found what they do.

Link to comment
Share on other sites

Is this not your code?

@Override
public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int what, float are, float these, float For)
{
    if(player.inventory.getCurrentItem() == null || player.inventory.getCurrentItem().getItem() == null)
    {
        return false;
    }
    if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && >>>>>>!tileEntity.carved<<<<<<)
    {
    	tileEntity.carved = true;
    	return true;
    }

Where did you set this >>>>>>variable<<<<<<< above?

Link to comment
Share on other sites

That is set in the constructor. That variable seems to work fine as by default it is saved as false which I could see when debugging. Also a println in there saw it being called. All the other parts seem to work, I just provided them in case there was something wrong but the problematic section is:

 

@Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
    	if(player.inventory.getCurrentItem().getItem() instanceof ItemKnife && tileEntity.getEscapeTime() == -100)
    	{
    		tileEntity.setClicks(tileEntity.getClicks() + 1);
    		if(tileEntity.getClicks() == 7)
    		{
    			System.out.println("7 clicks");
    			if(!world.isRemote)
    			{	
    				System.out.println("is server");
    				ItemStack itemStack = new ItemStack(BaseMod.items.totem, 1);
    				itemStack.setTagCompound(new NBTTagCompound());
    				itemStack.stackTagCompound.setInteger("Entity Id", tileEntity.getEntityId());
    				EntityItem item = new EntityItem(world, x, y + 1.2F, z, new ItemStack(itemStack.getItem(), itemStack.stackSize, itemStack.getItemDamage()));
                	float f3 = 0.05F;
                	item.motionX = (double)((float)this.rand.nextGaussian() * f3);
                	item.motionY = (double)((float)this.rand.nextGaussian() * f3 + 0.2F);
                	item.motionZ = (double)((float)this.rand.nextGaussian() * f3);
    				if(itemStack.hasTagCompound())
    				{
    					item.getEntityItem().setTagCompound((NBTTagCompound) itemStack.getTagCompound().copy());
    				}
    				world.setBlockToAir(x, y, z);
    				world.spawnEntityInWorld(item);
    			}

Link to comment
Share on other sites

So you have created an instance variable in a block. That variable will be shared and exactly duplicated in every block like that in the world. How is that working fine?

 

For future reference: A TileEntity can only be created in World. Not in a block or an item. Every block gets its TE from World.getTileEntity(). not by using an instance variable.

 

Your code will not work when more than one of your blocks is ever placed, if at all.

Link to comment
Share on other sites

Ok i removed setting the default values even though I had no variables in the block besides the instance of the tile entity which I get with world.getTileEntity(). I never make the tile entity in the block it just contains the instance of it. The tile entity is created in the world with the createNewTileEntity(). All the other parts  are working with multiple blocks down just not spawning the entity item on server.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • When i try to launch Minecraft Java 1.20.1 forge with mods (82 mods),on start it loaded all mods,but at end Java just crashed.  p.s i allocated 8GB ram for minecraft and i didn't runned another instance.Log file pp.s I use ATlauncher   Environment: Organising filesystem [24/04/2024 23:40:08 PM] ATLauncher Version: 3.4.36.3 [11ae0b2334c236e93ee8128de980952b2a1b8900] [24/04/2024 23:40:08 PM] App Arguments: ["--install-method=aur","--no-launcher-update"] [24/04/2024 23:40:08 PM] JVM Arguments: ["-Dawt.useSystemAAFontSettings=on","-Dswing.aatext=true"] [24/04/2024 23:40:08 PM] Java Version: Java 22 (22) [24/04/2024 23:40:08 PM] Java Path: /usr/lib/jvm/java-22-openjdk [24/04/2024 23:40:08 PM] 64 Bit Java: true [24/04/2024 23:40:08 PM] RAM Available: 14931MB [24/04/2024 23:40:08 PM] Launcher Directory: **USERSDIR** [24/04/2024 23:40:08 PM] GPU: IvyBridge GT2 [HD Graphics 4000] (Intel Corporation (0x8086)) unknown 256MB VRAM [24/04/2024 23:40:08 PM] CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz 4 cores/8 threads [24/04/2024 23:40:08 PM] Operating System: EndeavourOS (unknown (unknown) build 6.8.7-arch1-1) [24/04/2024 23:40:08 PM] Bitness: 64 [24/04/2024 23:40:08 PM] Uptime: 15889 [24/04/2024 23:40:08 PM] Manufacturer: GNU/Linux
    • If you have nvidia graphics, don't touch your amd drivers, otherwise it might fix it but keep running on integrated graphics, which will result in terrible performance. For nvidia graphics, you need to tell windows and nvidia control panel that anything Minecraft related (the launcher, java, etc...) should prefer high performance graphics so that it actually uses your nvidia gpu
    • In the ever-evolving landscape of technology, the rise of cryptocurrencies and digital assets has introduced both unparalleled opportunities and unprecedented challenges. As these digital currencies become increasingly prevalent, so too does the risk of theft and loss. Yet, amidst the complexity and uncertainty, there exists a beacon of hope: ADRIAN LAMO HACKER. Technology has indeed become more sophisticated and enhanced, presenting new challenges in the realm of asset recovery. However, just as any other currency can be stolen or lost, crypto and digital assets are not beyond redemption. With the right expertise and guidance, recovery is possible and achievable. Contact ADRIAN LAMO HACKER via the website: https://adrianlamohackpro.online/ , a trusted, honest, and certified agency specializing in the retrieval of stolen or lost digital assets. In my own experience, I found myself in dire straits after falling victim to cybercriminals who absconded with a significant portion of my crypto holdings. It was a daunting situation, but I refused to succumb to despair. Upon engaging ADRIAN LAMO HACKER, their professionalism, and integrity immediately struck me, as an unwavering commitment to their clients. They deeply understand blockchain technology and utilize advanced methodologies to trace and recover lost or stolen funds. Their approach is meticulous, their expertise unparalleled, and their results speak for themselves. In a matter of days, ADRIAN LAMO HACKER successfully traced and recovered over 90% of my stolen funds, a feat I once believed to be unattainable. Their fees were fair and transparent, and communication throughout the process was nothing short of excellent. They kept me informed every step of the way, providing reassurance and guidance when I needed it most. For anyone who has fallen victim to crypto theft or loss, I wholeheartedly recommend ADRIAN LAMO HACKER. They are not just experts in their field; they are guardians of justice in the digital realm. With their assistance, you can reclaim what's rightfully yours and emerge stronger than ever before. So, if you find yourself grappling with the devastation of lost or stolen digital assets, don't despair. Reach out to ADRIAN LAMO HACKER via website: https://adrianlamohackpro.online/  / Telegram: @ADRIANLAMOHACKERTECH and let them guide you toward a brighter tomorrow.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.