[Fixed] EnderTeleportEvent - TY diesieben07!

[MrArcane111]

Friends,

 

I have run into a bit of an issue. I can negate both the fallDistance (event though it's already 0) and the attackDamage in the EnderTeleportEvent, but my character still takes damage. I did a little bit of investigation and found that the EntityEnderPearl class damages the player without passing the damage through the Event, thus rendering the attackDamage parameter useless.

 

Example:

EnderTeleportEvent event = new EnderTeleportEvent(entityplayermp, this.posX, this.posY, this.posZ, 5.0F);
                    if (!MinecraftForge.EVENT_BUS.post(event))
                    { // Don't indent to lower patch size
                    if (this.getThrower().isRiding())
                    {
                        this.getThrower().mountEntity((Entity)null);
                    }

                    this.getThrower().setPositionAndUpdate(this.posX, this.posY, this.posZ);
                    this.getThrower().fallDistance = 0.0F;
                    this.getThrower().attackEntityFrom(DamageSource.fall, 5.0F);
                    }

 

As you can see, the attack damage is NOT passed through the event. Is this a Forge bug? What can I do to fix this? Thanks for your help!

 

Thanks to diesieben07, this issue has been patched. See the patch here: https://github.com/MinecraftForge/MinecraftForge/pull/1134.

[Abastro]

I think you have to make a pullrequest about that. Or post it to the Suggestion thread.

[MrArcane111]

I think you have to make a pullrequest about that. Or post it to the Suggestion thread.

 

I was hoping that wasn't the case. *sigh* Darn it. I'll go ahead and post it into the suggestions forum.

[jabelar]

What was the fix?

[jabelar]

Thanks.  I see it was actually fixed (I thought maybe the solution was just a different approach or work around).

 

Great to see such responsiveness in getting fixes into the actual active codebase!