Jump to content


Forge Modder
  • Posts

  • Joined

  • Last visited

  • Days Won


Everything posted by Abastro

  1. Don't bump an over-half-year-old thread. Just make your own issue thread with what you've tried.
  2. Oh, you meant zooming in/out from the player. IDK about this issue, setting the render view entity should work well.
  3. A bit unrelated note, you don't need a coremod for zoom. There's FOVUpdateEvent for that.
  4. As Draco said, you can use %s for that. (I didn't know whether '{}' works or not - I always use %s) In my experience, anything beyond %s doesn't work. And as far as I know it's hard to change lang file on the fly(during runtime). You'll need reflection hackery. Why do you need it?
  5. Ah, I didn't read your code carefully. As Choonster said, you don't have to make every fields static. Just the field holding the whole configuration need to be static. You can create a new class containing all the configuration fields. You can do as what Choonster said. You can store the client configuration fields in any class/instance you want if you use it properly. I prefer to put it in either the mod instance or the network instance which can be accessed from the mod instance.
  6. No, the only way you can use will be using server resourcepacks(the one which is only applied when the user allows it). Languages are considered as resources, so you can't modify it with the server-only mod. Also you can't get the server locale. You need to specify details like {} on lang file. For the translation component "key", you set something like 'key=the string is {}'.
  7. Well, why can't you get and set the fields when it's not final? Also you can create instance of RPConfiguration since it's not final. You need separate instance than the static one anyway, considering the combined client. Just send sync packet based on the static configuration and setup separate client config with the packet. Anyway, forge does not have any tool for this. You have to do it yourself.
  8. You mean the tooltip? Because there's no way to translate comments... Then config.modid.common.enabled.name.tooltip will work. Just put the appropriate tooltip for the key in the lang file.
  9. How to implement it is just a matter of choice. You can make a new instance of the RPConfiguration class on client and manually sync the fields. Forge won't do any server-client syncing for you. Or, you could just wait till 1.13 like me, it introduces synchronized data packs.
  10. Minecraft Forge uses it internally, if I recall correctly. It's recommended to use register events: https://mcforge.readthedocs.io/en/latest/concepts/registries/
  11. It's prohibited due to performance, so... Why do you need thousands of wireframe cubes in the first place? I guess that's the part where many optimizations can take in place. Also it's better not to update thousands of vertices every frame. Store them in a VBO and only update it when it's needed. (AFAIK this is also done with chunk rendering. There should be tools for that) Don't call draw many times, it should be one main source of lag. Speedup of 2x is really a BIG improvement, actually. Instead, varying width lines can be done better with quads. Just play with some trigs and coordinates to find the orientation.
  12. Well. @ObjectHolder requires Entity ID, not class. If you took a glance on EntityEntry, you must've found that it holds the class you need... So check for entity with the class.
  13. If you are on the latest version, afaik it's better to check with EntityEntry registry. Use @ObjectHolder to get the entry and check if the class is the same with the class from the entry.
  14. AFAIK notifyBlockUpdate is sufficient. It works both on TEs and Blocks, GiantNuker.
  15. Yes, you should notify it every time something client-related changes. Call World::notifyBlockUpdate with the current blockstate for both old and new for that.
  16. Probably OredictItemPredicate class and this: https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/test/resources/assets/oredict_predicate/advancements/recipes/wood_unlock_tnt.json And this is rather fully-fledged with criterion, but could be help. https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/test/java/net/minecraftforge/debug/OredictItemPredicateTest.java
  17. The factory is for recipes, you need to register ItemPredicate to ItemPredicates.
  18. First, you'll need an item with the DNA capability. I guess it should contain the id of the entity type, but it could vary per what you want. Now I think you don't need DNA caps on entity side. Just iterate through the entity registry to check existing entity types, and do what you want with it. Just don't register items based on entity types. And again, actual implementation varies per what you need - like, how would you use the DNA item? Should it be extracted from the entity? Does dna information vary per each entity-in this case you need entity caps-?
  19. What do you want to say by that? Still the takeMana method can return unchanged value, e.g. when the pylon is off. I guess there could be more bugs causing strange effects. So you should know how to debug, which is basic java skill as well. So. Do you know basic java?
  20. You can do what @jabelar said, or afaik you can perform collision checks yourself by having big AABB collision bound containing all the possible bounds and check the real bounds later in the collision method.
  21. You should eliminate the case where nothing changes during the loop which calls for the infinite loop. Here, takeMana can return mana unchanged in the loop. It shouldn't be doing that.
  22. I'd recommend to have one item to represent all DNAs, as existence of item shouldn't be variable. Then you can use capabilities to store anf expose the DNA.
  23. https://github.com/MinecraftForge/MinecraftForge/wiki/If-you-want-to-contribute-to-Forge + I think it's better to create a new branch for the case when you make multiple PRs at once. Also, afaik it should be on new workspace.
  24. In case of cars, I think it can be classified as an entity because it's in the world and can move with some restrictions. There are several mods implementing that - the only problem here I could see is the collision issues. On the other hand, do you have genuine custom objects which is close to nonexistent in MC, like stars?
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.