Mob attack

[jabelar]

Can he not directly get the target from attackEntityAsMob(), and set fire to that entity? That is, after overriding it properly.

 

He already is.  He has this code:

 

     int fireModifier = EnchantmentHelper.getFireAspectModifier(this);

           if (fireModifier > 0)
           {
               entityTarget.setFire(fireModifier * 4);
           }

 

However, I already explained everything to him in the thread above.  I told him that he either has to set the fire modifier, or he has to directly set the fire damage.

 

Also, I think he's also asking about setting fire to everything nearby -- not necessarily attacked.  So that needs to be in an update method or event.

 

@Soulas97, it seems that you really don't know Java at all and you're trying to do a fairly complex (because it is different than other existing entities) entity mod.  I like helping people, but if you don't understand how to debug a missing space in your code, or how introducing a parameter breaks the override, etc. I really don't think you'll be able to do this.  I don't mean to be mean, just saying that what you're trying to do requires some significant Java (especially your other idea about breaking blocks in new pathfinding to get to attack target).  I think you would do better to start with a simpler idea, extending some existing mobs and just making minor modifications.

[Soulas97]

first how to fix that error? 

 

its a  bit annoying

but strange still it  says to remove @Override

[Zer0HD2]

Ah, I didn't realise he was talking about setting the environment on fire, you're right, that would require the onUpdate() method. And Soulas, as I said above, remove the second argument from your attackEntityAsMob() method. You are not overriding the method created in EntityMob.

[Soulas97]

i think i got it , with code no errors but still doesn't work

 

@Override

  public boolean attackEntityAsMob(Entity entityTarget)

  {

      float attackDamage = (float)getEntityAttribute(SharedMonsterAttributes

            .attackDamage).getAttributeValue();

      int knockbackModifier = 0;

 

      if (entityTarget instanceof EntityLivingBase)

      {

          attackDamage += EnchantmentHelper.getEnchantmentModifierLiving(this,

                (EntityLivingBase)entityTarget);

          knockbackModifier  += EnchantmentHelper.getKnockbackModifier(this,

                (EntityLivingBase)entityTarget);

      }

 

      boolean isTargetHurt = entityTarget.attackEntityFrom(DamageSource

            .causeMobDamage(this), attackDamage);

 

      if (wasDamageDone)

      {

          if (knockbackModifier  > 0)

          {

              entityTarget.addVelocity((double)(-MathHelper.sin(rotationYaw *

                    (float)Math.PI / 180.0F) * (float)knockbackModifier  * 0.5F),

                      0.1D, (double)(MathHelper.cos(rotationYaw *

                    (float)Math.PI / 180.0F) * (float)knockbackModifier  * 0.5F));

              motionX *= 0.6D;

              motionZ *= 0.6D;

          }

 

          int fireModifier = EnchantmentHelper.getFireAspectModifier(this);

 

          if (fireModifier > 0)

          {

              entityTarget.setFire(fireModifier * 4);

          }

 

          // I copied these enchantments from EntityMob, not sure what they do

          if (entityTarget instanceof EntityLivingBase)

          {

              EnchantmentHelper.func_151384_a((EntityLivingBase)entityTarget, this);

          }

 

          EnchantmentHelper.func_151385_b(this, entityTarget);

      }

 

      return isTargetHurt ;

  }

 

[Zer0HD2]

Try actually setting the fireModifier to a number. Right now you're just getting the fire aspect modifier of the mob which, unless you're adding that to it somewhere in your code that you're not showing us, will be 0.

[Soulas97]

nope it still doesn't change anything

[jabelar]

nope it still doesn't change anything

 

so you changed:

int fireModifier = EnchantmentHelper.getFireAspectModifier(this);

           if (fireModifier > 0)
           {
               entityTarget.setFire(fireModifier * 4);
           }

 

Into just something like this:

         entityTarget.setFire(4);

 

Right?

[Soulas97]

i only changed this entityTarget.setFire(fireModifier * 4); into this entityTarget.setFire(4);

[Zer0HD2]

When you say you only changed that, you did remove the if statement, right? If not, then the setFire() code will only be executed when the mob has a fireModifier of more than 0. Which is never.

[Soulas97]

yeah

 

 

  @Override

  public boolean attackEntityAsMob(Entity entityTarget)

  {

      float attackDamage = (float)getEntityAttribute(SharedMonsterAttributes

            .attackDamage).getAttributeValue();

      int knockbackModifier = 0;

 

      if (entityTarget instanceof EntityLivingBase)

      {

          attackDamage += EnchantmentHelper.getEnchantmentModifierLiving(this,

                (EntityLivingBase)entityTarget);

          knockbackModifier  += EnchantmentHelper.getKnockbackModifier(this,

                (EntityLivingBase)entityTarget);

      }

 

      boolean isTargetHurt = entityTarget.attackEntityFrom(DamageSource

            .causeMobDamage(this), attackDamage);

 

      if (wasDamageDone)

      {

          if (knockbackModifier  > 0)

          {

              entityTarget.addVelocity((double)(-MathHelper.sin(rotationYaw *

                    (float)Math.PI / 180.0F) * (float)knockbackModifier  * 0.5F),

                      0.1D, (double)(MathHelper.cos(rotationYaw *

                    (float)Math.PI / 180.0F) * (float)knockbackModifier  * 0.5F));

              motionX *= 0.6D;

              motionZ *= 0.6D;

          }

 

          int fireModifier = EnchantmentHelper.getFireAspectModifier(this);

 

       

              entityTarget.setFire(4);

          }

 

          // I copied these enchantment from EntityMob, not sure what they do

          if (entityTarget instanceof EntityLivingBase)

          {

              EnchantmentHelper.func_151384_a((EntityLivingBase)entityTarget, this);

          }

 

          EnchantmentHelper.func_151385_b(this, entityTarget);

      }

 

      return isTargetHurt ;

 

 

 

but now getting error on return

[jabelar]

What does the error message say?

[Soulas97]

syntax error on token "return" invalid type

[Zer0HD2]

I was trying to avoid this response as long as possible, but I really think you should read up more on Java before you try something like this.

[jabelar]

when i try to add @Override over them i get an error

at this line attackEntityAsMob(Entity entityTarget, boolean wasDamageDone)

idk why it says to remove @Override

 

Sorry but I think you need to learn Java better.  Basically your problem is that Java allows multiple methods to have the same name, as long as the parameter list is different.

 

So attackEntityAsMob(Entity entityTarget, boolean wasDamageDone) is a different method than attackEntityAsMob(Entity entityTarget).

 

@Override is for changing the same method from a parent class.  So @Override only works if you have the same method, including the same exact parameter types.

 

You do need to @Override the actual method because that one is the one that Minecraft automatically calls.  If you want to create a method with additional parameters, you'll have to call it yourself (maybe from the original) but you'll have to get the parameter you intend to pass.

 

This is basic Java really.  You should read a book on Java.  Or take a free course.