[1.7.2][SOLVED] Custom Wood Metadata Issues

[smeagolem]

Hi, David here 

 

I was creating some custom wood logs, and I attempted to do things how Minecraft does using metadata, so I created a copy of the BlockNewLog.class file.

I edited the wood types, added an iteration to get subBlocks, and corrected the icon register location.

Initially, I though it was working, but when I placed any of the custom wood logs, they all became the default type (metadata value 0)(Diamond Wood).

 

Below here you will see that they blocks work fine in the inventory, but all become Diamond Wood upon placement.

 

Here is my custom BlockEveryLog.java file:

package com.djh.everytrees;

import java.util.List;

import net.minecraft.block.BlockLog;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockEveryLog extends BlockLog
{
    public static final String[] woodType = new String[] {"diamond", "gold", "iron"};
    private static final String __OBFID = "CL_00000281";

    /**
     * returns a list of blocks with the same ID, but different meta (eg: wood returns 4 blocks)
     */
    @SideOnly(Side.CLIENT)
    public void getSubBlocks(Item block, CreativeTabs creativeTabs, List list){
    	for(int i = 0; i < woodType.length; i++){
		list.add(new ItemStack(block, 1, i));
	}
    }

    @SideOnly(Side.CLIENT)
    public void registerBlockIcons(IIconRegister iconRegister)
    {
        this.field_150167_a = new IIcon[woodType.length];
        this.field_150166_b = new IIcon[woodType.length];

        for (int i = 0; i < this.field_150167_a.length; ++i)
        {
            this.field_150167_a[i] = iconRegister.registerIcon(EveryTrees.MODID + ":" + this.getTextureName() + "_" + woodType[i]);
            this.field_150166_b[i] = iconRegister.registerIcon(EveryTrees.MODID + ":" + this.getTextureName() + "_" + woodType[i] + "_top");
        }
    }
}

 

I tried to figure out how Minecraft handles the block placement with metadata, but to no solution.

Do I have to create a custom BlockLog.class file in addition? and if so, how would I implement handing the metadata wood types?

Anyone have any ideas?

[larsgerrits]

You need to specify a ItemBlock in the GameRegistry call.

[smeagolem]

You need to specify a ItemBlock in the GameRegistry call.

 

I do believe I have done that.

 

Here's my code for my main mod file:

package com.djh.everytrees;

import net.minecraft.block.Block;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;

// Define Basic Information for Mod
@Mod(modid = EveryTrees.MODID, version = EveryTrees.VERSION)

public class EveryTrees {
public static final String MODID = "everytrees";
public static final String VERSION = "0.1";

// Define Blocks
public static Block blockEveryLog;

// Define Creative Tabs
public static CreativeTabs tabEveryTrees;

@EventHandler
public void Load(FMLPreInitializationEvent event){

	// Settings for Custom Tabs
	tabEveryTrees = new CreativeTabs("tabEveryTrees"){
		public Item getTabIconItem() {
			return Item.getItemFromBlock(blockEveryLog);
		}
	};

	// Settings for Blocks
	blockEveryLog = new BlockEveryLog()
		.setBlockTextureName("log")
		.setBlockName("blockEveryLog")
		.setHardness(1.5F)
		.setCreativeTab(tabEveryTrees);


	// Register Blocks
	GameRegistry.registerBlock(blockEveryLog, ItemEveryLog.class, blockEveryLog.getUnlocalizedName().substring(5));

}
}

 

and here's the code for my ItemEveryLog file:

package com.djh.everytrees;

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;

public class ItemEveryLog extends ItemBlock {

public ItemEveryLog(Block block) {
	super(block);
	this.setHasSubtypes(true);
}

public String getUnlocalizedName(ItemStack itemStack){
	int i = itemStack.getItemDamage();
	if (i < 0 || i >= BlockEveryLog.woodType.length){
		i = 0;
	}

	return super.getUnlocalizedName() + "." + BlockEveryLog.woodType[i];
}

public int getMetaData(int meta){
	return meta;
}

}

 

And also, here's my en_US.lang file:

tile.blockEveryLog.diamond.name=Diamond Wood
tile.blockEveryLog.gold.name=Gold Wood
tile.blockEveryLog.iron.name=Iron Wood

itemGroup.tabEveryTrees=Every Trees

The names work fine which is good 

 

Is there something else I need to add into this?

[cad97]

In the BlockWood.class I found this:

    /**
     * Determines the damage on the item the block drops. Used in cloth and wood.
     */
    public int damageDropped(int p_149692_1_)
    {
        return p_149692_1_;
    }

 

You'll need to use this so the block drops the correct item. I remember seeing something similar for block placement but I can't find it right now - if you look some you should be able to find it. What's happening is that the game doesn't realize when you place the item that it needs to convert damage -> metadata. The above should take care of block -> item, but as stated I can't find the call for item -> block.

[cad97]

OK so going back into it - make sure that when you are getting the items it is the item from the item class if you are using it and not the auto-item-from-block. The item then needs the

/**
     * Returns the metadata of the block which this Item (ItemBlock) can place
     */
    public int getMetadata(int par1)
    {
        return 0;
    }

method overridden.

[smeagolem]

OK so going back into it - make sure that when you are getting the items it is the item from the item class if you are using it and not the auto-item-from-block. The item then needs the

/**
     * Returns the metadata of the block which this Item (ItemBlock) can place
     */
    public int getMetadata(int par1)
    {
        return 0;
    }

method overridden.

 

After staring at this for a while, I suddenly realised the error of my ways, I feel like such a pleb 

In my ItemEveryLog file, I had misspelled Metadata as MetaData.

 

That one small change and everything works!

package com.djh.everytrees;

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;



public class ItemEveryLog extends ItemBlock {

public ItemEveryLog(Block block) {
	super(block);
	this.setHasSubtypes(true);
}

public String getUnlocalizedName(ItemStack itemStack){
	int i = itemStack.getItemDamage();
	if (i < 0 || i >= BlockEveryLog.woodType.length){
		i = 0;
	}

	return super.getUnlocalizedName() + "." + BlockEveryLog.woodType[i];
}

public int getMetadata(int meta){
	return meta;
}

}

 

Sorry for wasting people's time 

 

But thankyou cad97 and larsgerrits 

The damageDropped() code was already implemented because my file BlockEveryLog extends the standard Minecraft class BlockLog which extends BlockRotatedPillar which contains damageDropped() anyway.

 

Thanks for all the help