Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED on 1137]Anyone else seeing memory leaks on 1133 "latest" version Forge?

jabelar

By jabelar
in Modder Support

 Share

Recommended Posts

jabelar Reality Controller

jabelar

Posted
Posted

I updated to 1133 and am getting several indications of memory leaks.  JVM is regularly shutting down for being out of heap (even though I have run parameters set for mimimum of 4GB) and just now Windows warned it was getting dangerously low on memory (due to JVM process) and then promptly crashed all of Windows.

 

It could be something I did, although the mod I'm running is very basic and doesn't seem to have anything I would consider problematic.

 

It is probably me, but just wanted to see if anyone else saw similar issue?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

brandon3055 Diamond Finder

brandon3055

Posted
Posted

Hmm i was just considering updating to 1133 10 seconds before reading this post.... oh what the heck im updating to 1133 will let you know if i encounter anything problematic.

 

Edit: My client has been running on 1133 for a few minutes now and i haven't noticed any increase in memory use.

I am the author of Draconic Evolution

jabelar Reality Controller

jabelar

Posted
  • Author
Posted

Hmm i was just considering updating to 1133 10 seconds before reading this post.... oh what the heck im updating to 1133 will let you know if i encounter anything problematic.

 

Edit: My client has been running on 1133 for a few minutes now and i haven't noticed any increase in memory use.

 

I should clarify that it doesn't happen to me every time.  Actually it seems to happen over several consecutive runs.  On average maybe on 10th run or so.  It is like the JVM doesn't exit properly after running or something -- I think I saw the task manager with four or five JVMs running.

 

I'll keep monitoring it to see if I can figure out any pattern to it.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

jabelar Reality Controller

jabelar

Posted
  • Author
Posted

Okay, it seems like the JVM isn't exiting properly.  I'm getting multiple copies of JVM running.  Currently i see four running and they each take about 1.5GB.  Note that I only have one Minecraft instance running on task bar, I'm sure of that.  I'm also just quitting Minecraft using the standard "Quit Game" button.

 

I think (can you guys confirm), that there should be two JVM tasks showing in the task manager -- one for Eclipse and one for the running mod.  I can see that even after I exit Minecraft that a JVM task that says it is is the mod continues to run...

 

It still doesn't happen 100% of the time though.  I'll try to see if I can find a pattern.

 

Anyone have any ideas on why this might happen (JVM continues to run even though Minecraft is quit)?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

shadowmage4513 Creeper Killer

shadowmage4513

Posted
Posted

Just a stab/guess -- but it is probably related to cpw's recent security manager additions that... 'catch' when you exit Minecraft.  I'd wager that there is still some work to do on the system.  Looks like it was added in @ version 1029.

 

I would say test to see that it happens with just forge/no mods installed, and submit a ticket with FML on the problem.

jabelar Reality Controller

jabelar

Posted
  • Author
Posted

Just a stab/guess -- but it is probably related to cpw's recent security manager additions that... 'catch' when you exit Minecraft.  I'd wager that there is still some work to do on the system.  Looks like it was added in @ version 1029.

 

I would say test to see that it happens with just forge/no mods installed, and submit a ticket with FML on the problem.

 

I was wondering the same thing (if it is related to security manager): when exiting the errors are now definitely different and related to the security manager stuff.  Quitting the game now shows following console errors:

[09:45:24] [Client thread/ERROR]: Unable to launch
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[?:1.7.0_51]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_51]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_51]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:134) [launchwrapper-1.9.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]
Caused by: cpw.mods.fml.relauncher.FMLSecurityManager$ExitTrappedException
at cpw.mods.fml.relauncher.FMLSecurityManager.checkPermission(FMLSecurityManager.java:23) ~[forgeSrc-1.7.2-10.12.2.1133.jar:?]
at java.lang.SecurityManager.checkExit(SecurityManager.java:761) ~[?:1.7.0_51]
at java.lang.Runtime.exit(Runtime.java:107) ~[?:1.7.0_51]
at java.lang.System.exit(System.java:962) ~[?:1.7.0_51]
at net.minecraft.client.Minecraft.shutdownMinecraftApplet(Minecraft.java:878) ~[Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:948) ~[Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:112) ~[Main.class:?]
... 6 more

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Bektor Dragon Slayer

Bektor

Posted
Posted

Just a stab/guess -- but it is probably related to cpw's recent security manager additions that... 'catch' when you exit Minecraft.  I'd wager that there is still some work to do on the system.  Looks like it was added in @ version 1029.

 

I would say test to see that it happens with just forge/no mods installed, and submit a ticket with FML on the problem.

Memory leaks. That sounds like that: http://www.minecraftforge.net/forum/index.php/topic,20213.0.html

Well, its not exact the same problem, but there are memory lags to by generating a jungle world. (Here memory leaks on launching, there on generating a world with a jungle biome)

Developer of Primeval Forest.

brandon3055 Diamond Finder

brandon3055

Posted
Posted

Ok so i am seeing the same error in my console when i quit except it is followed by

Disconnected from the target VM, address: '127.0.0.1:50215', transport: 'socket'

Just a guess but maby my IDE (Intellij) is detecting that the process didn't shut down properly and is terminating it.

 

Edit: Oh it is happening to me you just have to actually load a world. Fortunately for me Intellij tracks each instants it launches separately so i can just shut it down from the console.

 

Unless you need to save your world i recommend terminating the instance from your IDE and that should completely stop it.

I am the author of Draconic Evolution

jabelar Reality Controller

jabelar

Posted
  • Author
Posted

Yeah, now that I know what is happening I can shut down the task in various ways -- I'm just using the task manager.

 

Anyway, I guess this is "solved" since it seems to be a actual issue with the latest release (as opposed to something I'm doing wrong) and it can be worked around.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • elyon44
      Forge 1.12 doesn't download a file

      By elyon44 · Posted

      Okay. Thank you anyway
    • TileEntity
      Forge 1.12 doesn't download a file

      By TileEntity · Posted

      It is 1.12.2 - I have no idea if there is a 1.12 pack
    • elyon44
      Forge 1.12 doesn't download a file

      By elyon44 · Posted

      Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • vals_kenway
      Problem Sync Client-server for Entity Mount

      By vals_kenway · Posted

      Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • TileEntity
      Trying to play any world is stuck on 100% loading and shuts down computer

      By TileEntity · Posted

      Also make a test without EMF (Entity Model Features)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept