[SOLVED][1.7.2] Packet data not received onMessage?

[coolAlias]

SOLUTION: Use the IMessageHandler#onMessage 'message' parameter to access the field, rather than trying to access the class field directly (it's a separate instance of the class when it processes the IMessageHandler vs the IMessage) - thanks jabelar!

 

Hi again,

 

I've run into an interesting problem - it seems that data stored in a message class is not available in the "onMessage" method. This is with Forge 10.12.2.1121 by the way.

 

Here is the code for my message:

 

public class SyncPlayerPropsMessage implements IMessage, IMessageHandler<SyncPlayerPropsMessage, IMessage>
{
private NBTTagCompound data;

public SyncPlayerPropsMessage() {}

public SyncPlayerPropsMessage(EntityPlayer player) {
data = new NBTTagCompound();
ExtendedPlayer.get(player).saveNBTData(data);
}

@Override
public void fromBytes(ByteBuf buffer) {
System.out.println("From Bytes... reading");
data = ByteBufUtils.readTag(buffer);
if (data == null) {
System.out.println("WARNING: Data read from buffer is NULL!!!");
}
}

@Override
public void toBytes(ByteBuf buffer) {
System.out.println("To Bytes... writing");
if (data == null) {
System.out.println("WARNING: Data to write is NULL!!!");
}
ByteBufUtils.writeTag(buffer, data);
}

@Override
public IMessage onMessage(SyncPlayerPropsMessage message, MessageContext ctx) {
if (data == null) {
System.out.println("WARNING: onMessage data is NULL!!!");
}
return null;
}

 

 

And console output from that:

To Bytes... writing
From Bytes... reading
WARNING: onMessage data is NULL!!!

 

As you can see, the data is not null before it is written, nor is it null after it is read, but whatever happens in between being read and processing onMessage, the data disappears!

 

In another message, I send a simple integer, and that one has the same problem. I thought it was working, but it was only because the value I sent was zero (the GUI index to open) - changing it to 10 failed to open a Gui.

 

Any ideas what could be going wrong here?

 

Thanks,

coolAlias

[jabelar]

I haven't played much with this, but why are you testing data == null instead of message.data == null?  Shouldn't you be trying to look at the data in the message passed as a parameter to that method?

[coolAlias]

I haven't played much with this, but why are you testing data == null instead of message.data == null?  Shouldn't you be trying to look at the data in the message passed as a parameter to that method?

Lol, you are totally right! I was thinking 'hey, it's in the same class, so the data will be there' wow. Derpety derp derp Thanks buddy!