Jump to content

[1.7.10] onItemInteractionForEntity problem


tiny_tim

Recommended Posts

Hello I'm not sure if this is a bug with the 1.7.10 release of the Forge source but I'm having trouble with the onItemInteractionForEntity method. It doesn't seem like it's actually firing when I right click with my item when I'm looking at a chicken.

 

Here's the code for my item:

 

package com.rikktergames.chicken.items;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.passive.EntityChicken;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;

public class EggExtractor extends Item{

public EggExtractor(int i){

	super();

	this.setTextureName("chicken:stick");
	this.setUnlocalizedName("eggextractor");
	this.setCreativeTab(CreativeTabs.tabTools);

	this.maxStackSize = 1;
	this.setMaxDamage(10);
	this.setNoRepair();

}

public boolean onItemInteractionForEntity(ItemStack itemStack, EntityLiving entity){
	if(entity instanceof EntityLiving){
		if(entity instanceof EntityChicken){
			entity.setDead();
			return true;
		}
	}
	return false;		
}
}

 

Any help on this would be amazing as I have been searching to see if anything would help but so far it hasn't. Also if there is anything else you need just tell me and I'll post it!

Link to comment
Share on other sites

EntityLiving instance of EntityLiving???

 

Yeah that's definitely not needed and just repetitious and it was due to the fact I was getting desperate and I was just going around to forum posts just implementing things people were saying would fix it, and I guess I read it wrong or something. But I have tried it without that and just the if(entity instanceof EntityChicken) but that still didn't work at all. 

Link to comment
Share on other sites

Oh i slipped that line:

onItemInteractionForEntity()

Where did you get that? There is no such method like this in Item.class.

If you want to do stuff with right click on entity use EntityInteractEvent!

 

Do you think you could give me an example, or link me to one, of how this would work for my case?

Link to comment
Share on other sites

Never mind I figured out you have to put it in an event handler and got it working. Thank you so much for telling me this! I guess I was following all of those forum posts wrong because I could have sworn that they were saying onItemInterationForEntity() was for items.

Link to comment
Share on other sites

Oh i slipped that line:

onItemInteractionForEntity()

Where did you get that? There is no such method like this in Item.class.

If you want to do stuff with right click on entity use EntityInteractEvent!

There is a method called

itemInteractionForEntity

which I use in my bucket class to fill the milk bucket.

So its pretty useless to make a event handler for a built in function in the item class...

https://github.com/KeeperofMee/Survival/blob/master/com/keeperofmee/survival/items/buckets/SmTinBucket.java

If I helped please press the Thank You button.

Link to comment
Share on other sites

Guys, you should really use @Override annotation so your IDE (Eclipse in my case) will check for you whether you've got the method name and parameter types correct.  In Java, if you made a simple spelling mistake in the method name it will think you did it purposefully and won't create any warning.  But it will never get called because the properly named method will exist in the parent class and get run from there.

 

There are two ways to use @Override to check.  One is you can get in the habit of always putting @Override when you think you're using an inherited method.  The other way (I do this cause I'm a bit lazy) is to set up your Eclipse so that on save it will add the @Override for you.  If you do that, then the idea is that when you save (and you should save often) you should look to confirm that @Override was added where expected. 

 

If you had used it in this case, you wouldn't be arguing about whether there was such a method, or whether it was added in 1.7.x -- the IDE would tell you right away if it was an existing method.

In any case, not using @Override will cause you to make mistakes that will be very hard to catch later.  Use @Override!

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.