Jump to content

Recommended Posts

Posted

Hello, new to modding :)

I'm making a ComputerCraft peripheral (that's why I use 1.6), and I followed many tutorials to get a working inventory in a block. I can put items in it, the problem is that the items are destroyed when the block is unloaded. I tried to save the ItemStack to NBT tag, but I can't find where I should get the tag to save in. Here is my TileEntity (scrapped all CC peripheral stuff)

 

package niverton.ccscanner;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ResourceLocation;


public class TileEntityScanner extends TileEntity implements IInventory {

public static final String tileid = "TileEntityScanner";
private ItemStack inventory;

//Constructor
TileEntityScanner() {
	super();
}

//------------------
//Inventory functions

@Override
public void readFromNBT(NBTTagCompound nbt) {
	super.readFromNBT(nbt);

	NBTTagCompound tag = nbt.getCompoundTag("Inventory");
	inventory = ItemStack.loadItemStackFromNBT(tag);
}

@Override 
public void writeToNBT(NBTTagCompound nbt) {
super.writeToNBT(nbt);
//Writing inventory to NBT
if (inventory != null) {
	NBTTagCompound item = new NBTTagCompound();
	//Writing inventory to new NBT tag
	inventory.writeToNBT(item);
	//Saving the tag to list
	nbt.setTag("Inventory", item);
}
//Should store each ItemStack tag to a NBTTagList if has multiple slots
}

@Override
public ItemStack decrStackSize(int slot, int count) {
ItemStack itemstack = getStackInSlot(slot);

if(itemstack != null) {
	if(itemstack.stackSize <= count)
		setInventorySlotContents(slot, null);
	else
		itemstack = itemstack.splitStack(count);
	onInventoryChanged();
}
return itemstack;
}

@Override
public ItemStack getStackInSlotOnClosing(int i) {
ItemStack itemstack = getStackInSlot(i);
setInventorySlotContents(i, null);
return itemstack;
}

@Override
public void setInventorySlotContents(int i, ItemStack itemstack) {
inventory = itemstack;
if(itemstack != null && itemstack.stackSize > getInventoryStackLimit())
	itemstack.stackSize = getInventoryStackLimit();
onInventoryChanged();
}

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack) {
return true;
}

@Override
public int getSizeInventory() {
return 1;
}

@Override
public int getInventoryStackLimit() {
return 64;
}

@Override
public ItemStack getStackInSlot(int i) {
return inventory;
}

@Override
public String getInvName() {
return "Scanner";
}

@Override
public boolean isInvNameLocalized() {
return true;
}

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer) {
return entityplayer.getDistanceSq(xCoord + 0.5D, yCoord + 0.5D, zCoord + 0.5D) <= 64;
}

@Override
public void openChest() {
}

@Override
public void closeChest() {
}

}

 

I know my TileEntity is working properly, because the CC stuff works, I just can't get it to save the inventory when the block is unloaded. Thanks !

Posted

You see that nbt tag passed into the read/write nbt methods? Yeah, those. Use that nbt instance passed in. You don't have to call the read/write methods, Minecraft does that for you (only in entities, and stuff like that... Yeah... Only entities).

 

So, you just need to write/read from that nbt tag instance passed in.

We all stuff up sometimes... But I seem to be at the bottom of that pot.

Posted

There's a ComputerCraft 1.6 beta for 1.7.2.

 

I would recommend developing a peripheral for that, instead :)

 

I'd like to use my mod in Tekkit, but the modpack isn't updated to 1.7 :/

But thanks for the heads up, didn't see this beta :)

 

You see that nbt tag passed into the read/write nbt methods? Yeah, those. Use that nbt instance passed in. You don't have to call the read/write methods, Minecraft does that for you (only in entities, and stuff like that... Yeah... Only entities).

 

So, you just need to write/read from that nbt tag instance passed in.

 

Can you be more sarcastic and less precise please ? When are those functions called by Minecraft ? What did I do wrong implementing them ? Are you talking about entities like players and mobs or does it apply to TileEntities as well ? Also, should I override onInventoryChanged() ?

Posted

Can you be more sarcastic and less precise please?

 

Of course I can.

 

 

Have you gone full debug mode on your code? Sysouts in the read/write methods to see if the are actually called? And just a note, the read/wrote methods are called... Somewhere but it is all handled by TileEntity. And TileEntities are entities, therefore, only entities have NBT.

 

As for what you did wrong... Could be all manner of things. You never know.

We all stuff up sometimes... But I seem to be at the bottom of that pot.

Posted

After testing, the write function is called every 45 seconds, so I should probably override onChunkUnload() to write the inventory to NBT. The read function, however, is never called, so I have to call it manually when the TileEntity is created. The problem is to get the previous tag. They're stored in the world files, so I should be able to read it from a World object, right ? But I can't find a method that gives me the tag in that class

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi all,  I have the following issue: I'd like to parse some json using gson and rely on the (somewhat new) java record types. This is supported in gson 2.10+. Gson is already a dependency used by minecraft, however it's 2.8.x for 1.19.2 which I'm targeting at the moment. My idea was to include the newer version of the library in my mod and then shadow it so it gets used inside the scope of my mod instead of the older 2.8. This works fine for building the jar: If I decompile my mod.jar, I can see that it's correctly using the shadowed classes. However obviously when using the runClient intellj config, the shadowing doesn't get invoked. Is there any way of invoking shadow when using runClient, or am I on the wrong track and there's a better way of doing this entirely? Thanks in advance!
    • Yep I did upgrade just because it showed me a new version available.  I'll redownload the mod list and make sure anything works.  Thanks!
    • The latest log was taken down by pastebin for some reason. Did you try removing the mods you added? The mods you updated, was there a specific reason you updated, or just because? It's possible the updates introduced incompatibilitie, or even need a newer build of forge. If you didn't need the updates for a specific reason, you could also try downgrading those mods.
    • Please read the FAQ, and post logs as described there. https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/
    • I am using forge 1.20.1 (version 47.3.0). My pc has an RTX 4080 super and an i9 14900 KF, I am on the latest Nvidia graphics driver, latest windows 10 software, I have java 23, forge 1.12.2 works and so does all vanilla versions but for some reason no version of forge 1.20.1 works and instead the game just crashes with the error code "-1." I have no mods in my mods fodler, I have deleted my options.txt and forge.cfg files in case my settings were causing a crash and have tried removing my forge version from the installations folder and reinstalling but no matter what I still crash with the same code and my log doesn't tell me anything: 18:34:53.924 game 2025-02-06 18:34:53,914 main WARN Advanced terminal features are not available in this environment 18:34:54.023 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, mrmirchi, --version, 1.20.1-forge-47.3.0, --gameDir, C:\Users\aryam\AppData\Roaming\.minecraft, --assetsDir, C:\Users\aryam\AppData\Roaming\.minecraft\assets, --assetIndex, 5, --uuid, 2db00ea8d678420a8956109a85d90e9d, --accessToken, ????????, --clientId, ZWI3NThkNzMtNmNlZS00MGI5LTgyZTgtYmZkNzcwMTM5MGMx, --xuid, 2535436222989555, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\aryam\AppData\Roaming\.minecraft\quickPlay\java\1738838092785.json, --launchTarget, forgeclient, --fml.forgeVersion, 47.3.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412] 18:34:54.027 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.8 by Microsoft; OS Windows 10 arch amd64 version 10.0 18:34:54.132 game [18:34:54] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow 18:34:54.191 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6 18:34:54.303 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6 18:34:54.367 monitor Process Monitor Process crashed with exit code -1     screenshot of log: https://drive.google.com/file/d/1WdkH88H865XErvmIqAKjlg7yrmj8EYy7/view?usp=sharing
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.