Jump to content

Recommended Posts

Posted

Hi,

 

I have searched the death out of this for a few hours now and come up empty.  Basic principle of what I'm doing is that if a player places a block, that block will place a number of other blocks relative to it's position.

 

I can get onBlockAdded to work no problem, except that's called every time the block is added in game even if it's not by the player, as you can imagine this doesn't end well with each block replicating into more and more.

 

So I found onBlockPlaced but I simply cannot get it to work no matter what I do.  does anyone have an example usage of onBlockPlaced? or even onBlockPlacedBy if that would be the more correct approach?

 

Many thanks in advance kind people :)

Posted

Ok, I broke it down to absolute basic level to debug and these are the two I have:

 

public void onBlockAdded(World world, int x, int y, int z) 
{

System.out.println("I Added");

world.setBlock(x, y+1, z, this);

}

 

public void onBlockPlaced(World world, int x, int y, int z) 
{

System.out.println("I Placed");

world.setBlock(x, y+1, z, this);

}

 

Now, the onBlockAdded works no problem (except making a never ending pillar into the sky of course), but the onBlockPlaced doesn't even run it's debug print.  I'm clearly using it incorrectly but I can't figure out how it would be used. 

 

Moreover, I can't say for sure that I know that onBlockPlaced only runs on player placement (I'm kinda just going off the name), which lead me to believe I may need onBlockPlacedBy, for which the syntax becomes less clear.

Posted

Ok, after a bit of headscratching I can think of a workaround...  If I have two blocks, same texture, however one is placed by the player and one is the spawned one.  Call them block1 and block2 with position x y z being the initial placement position of block1.

 

on placement of block1

place block2 at (x, y, z)

for counter = 1 to countercap

	if (x,y+counter,z) = air then

		place block2 at (x, y+counter, z)

	else

		break

 

Where countercap is the max distance for the blocks to go.

 

It's pretty messy, but until i figure out how to differentiate between the player placing a block and it just being added it'll have to do...

 

 

 

Posted

Your onBlockPlaced doesn't work, because you're not overriding it, you created your own function. The signature for it is not the same as in the Block class. Always use @Override annotations to check if you overrode it correctly. Here are the signatures for these methods in Block.java:

public void onBlockAdded(World, int, int, int)
public int onBlockPlaced(World, int, int, int, int, float, float, float, int)
public void onBlockPlacedBy(World, int, int, int, EntityLivingBase, ItemStack)

Posted

Haha perfect timing! I'd just finished fudging it with multiple blocks, it worked but it made me feel dirty. 

 

Thankyou, however I'm still not quite there.  After popping @Override above the Public int onBlockPlaced, i receive the error:

The method onBlockPlaced(World, int, int, int) of type BlockNumenorStone must override or implement a supertype method

 

I think that this is likely just me being very noobish with the Java language, so I understand if I don't get a reply to how to resolve that.

Posted

@Override only checks if you've overriden a supertype method, so you get an error when you didn't, and because of that you know where you've made a mistake.

This annotation, however, doesn't actually make the method override anything.

For it to override a supertype method, it has to have the same signature and the modifiers as the one in the superclass.

A signature of a method is what follows:

  • its name: onBlockPlaced
  • its parameter types: World, int, int, int, int, float, float, float, int

While the method name is important, the parameter names are only for your convenience.

Now look at the error you got. It says that the method onBlockPlaced(World, int, int, int) must override or implement a supertype method.

The supertype method signature for onBlockPlaced is:

onBlockPlaced(World, int, int, int, int, float, float, float, int)

And the modifiers are:

public int

As you can see, it is not the same as your method.

You have to change the parameters of your method to be the same as in the supertype, and then it is going to override it.

Posted

internet-high-five.jpg

 

	@Override
public int onBlockPlaced(World world, int x, int y, int z, int a, float b, float c, float d, int e)

 

fixes it perfectly :)  Thank you very much , and another Java lesson learned for me today!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to create block with entity, that will have height of 3 or more(configurable) and I tried to change first VoxelShape by increasing collision box on height I want and for changing block height on visual side i tried to configure BlockModelBuilder:  base.element() .from(0, 0, 0) .to(16f, 48f, 16f) .face(Direction.UP).texture("#top").end() .face(Direction.DOWN).texture("#bottom").end() .face(Direction.NORTH).texture("#side").end() .face(Direction.SOUTH).texture("#side").end() .face(Direction.WEST).texture("#side").end() .face(Direction.EAST).texture("#side").end() .end(); but, getting crash with next error: Position y out of range, must be within [-16, 32]. Found: %d [48.0]; Looks like game wont to block height modified by more than 32. Is there any way to fix that problem?
    • As long as the packets you are sending aren't lost, there's nothing wrong with what you're currently doing. Although, this sounds like something that would benefit from you making your own datapack registry instead of trying to arbitrarily sync static maps. Check out `DataPackRegistryEvent.NewRegistry`.
    • Hey all, I've been working a lot with datapacks lately, and I'm wondering what the most efficient way to get said data from server to client is.  I'm currently using packets, but given that a lot of the data I'm storing involves maps along the lines of Map<ResourceLocation, CustomDataType>, it can easily start to get messy if I need to transmit a lot of that data all at once. Recently I started looking into the ReloadableServerResources class, which is where Minecraft stores its built-ins.  I see you can access it via the server from the server's resources.managers, and it seems like this can be done even from the client to appropriately retrieve data from the server, unless I'm misunderstanding.  However, from what I can tell, this only works via built-in methods such as getRecipeManager() or getLootTables(), etc.  These are all SimpleJsonResourceReloadListeners, just like my datapack entries are, so it seems like it could be possible for me to access my datapack entries similarly?  But I don't see anywhere in ReloadableServerResources that stores loaded modded entries, so either I'm looking in the wrong place or it doesn't seem to be a thing. Are packets really the best way of doing this, or am I missing a method that would let me use ReloadableServerResources or something similar?
    • Hi, everyone! I'm new to minecraft modding stuff and want ask you some questions. 1. I checked forge references and saw there com.mojang and net.minecraft (not net.minecraftforge) and as I understand it's original game packages with all minecraft logic inside including renderers and so on, right? 2. Does it mean that forge has a limited set of instruments which doesn't cover all the aspects of the game? If make my question more specific then does forge provide such instruments that allow me totally change minecraft itself, like base mechanics and etc.? Or I have to use "original game packages" to implement such things? 3. I actively learning basic concepts with forge documentation and tutorials. So in my plans make different inventory system like in diabloids. Is that possible with forge? 4. It is last question related to the second one. So how deeply I can change minecraft with forge? I guess all my questions above because of that I haven't globally understanding what forge is and how it works inside and how it works with minecraft. It would be great if you provide some links or topics about it or explain it by yourself but I guess it's to big to be explained in that post at once. Anyway, thank you all for any help!
    • Im trying add to block a hole in center, just a usual block and in center of it on up side, there is should be a hole. I tried to add it via BlockModelBuilder, but its not working. Problem is that it only can change block size outside. I tried it to do with VoxelShape and its working, but its has been on server side and looks like its just changed collision shape, but for client, there is a texture covering this hole. I tried to use: base.renderType("cutout"); and removed some pixels from texture. I thought its should work, but game optimization makes block inside looks transparent. So, only custom model?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.