Jump to content

How to get a nice name for a block?


McJty

Recommended Posts

Hi all, I'm using 1.7.10 and latest forge and I'm trying to get the nice name (like WAILA would show to the player) of any block. I have tried this:

 

String name = block.getLocalizedName();

 

and this:

 

String name = new ItemStack(block).getDisplayName();

 

Both pieces of code work and give me nice names for some of the blocks. I get "Stirling Generator" for a stirling generator from EnderIO for example. However, for some blocks it doesn't work. EnderIO conduits give me 'tile.blockConduitBundle.name' instead of 'Energy Conduit' which WAILA shows me.

 

So how can I achieve what WAILA does and give me a good name for any block in the game?

 

Thanks!

 

 

Link to comment
Share on other sites

You can use StatCollector.translateToLocal() to localized the name.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Show how you're using it. Preferably the whole method you use that class in.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

    @Override
    public void drawScreen(int xSize_lo, int ySize_lo, float par3) {
        super.drawScreen(xSize_lo, ySize_lo, par3);
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        this.mc.getTextureManager().bindTexture(iconLocation);
        int k = (this.width - this.xSize) / 2;
        int l = (this.height - this.ySize) / 2;

        this.drawTexturedModalRect(k, l, 0, 0, this.xSize, this.ySize);

//        this.drawVerticalLine(k + 15, l, l + 100, 0x334455);

        int y = 0;
        HashMap<Coordinate,BlockInfo> connectedBlocks = monitorItem.getConnectedBlocks();
        for (Map.Entry<Coordinate,BlockInfo> me : connectedBlocks.entrySet()) {
            Block block = me.getValue().getBlock();
            Coordinate coordinate = me.getKey();
            ItemStack s = new ItemStack(block, 1, 0);
            String lname = block.getLocalizedName();
            System.out.println("I18n = " + I18n.format(lname));
            System.out.println("Stat = " + StatCollector.translateToLocal(lname));

            mc.fontRenderer.drawString(s.getDisplayName(), k + 5, l + 5 + y, 1677215);
            mc.fontRenderer.drawString(coordinate.toString(), k+160, l+5+y, 1677215);

            y += mc.fontRenderer.FONT_HEIGHT + 2;
        }

        this.drawGradientRect(k + xSize-20, l + 5, k + xSize-5, l + ySize - 5, 0xFFFF0000, 0xFF00FF00);

        mc.fontRenderer.drawString("###", k + 15, l, 0x334455);
//        this.drawVerticalLine(k+15, l, l + 50, -9408400);
    }
}

 

The s.getDisplayName() is what I'm currently using as that gives the best result. But nothing of the above methods manages to give a nice name for the EnderIO energy conduits.

 

 

 

Link to comment
Share on other sites

I looked at the EnderIO github and in the en_US.lang file, instead of the reguler tile.*.name, they have enderio.*.name. That's the reason it doesn't work. Try using the block.getLocalizedName method.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

If any of the blocks in your map are sub-blocks (blocks with instance-based metadata other than 0), then your method will not work at all on them.

Link to comment
Share on other sites

If any of the blocks in your map are sub-blocks (blocks with instance-based metadata other than 0), then your method will not work at all on them.

 

Ok, but what should I do then? I know it is possible because WAILA shows a good name in its tooltip.

Link to comment
Share on other sites

If any of the blocks in your map are sub-blocks (blocks with instance-based metadata other than 0), then your method will not work at all on them.

 

Ok, but what should I do then? I know it is possible because WAILA shows a good name in its tooltip.

WAILA uses the (ItemStack) result of getPickedBlock and gets its name. The enderIO conduit blocks are never normally obtainable, so they do not have proper names for the block instances themselves, only the items you get when crafting or breaking them. The same applies, for example, to RotaryCraft blocks and TE conduits.

Link to comment
Share on other sites

Ok, that didn't seem to work. I couldn't find a getPickedBlock function but I found Item.getItemForBlock() which seems to be what I need. This gives as result:

 

            Item itemDropped = Item.getItemFromBlock(block);
            System.out.println("itemDropped.getUnlocalizedName() = " + itemDropped.getUnlocalizedName());
            System.out.println("new ItemStack(itemDropped).getDisplayName() = " + new ItemStack(itemDropped).getDisplayName());

 

This gives as output for an EnderIO item conduit:

 

itemDropped.getUnlocalizedName() = tile.blockConduitBundle
new ItemStack(itemDropped).getDisplayName() = tile.blockConduitBundle.name

 

So that's still not what I'm looking for.

 

Thanks

Link to comment
Share on other sites

Ok, that didn't seem to work. I couldn't find a getPickedBlock function but I found Item.getItemForBlock() which seems to be what I need. This gives as result:

 

            Item itemDropped = Item.getItemFromBlock(block);
            System.out.println("itemDropped.getUnlocalizedName() = " + itemDropped.getUnlocalizedName());
            System.out.println("new ItemStack(itemDropped).getDisplayName() = " + new ItemStack(itemDropped).getDisplayName());

 

This gives as output for an EnderIO item conduit:

 

itemDropped.getUnlocalizedName() = tile.blockConduitBundle
new ItemStack(itemDropped).getDisplayName() = tile.blockConduitBundle.name

 

So that's still not what I'm looking for.

 

Thanks

 

Block has a getPickBlock function. Item.getItemForBlock() returns the same thing as you have already been trying.

Link to comment
Share on other sites

I'm a bit confused about the parameters for this function though:

 

        block.getPickBlock(MovingPositionTarget target, World world, int x, int y, int z)

 

What exactly is MovingPositionTarget in this context?

That represents the block you centered your crosshairs on. It's like a vector from your eyes to the block. This function would not be helpful for enumerating all the block names, but it is great for what Waila does. You could examine the code and see how it works, as that may help.

Link to comment
Share on other sites

The base Block.getPickBlock() simply ignores the target and coordinate parameters and just calls Item.getItemFromBlock(block). I suspect that EnderIO conduit blocks will override this to provide the correct item instead. So that means I have to go with getPickBlock to ensure I have the correctly overridden method. I'll try to come up with good/working target,x,y,z parameters.

 

Thanks

Link to comment
Share on other sites

The base Block.getPickBlock() simply ignores the target and coordinate parameters and just calls Item.getItemFromBlock(block). I suspect that EnderIO conduit blocks will override this to provide the correct item instead. So that means I have to go with getPickBlock to ensure I have the correctly overridden method. I'll try to come up with good/working target,x,y,z parameters.

 

Thanks

Use mov.blockX, mov.blockY, and mov.blockZ.

Link to comment
Share on other sites

I still haven't been able to solve this problem. No matter what I do. But I do think that I'm going at this totally wrong now. The Block instance of which I'm trying to get the name is actually just a generic block from EnderIO which is meant to hold conduits (since you can combine multiple conduits in a single block with EnderIO). I'm getting this block using world.getBlock(x,y,z) so that's just a static block which has no knowledge about what conduits are actually inside it since that's not what a Block is supposed to hold. I suspect the actual data of what conduits are inside it is stored elsewhere. Perhaps NBT data or tile entity or so but I'm not certain where that would be and how to get the correct name from that then. Any ideas?

 

I actually have a similar problem with Thermal Expansion energy cells. The block that I get from world.getBlock() seems to be a generic energy cell for which the returned name is always 'Creative Energy Cell' even though it is not a creative energy cell. I again suspect the actual type of the energy cell is stored elsewhere.

 

This problem is now actually worsened because in the GUI of my mod I also try to render the block and this hits me with the same problems.

 

Thanks for all suggestions you can give me here.

 

Edit: I partially fixed the issue for the energy cell by using the world.getBlockMetadata() and give that to the itemstack before calling getDisplayName(). Now the name of the energy cell is correct but this didn't help for the EnderIO conduits.

Link to comment
Share on other sites

I still haven't been able to solve this problem. No matter what I do. But I do think that I'm going at this totally wrong now. The Block instance of which I'm trying to get the name is actually just a generic block from EnderIO which is meant to hold conduits (since you can combine multiple conduits in a single block with EnderIO). I'm getting this block using world.getBlock(x,y,z) so that's just a static block which has no knowledge about what conduits are actually inside it since that's not what a Block is supposed to hold. I suspect the actual data of what conduits are inside it is stored elsewhere. Perhaps NBT data or tile entity or so but I'm not certain where that would be and how to get the correct name from that then. Any ideas?

 

I actually have a similar problem with Thermal Expansion energy cells. The block that I get from world.getBlock() seems to be a generic energy cell for which the returned name is always 'Creative Energy Cell' even though it is not a creative energy cell. I again suspect the actual type of the energy cell is stored elsewhere.

 

This problem is now actually worsened because in the GUI of my mod I also try to render the block and this hits me with the same problems.

 

Thanks for all suggestions you can give me here.

 

Edit: I partially fixed the issue for the energy cell by using the world.getBlockMetadata() and give that to the itemstack before calling getDisplayName(). Now the name of the energy cell is correct but this didn't help for the EnderIO conduits.

Fetching the TileEntity will likely give you additional data, but that would require special casing every one.

Link to comment
Share on other sites

To figure out how to approach this, you need to find where the names you want are actually associated.  Look in the lang file to find the names you want to display.  Then it is simply a matter of getting there from your code. If the item has the name and you have a block then you'd find the item for the block, and so on.  If they're hardcoding it somewhere outside the lang file then find that and figure out how to get there.

 

Basically, for the names you want to display where are they currently in lang file or code?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

You may be able to do it for EnderIO conduits if you use tile entities' NBT, you'll have to do an if statement for every case but it might work. See EnderIO code to see how it stores it, or simply use an NBT explorer to see how EnderIO does the conduits in a world.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.