Jump to content

[Solved!][1.7.10] NBT not working


EmperorZelos

Recommended Posts

I am trying to store the orientation of a certain object, I have gotten it being able to store individual orientations and have them point in various directions but when I try to save it for next time it never happens, this is the code that I have used which works in other blocks I have (it currently does nothing), why does it not work?

 

package aerosteam.tileentitty;

import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;

public class TileEntitySteamPipe extends TileEntity {
public int orientation;

public TileEntitySteamPipe(){

}


public void readFromNBT(NBTTagCompound nbt){
	super.readFromNBT(nbt);
	this.orientation=(int)nbt.getShort("Orientation");
	int q=1/0;

}
public void writeToNBT(NBTTagCompound nbt){
	super.writeToNBT(nbt);
	int q=1/0;
	nbt.setShort("Orientation",(short)this.orientation);

}
}

Link to comment
Share on other sites

?

int q=1/0;

that should error every time (is it)

 

 

I also recommend putting  @Override  on the line before the overridden methods

 

I also believe you need to do one of these

 

extends BlockContainer

implements ITileEntityProvider

 

in your block class

Link to comment
Share on other sites

int q=1/0;

that should error every time (is it)

No, that is the issue, I place it there to see IF there is an error...it never happens.

 

I also recommend putting    @Override  on the line before the overridden methods

Where exacly?

 

Here is my code for the block class itself with the stuff, I still get nothing, even with the division by zero it never crashes telling me it doesn't even REACH those parts.

package aerosteam.devices;

import cpw.mods.fml.common.network.internal.FMLNetworkHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import aerosteam.AeroSteam;
import aerosteam.tileentitty.TileEntityBoiler;
import aerosteam.tileentitty.TileEntitySteamPipe;
import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.IChatComponent;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

public class DeviceSteamPipe extends BlockContainer implements ITileEntityProvider{

public DeviceSteamPipe(int connection) {
	super(Material.iron);
	this.setHardness(2.0F);
	this.setResistance(5.0F);
	this.setCreativeTab(AeroSteam.aeroTab);
}
public void onBlockAdded(World world, int x, int y, int z) {
	super.onBlockAdded(world, x, y, z);
	this.setDefaultOrientation(world, x, y, z);
}
public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase entityplayer,ItemStack itemstack){
	int l = MathHelper.floor_double((double)(entityplayer.rotationYaw * 4.0F/360.F)+0.5D) & 3 ;
	int t = MathHelper.floor_double((double)(entityplayer.rotationPitch * 4.0F/360.F)+0.5D) & 3;
	//
	TileEntitySteamPipe tile = (TileEntitySteamPipe) world.getTileEntity(x, y, z);
	if (t==0){
		if (l==1 || l==3){
			tile.orientation=1;
		}else if(l==0 || l==2){
			tile.orientation=3;
		}
	}else{
		tile.orientation=2;
	}
}
private void setDefaultOrientation(World world, int x, int y, int z){
	if(!world.isRemote){
	};
}
public boolean 	onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ){
	if (!world.isRemote){
		TileEntitySteamPipe tile = (TileEntitySteamPipe) world.getTileEntity(x, y, z);
		player.addChatMessage(new ChatComponentText("Metadata:" + tile.orientation));
	}
	return true;
}
public int getRenderType(){
	return -1;
}

public boolean isOpaqueCube(){
	return false;
}
public boolean renderAsNormalBlock(){
	return false;
}
@Override
public TileEntity createNewTileEntity(World p_149915_1_, int p_149915_2_) {
	return new TileEntitySteamPipe();
}

@SideOnly(Side.CLIENT)
public void registerBlockIcons(IIconRegister iconregister){
	this.blockIcon = iconregister.registerIcon(AeroSteam.MODID + ":" + "SteamPipeStraight");
}

}

Link to comment
Share on other sites

Hi

 

There are probably a couple of problems.

 

For example, you need to override

onDataPacket and getDescriptionPacket

for the TileEntity.

 

This example code for 1.6.4 shows you a working example.

https://github.com/mnn/jaffas/blob/59b59f01a1f2f6b21b0dc87e5a15e6761a3f3f19/src/minecraft/monnef/jaffas/food/block/TileEntityPie.java#L117

 

Should still work in 1.7 with some tweaking (i.e. Packet name change)

 

The @Override question - something like this

    @Override

    public void readFromNBT(NBTTagCompound tag) {

 

(Google @Override to see why it's important)

 

A better way to track your program flow, instead of q = 1/0, is to use eg

System.out.println("readFromNBT");

 

I'm not sure why your q=1/0 appears to show that this code isn't reached.  Perhaps your compiler is optimising it out, and that code actually is executed.  Try the System.out method instead and see if that's really the problem.

 

-TGG

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • no this one https://pastebin.com/5uMxHeWf
    • I am in such a mess. I have lost over 4.7m due to a scammer... It started as bank wires and then bitcoin. it is hard to imagine but it is true and can send any proof, then I tried to use a couple of recovery companies and was as well. Graphic design has been more than just a hobby for me since high school—it has become a thriving career. Starting in my parents' garage, I eventually expanded to my office, running a successful graphic design business. However, like many, I faced the need to diversify my investments due to inflation. This led me to invest 60.16 in Bitcoin, a decision that paid off handsomely as my investment grew to 4.7m over time. This financial windfall allowed me to upgrade my equipment and take on more ambitious projects, furthering the growth of my business. Unfortunately, my excitement was abruptly cut short when I fell victim to a hacking incident. Malware infected my computer, giving hackers access to my Bitcoin wallet. The devastation of potentially losing all my hard-earned savings and plans weighed heavily on me. At this dire moment, a fellow designer suggested Linux Cyber Security Company as a potential solution. Desperate for a lifeline, I reached out to them, hoping for a miracle. The response from Linux Cyber Security Company was prompt, incredibly professional, and effective. Their team quickly traced the hacker’s activities and recovered most of my funds, alleviating a significant amount of stress and uncertainty. Beyond the recovery, they took the time to educate me on essential practices to secure my Bitcoin holdings better. They emphasized using antivirus software to prevent malware infections, avoiding suspicious downloads, and the added security provided by hardware wallets. This experience served as a critical wake-up call for me. It highlighted the vulnerabilities inherent in digital assets and underscored the importance of robust security measures. Thanks to the guidance and expertise of Linux Cyber Security Company, I now feel more equipped to protect my digital assets proactively. Their insights have empowered me to implement stronger security protocols in my business operations and personal finances alike. With my Bitcoin funds securely recovered and a newfound understanding of digital security best practices, I am more confident in navigating future challenges. This journey has reinforced my commitment to safeguarding my hard-earned assets and leveraging technology responsibly. I am optimistic about the growth opportunities ahead, creatively in graphic design and prudently in investment strategies. In conclusion, while the hacking incident was a setback, it ultimately became a catalyst for enhancing my digital security awareness and resilience. I am grateful to Linux Cyber Security Company for their expertise and support during a challenging time, enabling me to continue pursuing my passion for graphic design with renewed confidence and financial stability. Contact a professional company I am sure they can help you with your case too, Website [www.linuxcybersecurity.com Email the team; info@)(linuxcybersecurity.com
    • https://pastebin.com/B2HnBZTa
    • it was easy villager mate, thanks ill see how to do it without that mod! thanks
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.