[1.7.10] (SOLVED) make the player jump to a set position

[sigurd4]

i have a set position stored in an item that i want to make the player jump towards. i took a look at the knockback function in EntityLivingBase and figured i could try that, but qith the oposite coordinates so that the player jumps towards it and not away from it. so i put this in a packet reciever thingy which is called by a clientside event handler with keys and such. but nothing happens. i have set breakpoints to test if the code is ran and they do in fact stop the game, so i really dont know. this is my code:

					int blockX = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(0);
					int blockY = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(1);
					int blockZ = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(2);
                        double d1 = -(blockX - player.posX);
                        double d0 = -(blockZ - player.posZ);
		            player.isAirBorne = true;
		            float f1 = MathHelper.sqrt_double(d1 * d1 + d0 * d0);
		            float f2 = 0.4F;
		            player.motionX /= 2.0D;
		            player.motionY /= 2.0D;
		            player.motionZ /= 2.0D;
		            player.motionX -= d1 / (double)f1 * (double)f2;
		            player.motionY += (double)f2;
		            player.motionZ -= d1 / (double)f1 * (double)f2;

		            if (player.motionY > 0.4000000059604645D)
		            {
		            	player.motionY = 0.4000000059604645D;
		            }

[knokko]

I think you can better use setInteger and getInteger instead of setTag and getTag.

And can you show the whole class code?

[sigurd4]

package com.sigurd4.Bioshock.items;

import java.util.List;

import com.sigurd4.Bioshock.BioshockMod;
import com.sigurd4.Bioshock.entity.projectiles.EntityBullet;
import com.sigurd4.Bioshock.entity.projectiles.targeter.EntityTargeter;
import com.sigurd4.Bioshock.entity.projectiles.targeter.EntityTargeterSkyHook;

import net.minecraft.block.Block;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagInt;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.IIcon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

public class ItemWeaponSkyHook extends ItemWeaponMelee
{
public boolean clickSounds;

public float damage;

public int timer;

private IIcon spinningTexture;

/**
 * Ride rails or use it as a brutal melee weapon!
 */
public ItemWeaponSkyHook(float damage, boolean clickSounds)
{
	super(damage, 0);
	this.weaponDamage = 0;
	this.damage = damage;
	this.timer = 0;
	this.clickSounds = clickSounds;
	this.setMaxStackSize(1);
	this.setCreativeTab(BioshockMod.tabBioshockModWeapons);
	this.setUnlocalizedName("weaponSkyHook");
	this.setTextureName("bioshock:sky_hook");
}

public void registerIcons(IIconRegister iconReg)
{
	this.itemIcon = iconReg.registerIcon(this.iconString);
	this.spinningTexture = iconReg.registerIcon(this.iconString+"_spinning");
}

public IIcon getIcon(ItemStack itemstack, int pass)
{
	if(itemstack.stackTagCompound.getInteger("Timer") > 0)
	{
		return this.spinningTexture;
	}
	else
	{
		return this.itemIcon;
	}
}

public void onUpdate(ItemStack itemstack, World world, Entity entity, int par4, boolean par5)
{
	if(itemstack.stackTagCompound == null)
	{
		itemstack.setTagCompound(new NBTTagCompound());
	}

	if(itemstack.stackTagCompound.getInteger("Timer") > -1)
	{
		this.weaponDamage = this.damage+itemstack.stackTagCompound.getInteger("Timer")/10;
	}
	else
	{
		this.weaponDamage = 0;
	}
	if(entity.motionY > 0)
	{
		this.weaponDamage = this.weaponDamage*((float)entity.motionY+2);
	}
	else
	{
		this.weaponDamage = this.weaponDamage*(-(float)entity.motionY+2);
	}
	if(entity.rotationPitch > 0)
	{
		this.weaponDamage = this.weaponDamage+entity.rotationPitch/60;
	}
	if(entity.fallDistance < 10)
	{
		this.weaponDamage = this.weaponDamage+entity.fallDistance/2;
	}
	else
	{
		this.weaponDamage = this.weaponDamage+10;
	}
	if(entity instanceof EntityPlayer)
	{
		if(((EntityPlayer)entity).isSprinting())
		{
			++this.weaponDamage;
		}
	}
	if(itemstack.stackTagCompound.getInteger("Timer") > -1)
	{
		this.weaponDamage = this.weaponDamage-6.47F;
	}
	else
	{
		this.weaponDamage = this.weaponDamage/2;
	}

	if(entity instanceof EntityLivingBase)
	{
		if(((EntityLivingBase)entity).getHeldItem() == itemstack)
		{
			EntityTargeterSkyHook targeter = new EntityTargeterSkyHook(world, (EntityPlayer)entity);
			targeter.isFirst = (itemstack.stackTagCompound.getInteger("CanHook") <= 0);
			world.spawnEntityInWorld(targeter);
			if(!itemstack.stackTagCompound.hasKey("CanHook"))
			{
				itemstack.stackTagCompound.setInteger("CanHook", 0);
			}
			if(itemstack.stackTagCompound.getInteger("CanHook") <= 0)
			{
				itemstack.stackTagCompound.removeTag("HookCoords");
			}
			if(itemstack.stackTagCompound.getInteger("CanHook") > -1)
			{
				itemstack.stackTagCompound.setInteger("CanHook", itemstack.stackTagCompound.getInteger("CanHook")-1);
			}
			if(itemstack.stackTagCompound.getInteger("Timer") == 1)
			{
				entity.playSound("bioshock:item.weapon.skyhook.motor.end", 1.0F+(this.clickSounds ? 0.4F : 0), 1.0F);
			}
			if(itemstack.stackTagCompound.getInteger("Timer") == 
			{
				entity.playSound("bioshock:item.weapon.skyhook.motor", 1.0F+(this.clickSounds ? 0.2F : 0), 1.0F);
			}
			if(itemstack.stackTagCompound.getInteger("Timer") > -2)
			{
				itemstack.stackTagCompound.setInteger("Timer", itemstack.stackTagCompound.getInteger("Timer")-1);
			}
			if(this.clickSounds && (itemstack.stackTagCompound.getInteger("Timer") == 3 || itemstack.stackTagCompound.getInteger("Timer") == 6))
			{
				entity.playSound("random.click", 0.02F+this.itemRand.nextFloat()*0.1F, 0.9F+this.itemRand.nextFloat()*1.8F);
			}
			if(itemstack.stackTagCompound.getInteger("CanHook") >= 100)
			{
				this.jumpToHook(itemstack, (EntityLivingBase)entity);
				itemstack.stackTagCompound.setInteger("CanHook", -2);
			}
		}
		else
		{
			if(itemstack.stackTagCompound.getInteger("Timer") > 0)
			{
				entity.playSound("bioshock:item.weapon.skyhook.motor.end", 1.0F+(this.clickSounds ? 0.4F : 0), 1.0F);
			}
			itemstack.stackTagCompound.setInteger("Timer", 0);
		}
	}
}

public void onCreated(ItemStack itemstack, World world, EntityPlayer player)
{
	if(itemstack.stackTagCompound == null)
	{
		itemstack.setTagCompound(new NBTTagCompound());
	}
	if(!itemstack.stackTagCompound.hasKey("Timer"))
	{
		itemstack.stackTagCompound.setInteger("Timer", timer);
	}
}

@SuppressWarnings("rawtypes")
public void addInformation(ItemStack itemstack, EntityPlayer player, List list, boolean bool)
{
	if(itemstack.stackTagCompound == null)
	{
		itemstack.setTagCompound(new NBTTagCompound());
	}
	if(!itemstack.stackTagCompound.hasKey("Timer"))
	{
		itemstack.stackTagCompound.setInteger("Timer", timer);
	}
}

public ItemStack onItemRightClick(ItemStack itemstack, World world, EntityPlayer player)
{
	if(itemstack.stackTagCompound.getInteger("Timer") <= 2)
	{
		itemstack.stackTagCompound.setInteger("Timer", 9);
		if(itemstack.stackTagCompound.getInteger("Timer") <= 0)
		{
			player.playSound("bioshock:item.weapon.skyhook.motor.start", 1.0F+(this.clickSounds ? 0.2F : 0), 1.0F);
		}
		else if(this.clickSounds)
		{
			player.playSound("random.click", 0.02F+this.itemRand.nextFloat()*0.1F, 0.9F+this.itemRand.nextFloat()*1.8F);
		}
	}
	return itemstack;
}


@Override
public boolean hitEntity(ItemStack itemstack, EntityLivingBase target, EntityLivingBase user)
{
	if(target instanceof EntityLivingBase)
	{
		if(((EntityLivingBase)target).getMaxHealth() > 10)
		{
			itemstack.stackTagCompound.setInteger("Timer", 0);
		}
		if(((EntityLivingBase)target).getHealth() < 15 && !(target instanceof EntityPlayer))
		{
			((EntityLivingBase)target).addPotionEffect(new PotionEffect(Potion.weakness.id, 20, 1, true));
		}
	}
	return super.hitEntity(itemstack, target, user);
}

/**
 * Metadata-sensitive version of getStrVsBlock
 * @param itemstack The Item Stack
 * @param block The block the item is trying to break
 * @param metadata The items current metadata
 * @return The damage strength
 */
public float getDigSpeed(ItemStack itemstack, Block block, int metadata)
{
	if(itemstack.stackTagCompound.getInteger("Timer") > 0)
	{
		return 0.001F;
	}
	else
	{
		return func_150893_a(itemstack, block);
	}
}

/**
 * Callback for item usage. If the item does something special on right clicking, he will have one of those. Return
 * True if something happen and false if it don't. This is for ITEMS, not BLOCKS
 */
public boolean onItemUse(ItemStack itemstack, EntityPlayer plaer, World world, int x, int y, int z, int side, float p_77648_8_, float p_77648_9_, float p_77648_10_)
{
	return false;
}

public void jumpToHook(ItemStack itemstack, EntityLivingBase entity)
{
	if(entity.getHeldItem() == itemstack)
	{
		if(itemstack.stackTagCompound != null && itemstack.stackTagCompound.getInteger("CanHook") > 0 && itemstack.stackTagCompound.hasKey("HookCoords") && ((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).tagCount() >= 3 && itemstack.stackTagCompound.getInteger("Timer") > 0)
		{
			int blockX = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(0);
			int blockY = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(1);
			int blockZ = (int)((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).func_150309_d(2);
			double d1 = blockX - entity.posX;
			double d0 = blockZ - entity.posZ;
			entity.isAirBorne = true;
			float f1 = MathHelper.sqrt_double(d1 * d1 + d0 * d0);
			float f2 = 0.4F;
			entity.motionX /= 2.0D;
			entity.motionY /= 2.0D;
			entity.motionZ /= 2.0D;
			entity.motionX -= d1 / (double)f1 * (double)f2;
			entity.motionY += (double)f2;
			entity.motionZ -= d1 / (double)f1 * (double)f2;

			if (entity.motionY > 0.4000000059604645D)
			{
				entity.motionY = 0.4000000059604645D;
			}
		}
	}
}
}

this is the code in my key bind packet receiver thingy:

		else if(i == 4)
		{
			if(player.getEquipmentInSlot(1) != null) if(player.getEquipmentInSlot(1).getItem() instanceof ItemArmorDivingSuit)
			{
				if (player.isInWater())
				{
					player.setJumping(true);
					player.jump();
				}
			}
			if(player.getHeldItem().getItem() instanceof ItemWeaponSkyHook)
			{
				ItemStack itemstack = player.getHeldItem();
				if(itemstack.stackTagCompound != null && itemstack.stackTagCompound.getInteger("CanHook") > 0 && itemstack.stackTagCompound.hasKey("HookCoords") && ((NBTTagList)itemstack.stackTagCompound.getTag("HookCoords")).tagCount() >= 3 && itemstack.stackTagCompound.getInteger("Timer") > 0)
				{
					itemstack.stackTagCompound.setInteger("CanHook", 1000);
				}
			}
		}

and this is the code in the EntityTargeterSkyHook class:

package com.sigurd4.Bioshock.entity.projectiles.targeter;

import com.sigurd4.Bioshock.items.ItemWeaponSkyHook;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.audio.ISound;
import net.minecraft.client.audio.PositionedSoundRecord;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.init.Blocks;
import net.minecraft.nbt.NBTTagInt;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;

public class EntityTargeterSkyHook extends EntityTargeter
{
public float scale = 0.0F;
public boolean isFirst = false;
protected final ISound sound = PositionedSoundRecord.func_147673_a(new ResourceLocation("bioshock:item.weapon.skyhook.target"));

public EntityTargeterSkyHook(World par1World)
{
	super(par1World);
	this.setSize(scale, scale);
}

public EntityTargeterSkyHook(World par1World, EntityLivingBase par2EntityLivingBase)
{
	super(par1World, par2EntityLivingBase);
	this.setSize(scale, scale);
}

public EntityTargeterSkyHook(World par1World, double par2, double par4, double par6)
{
	super(par1World, par2, par4, par6);
	this.setSize(scale, scale);
}

protected void onImpact(MovingObjectPosition pos)
{
	if(this.getThrower() != null)
	{
		Block block = this.worldObj.getBlock(pos.blockX, pos.blockY, pos.blockZ);
		if(block.getBlockHardness(this.worldObj, pos.blockX, pos.blockY, pos.blockZ) > 0)
		{
			if(this.getThrower().getHeldItem() != null && this.checkIfBlockValid(pos.blockX, pos.blockY, pos.blockZ, block, this.worldObj))
			{
				if(this.getThrower().getHeldItem().getItem() instanceof ItemWeaponSkyHook)
				{
					NBTTagList oldHookCoords = (NBTTagList)this.getThrower().getHeldItem().getTagCompound().getTag("HookCoords");
					this.getThrower().getHeldItem().stackTagCompound.removeTag("HookCoords");
					NBTTagList hookCoords = new NBTTagList();
					hookCoords.appendTag(new NBTTagInt(pos.blockX));
					hookCoords.appendTag(new NBTTagInt(pos.blockY));
					hookCoords.appendTag(new NBTTagInt(pos.blockZ));
					if(oldHookCoords == null || (this.isFirst && oldHookCoords.func_150303_d() == 3))
					{
						if(oldHookCoords == null || (this.getThrower().getHeldItem().getTagCompound().getInteger("CanHook") <= 0 && (oldHookCoords.func_150309_d(0) != pos.blockX || oldHookCoords.func_150309_d(1) != pos.blockY || oldHookCoords.func_150309_d(2) != pos.blockZ) && Minecraft.getMinecraft().getSoundHandler().isSoundPlaying(sound)))
						{
							Minecraft.getMinecraft().getSoundHandler().stopSound(sound);
							Minecraft.getMinecraft().getSoundHandler().playSound(sound);
						}
					}
					this.getThrower().getHeldItem().stackTagCompound.setTag("HookCoords", hookCoords);
					this.getThrower().getHeldItem().getTagCompound().setInteger("CanHook", 4);
				}
			}
			this.setDead();
		}
	}
	else
	{
		this.setDead();
	}
}

protected boolean checkIfBlockValid(int x, int y, int z, Block block, World world)
{
	//vanilla iron bars
	if(Block.getIdFromBlock(block) == Block.getIdFromBlock(Blocks.iron_bars))
	{
		if(world.isAirBlock(x+1, y, z) && world.isAirBlock(x-1, y, z))
		{
			if(world.isAirBlock(x, y, z+1) && world.isAirBlock(x, y, z-1))
			{
				if(world.isAirBlock(x, y-1, z) && world.isAirBlock(x, y-2, z) && !world.isAirBlock(x, y+1, z))
				{
					return true;
				}
			}
		}
	}
	return false;
}
}

it worked after restarting the game (i had just been running it in debug mode previosuly, though it seems adding new code doesn't always work without restarting the game). it does however not push the player in the right direction. it allways pushes them towards noth-west. any clue on how to fix that? also, about the data tags, the tag my data tag is located in is a list. there doesn't seem to be any getInteger() function for lists, only compounds.

[sequituri]

Integer is NBT tag type 3.

 

Unfortunately, there is no method getIntTagAt(pos) in NBTTagList. However...

 

You can use "int n = (NBTTagInt)(nbtTagList1.removeTag( 0));" to get and remove the first int tag from the list. (repeat until nbtTagList1.tagCount() == 0)

 

You can add ints with "nbtTagList1.func_150304_a(pos++, new NBTTagInt( number));"

 

 

[sigurd4]

i did as you said and changed the code slightly. now the throw strength depends on how far away the player is from the position and seems to be fairly accurate, however it only throws the player towards south-west, and not towards the coordinates. i really dont get it. what would be the correct formula to set the velocity the player needs in order to hit a specific goal?

 

code:

			NBTBase tag2 = hookCoords.removeTag(2);
			NBTBase tag1 = hookCoords.removeTag(1);
			NBTBase tag0 = hookCoords.removeTag(0);
			for(int i = hookCoords.tagCount(); i > 0; --i)
			{
				hookCoords.removeTag(i-1);
			}
			int blockX = (int)Math.floor(entity.posX);
			int blockY = (int)Math.floor(entity.posY);
			int blockZ = (int)Math.floor(entity.posZ);
			if(tag0 instanceof NBTTagInt)
			{
				blockX = ((NBTTagInt)tag0).func_150287_d();
			}
			if(tag1 instanceof NBTTagInt)
			{
				blockY = ((NBTTagInt)tag1).func_150287_d();
			}
			if(tag2 instanceof NBTTagInt)
			{
				blockZ = ((NBTTagInt)tag2).func_150287_d();
			}
			hookCoords.appendTag(new NBTTagInt(blockX));
			hookCoords.appendTag(new NBTTagInt(blockY));
			hookCoords.appendTag(new NBTTagInt(blockZ));
			double d0 = blockX-(blockX - entity.posX);
			double d1 = blockZ-(blockY - entity.posY);
			double d2 = blockZ-(blockZ - entity.posZ);
			entity.isAirBorne = true;
			float f1 = MathHelper.sqrt_double(d0 * d0 + d2 * d2 + d1 * d1);
			float f2 = (float)entity.getDistance((double)blockX+0.5D, (double)blockY+0.5D, (double)blockZ+0.5D)*0.1F;
			entity.motionX /= 2.0D;
			entity.motionY /= 2.0D;
			entity.motionZ /= 2.0D;
			entity.motionX += d0 / (double)f1 * (double)f2;
			entity.motionY += d1 / (double)f1 * (double)f2;
			entity.motionZ += d2 / (double)f1 * (double)f2;

[sequituri]

These here don't make any sense.

    double d0 = blockX-(blockX - entity.posX);
    double d1 = blockZ-(blockY - entity.posY);
    double d2 = blockZ-(blockZ - entity.posZ);

blockX - (blockX - posX) ... is the same as

blockX - blockX + posX ... is same as

posX

 

So, as it is written it will always compute distance from (0,0,0) to the entity. Not very useful.