Jump to content

[1.7.x] Replace part of multiblock of with new block


Recommended Posts

Posted

I got a kind of weird issue. The mod has a blocked called "chisel:sandstone" with metadata blocks 1-15. A patch of mine removes the blocks with metadata 1 and 2.

On loading an old savegame, I would like to replace "chisel:chisel.tile.sandstone:1" (block "chisel.tile.sandstone", metadata 1) with "minecraft:sandstone:1" ("Smooth Sandstone"). But I also want to keep the "chisel:chisel.tile.sandstone" metadata blocks 3-15.

 

How would I do that? I tried "GameDataManipulator.replaceItem(arg0, arg1);" without success and I don't really have a clue on how to achieve that.

 

In case someone needs the code: https://github.com/Pokefenn/Chisel/blob/master/src/main/java/info/jbcs/minecraft/chisel/ChiselBlocks.java

Posted

Is it possible to add a new block and map it to the old block metadata 3-15 while mapping the old block metadata 1,2 to another one?

Posted

If neither are possible, is it possible to see if a savegame contains an older version of the mod? Additionally, is it possible to execute a "search & replace" in the world file afterwards?

Posted

That doesn't sound like a good option for a mod.

 

Is it at least possible to check if this block already exists in the savegame? I could add the deprecated metadata 1,2 if an old savegame is loaded and don't initialise them if the mod wasn't present on this save before (on a new world).

Posted
  On 9/12/2014 at 7:21 PM, diesieben07 said:

Parsing the level.dat would give you that information. I don't think there's anything wrong with that.

 

If I understand aright, you don't think there is anything wrong with a manual search&replace.

How would I achieve that? I guess I have to catch the "FMLServerAboutToStartEvent", find the world file, search all chunks for appearances of the block + search all inventories for appearances of its item and replace all of them? What are the methods I can use to load the world, get my mod info and replace items?

 

Something along the way

@EventHandler
public void preServerStart(FMLServerAboutToStartEvent event) {
	for(int i = 0; i<event.getServer().worldServers.length; i++) {
		for(x) {
			for(y) {
				for(z) {
					block = event.getServer().worldServers[1].getBlock(x, y, z);
					if( block == badblock)
						event.getServer().worldServers[1].setBlock(x, y, z, goodblock);
				}
			}
		}
	}
}

Posted

If I shouldn't use worlds, how can I achieve that?

By more low level, do you mean that I should not compare the block object but just it's ID and metadata?

Posted

If I get this right, then this will be execute every single time a chunk is loaded.

I only want to remove the block from savegames which have version "<= 1.5.6" and don't care about it in later versions of the mod. As far as I understand, I would put unnecessary load on the server if I catch and work with the ChunkLoadEvent.

 

I tried to mess around with FMLServerStartingEvent, but I can only find loaded tiles and not every tile. I am pretty new to modding, so I would appreciate some more concrete pointers :)

Posted

Yeah, it seemed quite ugly to me too.

I decided the whole idea is much too much hassle for a non-critical bug.

 

In which event would I try to figure out the version of my mod in the savegame? I could then add give those metadata blocks a texture and add a compatbility recipe to convert them to the proper blocks.

I guess I can also put a flag in the savegame such that I can load those textures/compatibility recipes again during the next loading. How would I do that?

Posted
  On 9/13/2014 at 7:27 PM, diesieben07 said:

The easiest way would be to add a flag to all new chunks *now* and whenever you encounter a chunk without that flag you know that that chunk is still on the old version.

 

What's so bad on doing it during loading a savegame? It does feel pretty wrong to add a recipe when loading a chunk.

Is there really no way to put a flag independent on chunks?

Posted

 

  On 9/13/2014 at 8:21 PM, diesieben07 said:

Well, if it's for a recipe, you can put the marker on the whole world.

 

Like I asked before. "How?"

Also: "In which event would I try to figure out the version of my mod in the savegame?"

 

  Quote

In which event would I try to figure out the version of my mod in the savegame?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.