Jump to content

[1.7.x] Replace part of multiblock of with new block


EoD

Recommended Posts

I got a kind of weird issue. The mod has a blocked called "chisel:sandstone" with metadata blocks 1-15. A patch of mine removes the blocks with metadata 1 and 2.

On loading an old savegame, I would like to replace "chisel:chisel.tile.sandstone:1" (block "chisel.tile.sandstone", metadata 1) with "minecraft:sandstone:1" ("Smooth Sandstone"). But I also want to keep the "chisel:chisel.tile.sandstone" metadata blocks 3-15.

 

How would I do that? I tried "GameDataManipulator.replaceItem(arg0, arg1);" without success and I don't really have a clue on how to achieve that.

 

In case someone needs the code: https://github.com/Pokefenn/Chisel/blob/master/src/main/java/info/jbcs/minecraft/chisel/ChiselBlocks.java

Link to comment
Share on other sites

That doesn't sound like a good option for a mod.

 

Is it at least possible to check if this block already exists in the savegame? I could add the deprecated metadata 1,2 if an old savegame is loaded and don't initialise them if the mod wasn't present on this save before (on a new world).

Link to comment
Share on other sites

Parsing the level.dat would give you that information. I don't think there's anything wrong with that.

 

If I understand aright, you don't think there is anything wrong with a manual search&replace.

How would I achieve that? I guess I have to catch the "FMLServerAboutToStartEvent", find the world file, search all chunks for appearances of the block + search all inventories for appearances of its item and replace all of them? What are the methods I can use to load the world, get my mod info and replace items?

 

Something along the way

@EventHandler
public void preServerStart(FMLServerAboutToStartEvent event) {
	for(int i = 0; i<event.getServer().worldServers.length; i++) {
		for(x) {
			for(y) {
				for(z) {
					block = event.getServer().worldServers[1].getBlock(x, y, z);
					if( block == badblock)
						event.getServer().worldServers[1].setBlock(x, y, z, goodblock);
				}
			}
		}
	}
}

Link to comment
Share on other sites

If I get this right, then this will be execute every single time a chunk is loaded.

I only want to remove the block from savegames which have version "<= 1.5.6" and don't care about it in later versions of the mod. As far as I understand, I would put unnecessary load on the server if I catch and work with the ChunkLoadEvent.

 

I tried to mess around with FMLServerStartingEvent, but I can only find loaded tiles and not every tile. I am pretty new to modding, so I would appreciate some more concrete pointers :)

Link to comment
Share on other sites

Yeah, it seemed quite ugly to me too.

I decided the whole idea is much too much hassle for a non-critical bug.

 

In which event would I try to figure out the version of my mod in the savegame? I could then add give those metadata blocks a texture and add a compatbility recipe to convert them to the proper blocks.

I guess I can also put a flag in the savegame such that I can load those textures/compatibility recipes again during the next loading. How would I do that?

Link to comment
Share on other sites

The easiest way would be to add a flag to all new chunks *now* and whenever you encounter a chunk without that flag you know that that chunk is still on the old version.

 

What's so bad on doing it during loading a savegame? It does feel pretty wrong to add a recipe when loading a chunk.

Is there really no way to put a flag independent on chunks?

Link to comment
Share on other sites

 

Well, if it's for a recipe, you can put the marker on the whole world.

 

Like I asked before. "How?"

Also: "In which event would I try to figure out the version of my mod in the savegame?"

 

In which event would I try to figure out the version of my mod in the savegame?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have done this now but have got the error:   'food(net.minecraft.world.food.FoodProperties)' in 'net.minecraft.world.item.Item.Properties' cannot be applied to                '(net.minecraftforge.registries.RegistryObject<net.minecraft.world.item.Item>)' public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register( "lemon_juice", () -> new Item( new HoneyBottleItem.Properties().stacksTo(1).food( (new FoodProperties.Builder()) .nutrition(3) .saturationMod(0.25F) .effect(() -> new MobEffectInstance(MobEffects.DAMAGE_RESISTANCE, 1500), 0.01f ) .build() ) )); The code above is from the ModFoods class, the one below from the ModItems class. public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register("lemon_juice", () -> new Item(new Item.Properties().food(ModFoods.LEMON_JUICE)));   I shall keep going between them to try and figure out the cause. I am sorry if this is too much for you to help with, though I thank you greatly for your patience and all the effort you have put in to help me.
    • I have been following these exact tutorials for quite a while, I must agree that they are amazing and easy to follow. I have registered the item in the ModFoods class, I tried to do it in ModItems (Where all the items should be registered) but got errors, I think I may need to revert this and figure it out from there. Once again, thank you for your help! 👍 Just looking back, I have noticed in your code you added ITEMS.register, which I am guessing means that they are being registered in ModFoods, I shall go through the process of trial and error to figure this out.
    • ♈+2349027025197ஜ Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join a brotherhood for protection and wealth here’s is your opportunity, but you should know there’s no ritual without repercussions but with the right guidance and support from this great temple your destiny is certain to be changed for the better and equally protected depending if you’re destined for greatness Call now for enquiry +2349027025197☎+2349027025197₩™ I want to join ILLUMINATI occult without human sacrificeGREATORLDRADO BROTHERHOOD OCCULT , Is The Club of the Riches and Famous; is the world oldest and largest fraternity made up of 3 Millions Members. We are one Family under one father who is the Supreme Being. In Greatorldrado BROTHERHOOD we believe that we were born in paradise and no member should struggle in this world. Hence all our new members are given Money Rewards once they join in order to upgrade their lifestyle.; interested viewers should contact us; on. +2349027025197 ۝ஐℰ+2349027025197 ₩Greatorldrado BROTHERHOOD OCCULT IS A SACRED FRATERNITY WITH A GRAND LODGE TEMPLE SITUATED IN G.R.A PHASE 1 PORT HARCOURT NIGERIA, OUR NUMBER ONE OBLIGATION IS TO MAKE EVERY INITIATE MEMBER HERE RICH AND FAMOUS IN OTHER RISE THE POWERS OF GUARDIANS OF AGE+. +2349027025197   SEARCHING ON HOW TO JOIN THE Greatorldrado BROTHERHOOD MONEY RITUAL OCCULT IS NOT THE PROBLEM BUT MAKE SURE YOU'VE THOUGHT ABOUT IT VERY WELL BEFORE REACHING US HERE BECAUSE NOT EVERYONE HAS THE HEART TO DO WHAT IT TAKES TO BECOME ONE OF US HERE, BUT IF YOU THINK YOU'RE SERIOUS MINDED AND READY TO RUN THE SPIRITUAL RACE OF LIFE IN OTHER TO ACQUIRE ALL YOU NEED HERE ON EARTH CONTACT SPIRITUAL GRANDMASTER NOW FOR INQUIRY +2349027025197   +2349027025197 Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join
    • Hi, I'm trying to use datagen to create json files in my own mod. This is my ModRecipeProvider class. public class ModRecipeProvider extends RecipeProvider implements IConditionBuilder { public ModRecipeProvider(PackOutput pOutput) { super(pOutput); } @Override protected void buildRecipes(Consumer<FinishedRecipe> pWriter) { ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', ModItems.COMPRESSED_DIAMOND.get()) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); ShapelessRecipeBuilder.shapeless(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get(),9) .requires(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .unlockedBy(getHasName(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()), has(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get())) .save(pWriter); ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', Blocks.DIAMOND_BLOCK) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); } } When I try to run the runData client, it shows an error:  Caused by: java.lang.IllegalStateException: Duplicate recipe compressed:compressed_diamond I know that it's caused by the fact that there are two recipes for the ModItems.COMPRESSED_DIAMOND. But I need both of these recipes, because I need a way to craft ModItems.COMPRESSED_DIAMOND_BLOCK and restore 9 diamond blocks from ModItems.COMPRESSED_DIAMOND. Is there a way to solve this?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.