Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

hello guys,

 

I have made a noob version of a GUI, but the tileEntity is not saving the data.

 

Here is the tileentity code:

public class TileEntityMetalEnchanter extends TileEntity{
public MetalEnchanter enchanter;
public Item powder;
public int amountPowder;
public int amountIron;
public int ticksExisted;

public void updateEntity(){
	if(enchanter == null && worldObj.getBlock(xCoord, yCoord, zCoord) == EnderpowerBlocks.metalenchanter){
		enchanter = (MetalEnchanter) worldObj.getBlock(xCoord, yCoord, zCoord);
	}
	if(enchanter != null && !worldObj.isRemote){
		if(enchanter.input_powder != null){
			if(enchanter.input_powder.stackSize < 1){
				enchanter.input_powder = null;
			}
		}
		if(enchanter.input_iron != null && amountIron > 0){
			if(enchanter.input_iron.stackSize == 0 && ticksExisted <= 5){
				enchanter.input_iron.stackSize = amountIron;
			}
		}
		if(enchanter.input_iron != null){
			if(enchanter.input_iron.stackSize > 0 || ticksExisted >= 5){
				amountIron = enchanter.input_iron.stackSize;
			}
		}
		if(enchanter.input_powder == null && amountPowder > 0 && ticksExisted < 5 && powder != null){
			enchanter.input_powder = new ItemStack(powder, amountPowder);
		}
		System.out.println("amountIron = " + amountIron);
		System.out.println(powder);
		System.out.println(amountPowder);
	}
	++ticksExisted;
}
public void writeToNBT(NBTTagCompound nbt){
	super.writeToNBT(nbt);
	if(enchanter != null){
		if(enchanter.input_iron != null){
			if(enchanter.input_iron.stackSize > 0){
				nbt.setInteger("amountIron", enchanter.input_iron.stackSize);
			}
		}
		if(enchanter.input_powder != null){
			nbt.setInteger("amountPowder", enchanter.input_powder.stackSize);
			nbt.setInteger("itemPowder", Item.getIdFromItem(enchanter.input_powder.getItem()));
		}
	}
}
public void readFromNBT(NBTTagCompound nbt){
	super.readFromNBT(nbt);
	amountIron = nbt.getInteger("amountIron");
	if(nbt.getInteger("itemPowder") != 0){
		powder = Item.getItemById(nbt.getInteger("itemPowder"));
		amountPowder = nbt.getInteger("amountPowder");
	}
}
}

 

Here is the block code:

public class MetalEnchanter extends BlockContainer{
@SideOnly(Side.CLIENT)
    public IIcon top;
    @SideOnly(Side.CLIENT)
    public IIcon bottom;
    
    public ItemStack input_iron = new ItemStack(Items.iron_ingot, 0);
    public ItemStack input_powder;
    public ItemStack output;
    
public MetalEnchanter() {
	super(Material.rock);
	setHardness(5);
	setResistance(10);
}
@Override
public TileEntity createNewTileEntity(World world, int i) {
	return new TileEntityMetalEnchanter();
}
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int metadata)
    {
	if(side == 0){
		return bottom;
	}
	if(side == 1){
		return top;
	}
	else {
		return blockIcon;
	}
    }

    @SideOnly(Side.CLIENT)
    public void registerBlockIcons(IIconRegister icon)
    {
        this.blockIcon = icon.registerIcon(R.T + "metalenchanter_side");
        this.bottom = icon.registerIcon(R.T + "metalenchanter_bottom");
        this.top = icon.registerIcon(R.T + "metalenchanter_top");
    }
    public boolean onBlockActivated(World world, int x, int y,int z, EntityPlayer player, int side, float f1, float f2, float f3){
    	if(player.getCurrentEquippedItem() != null && !world.isRemote){
    		if(player.getCurrentEquippedItem().getItem() == Items.iron_ingot && input_iron.stackSize < 64){
    			player.getCurrentEquippedItem().stackSize -= 1;
    			input_iron.stackSize += 1;
    		}
    		if(input_powder != null){
    			if(input_powder.stackSize < 64){
    				if(player.getCurrentEquippedItem().getItem() == input_powder.getItem()){
    					player.getCurrentEquippedItem().stackSize -= 1;
    					input_powder.stackSize += 1;
    				}
    			}
    		}
    		else if(input_powder == null){
    			System.out.println("input_powder = null.");
    			if(isValidItem(player)){
    				input_powder = new ItemStack(player.getCurrentEquippedItem().getItem(), 1);
    				player.getCurrentEquippedItem().stackSize -= 1;
    			}
    		}
    	}
    	if(!world.isRemote){
    		System.out.println(input_iron);
    	}
	return true;
    }
    public void onBlockClicked(World world, int x, int y, int z, EntityPlayer player){
    	if(player.getCurrentEquippedItem() != null && !world.isRemote){
    		if(input_iron.stackSize > 0 && player.getCurrentEquippedItem().getItem() == Items.iron_ingot){
    			player.inventory.addItemStackToInventory(new ItemStack(Items.iron_ingot));
    			input_iron.stackSize -= 1;
    		}
    		if(input_powder != null){
    			if(input_powder.getItem() == player.getCurrentEquippedItem().getItem() && input_powder.stackSize > 0 && player.getCurrentEquippedItem().stackSize < 64){
    				input_powder.stackSize -= 1;
    				player.getCurrentEquippedItem().stackSize += 1;
    			}
    		}
    	}
    	else if(player.getCurrentEquippedItem() == null && !world.isRemote){
    		if(input_iron.stackSize > 0){
    			player.inventory.addItemStackToInventory(new ItemStack(Items.iron_ingot, input_iron.stackSize));
    			input_iron.stackSize = 0;
    		}
    		if(input_powder != null){
    			player.inventory.addItemStackToInventory(input_powder);
    			input_powder = null;
    		}
    	}
    }
    public void breakBlock(World world, int x, int y, int z, Block block, int metadata)
    {
    	if(input_iron.stackSize > 0){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, input_iron));
    	}
    	if(input_powder != null){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, input_powder));
    	}
    	if(output != null){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, output));
    	}
        super.breakBlock(world, x, y, z, block, metadata);
    }
    public boolean isValidItem(EntityPlayer player){
    	if(player.getCurrentEquippedItem().getItem() == EnderpowerItems.cursedpowder || player.getCurrentEquippedItem().getItem() == EnderpowerItems.poison || player.getCurrentEquippedItem().getItem() == EnderpowerItems.witherpowder){
    		return true;
    	}
    	else {
    		return false;
    	}
    }
}

Save all things in the TileEntity, nothing in the Block.

And if you want save more Stacks in there make a Container.

  • Author

first:

 

I don't think you have readed the code good because everything is allready saved in the tileentity.

I didn't even find one for the block.

 

second:

What is the use of a container?

And It doesn't even seems it saves integers.

public class MetalEnchanter extends BlockContainer{

@SideOnly(Side.CLIENT)

    public IIcon top;

    @SideOnly(Side.CLIENT)

    public IIcon bottom;

   

    public ItemStack input_iron = new ItemStack(Items.iron_ingot, 0);

    public ItemStack input_powder;

    public ItemStack output;

 

You save there three ItemStacks.

And I think it would be easier to handle with the ItemStacks as with the Integer of the ItemStacks

  • Author

Ooohhhh....

 

I thought you meant that writeNoNBT was in the block class.

I will try what you are saying.

  • Author

I have rewritten it a little bit.

The ItemStacks are now saved on the tileentity.

But I have found another problem.

 

I have let the block and the tile entity print the value of the ironstack.

The tileEntity always says the stacksize = 0!

Does anybody know why?

 

Here is the new block class:

public class MetalEnchanter extends BlockContainer{
@SideOnly(Side.CLIENT)
    public IIcon top;
    @SideOnly(Side.CLIENT)
    public IIcon bottom;
    
    public TileEntityMetalEnchanter tileEntity;
    
public MetalEnchanter() {
	super(Material.rock);
	setHardness(5);
	setResistance(10);
}
@Override
public TileEntity createNewTileEntity(World world, int i) {
	tileEntity = new TileEntityMetalEnchanter();
	return tileEntity;
}
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int metadata)
    {
	if(side == 0){
		return bottom;
	}
	if(side == 1){
		return top;
	}
	else {
		return blockIcon;
	}
    }

    @SideOnly(Side.CLIENT)
    public void registerBlockIcons(IIconRegister icon)
    {
        this.blockIcon = icon.registerIcon(R.T + "metalenchanter_side");
        this.bottom = icon.registerIcon(R.T + "metalenchanter_bottom");
        this.top = icon.registerIcon(R.T + "metalenchanter_top");
    }
    public boolean onBlockActivated(World world, int x, int y,int z, EntityPlayer player, int side, float f1, float f2, float f3){
    	if(player.getCurrentEquippedItem() != null && !world.isRemote){
    		if(player.getCurrentEquippedItem().getItem() == Items.iron_ingot && tileEntity.input_iron.stackSize < 64){
    			player.getCurrentEquippedItem().stackSize -= 1;
    			tileEntity.input_iron.stackSize += 1;
    		}
    		if(tileEntity.input_powder != null){
    			if(tileEntity.input_powder.stackSize < 64){
    				if(player.getCurrentEquippedItem().getItem() == tileEntity.input_powder.getItem()){
    					player.getCurrentEquippedItem().stackSize -= 1;
    					tileEntity.input_powder.stackSize += 1;
    				}
    			}
    		}
    		else if(tileEntity.input_powder == null){
    			System.out.println("input_powder = null.");
    			if(isValidItem(player)){
    				tileEntity.input_powder = new ItemStack(player.getCurrentEquippedItem().getItem(), 1);
    				player.getCurrentEquippedItem().stackSize -= 1;
    			}
    		}
    	}
    	if(!world.isRemote){
    		System.out.println(tileEntity.input_iron);
    	}
	return true;
    }
    public void onBlockClicked(World world, int x, int y, int z, EntityPlayer player){
    	if(player.getCurrentEquippedItem() != null && !world.isRemote){
    		if(tileEntity.input_iron.stackSize > 0 && player.getCurrentEquippedItem().getItem() == Items.iron_ingot){
    			player.inventory.addItemStackToInventory(new ItemStack(Items.iron_ingot));
    			tileEntity.input_iron.stackSize -= 1;
    		}
    		if(tileEntity.input_powder != null){
    			if(tileEntity.input_powder.getItem() == player.getCurrentEquippedItem().getItem() && tileEntity.input_powder.stackSize > 0 && player.getCurrentEquippedItem().stackSize < 64){
    				tileEntity.input_powder.stackSize -= 1;
    				player.getCurrentEquippedItem().stackSize += 1;
    			}
    		}
    	}
    	else if(player.getCurrentEquippedItem() == null && !world.isRemote && tileEntity != null){
    		if(tileEntity.input_iron.stackSize > 0){
    			player.inventory.addItemStackToInventory(new ItemStack(Items.iron_ingot, tileEntity.input_iron.stackSize));
    			tileEntity.input_iron.stackSize = 0;
    		}
    		if(tileEntity.input_powder != null){
    			player.inventory.addItemStackToInventory(tileEntity.input_powder);
    			tileEntity.input_powder = null;
    		}
    	}
    }
    public void breakBlock(World world, int x, int y, int z, Block block, int metadata)
    {
    	if(tileEntity.input_iron.stackSize > 0){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, tileEntity.input_iron));
    	}
    	if(tileEntity.input_powder != null){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, tileEntity.input_powder));
    	}
    	if(tileEntity.output != null){
    		world.spawnEntityInWorld(new EntityItem(world, x, y, z, tileEntity.output));
    	}
        super.breakBlock(world, x, y, z, block, metadata);
    }
    public boolean isValidItem(EntityPlayer player){
    	if(player.getCurrentEquippedItem().getItem() == EnderpowerItems.cursedpowder || player.getCurrentEquippedItem().getItem() == EnderpowerItems.poison || player.getCurrentEquippedItem().getItem() == EnderpowerItems.witherpowder){
    		return true;
    	}
    	else {
    		return false;
    	}
    }
    @Override
    public void onBlockAdded(World world, int x, int y, int z){
    	if(world.getTileEntity(x, y, z) != null){
    		tileEntity = (TileEntityMetalEnchanter) world.getTileEntity(x, y, z);
    	}
    }

 

The tileEntity is shorter:

public class TileEntityMetalEnchanter extends TileEntity{
public MetalEnchanter enchanter;

public void updateEntity(){
	if(input_powder != null){
		if(input_powder.stackSize < 1){
			input_powder = null;
		}
	}
	if(output != null){
		if(output.stackSize < 1){
			output = null;
		}
	}
	if(!worldObj.isRemote){
		System.out.println(input_iron);
	}
}
public void writeToNBT(NBTTagCompound nbt){
	super.writeToNBT(nbt);
	if(input_iron != null){
		nbt.setInteger("Iron", input_iron.stackSize);
	}
}
public void readFromNBT(NBTTagCompound nbt){
	super.readFromNBT(nbt);
	input_iron = new ItemStack(Items.iron_ingot, nbt.getInteger("Iron"));
}

    public ItemStack input_iron = new ItemStack(Items.iron_ingot, 0);
    public ItemStack input_powder;
    public ItemStack output;
    
}

 

 

EDIT:

 

I have found the problem.

The block wasn't connected with the tileEntity but it looked like it was.

Now the connection is good, saving the data is easy.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.