Issues with getting data from a tile entity to use in a GUI [Solved]

[Hepolite]

I've run into a small issue with a mod I'm trying to make. I attempted to make a special furnace, so I ended up copying the normal MC furnace so I could edit that code, and made a custom GUI for it. However, there was an issue in all this. Whenever I try to get the time the special furnace has been burning, I keep getting a 0 out of it. The furnace does work as intended, it does burn wood into coal etc. But for some reason the furnace does not give me the expected number when I try to get the number of ticks it has been burning.

 

I did debug things, and the burn timer IS something different from 0, yet the function keep returning 0. I really don't know what I can do about that I suspect that it might have something to do with client/server not communicating properly? When I did debug the code, the value I was interested in reading wasn't zero when debugging the entity update function, but when debugging the GUI code, the value of "furnaceBurnTime" was zero the whole time.

 

The result of the function returning 0 is that I'm unable to display visually how long the item in the furnace has been burning, and I assume I won't be able to display the temperature (Which I'll add later) of the item either with this issue.

 

If the solution is so simple that you feel like facepalming, please note that this is my first time I attempt to make a container, GUI and tile entity. In fact, it's my first time trying to make a real mod, I'm very new to the whole modding this ^^

Any help would be much appreciated!

 

Code pieces that might be of interest:

GuiSugarsmelter:

[hide]

@SideOnly(Side.CLIENT)
public class GuiSugarsmelter extends GuiContainer
{

TileEntitySugarsmelter smelter;

public GuiSugarsmelter (InventoryPlayer inventoryPlayer, TileEntitySugarsmelter tileEntity)
{
	//the container is instanciated and passed to the superclass for handling
	super(new ContainerSugarsmelter(inventoryPlayer, tileEntity));
	smelter = tileEntity;
}

@Override
protected void drawGuiContainerForegroundLayer()
{
	//draw text and stuff here
	//the parameters for drawString are: string, x, y, color
	fontRenderer.drawString("Sugar smelter", 8, 6, 4210752);
	//draws "Inventory" or your regional equivalent
	fontRenderer.drawString(StatCollector.translateToLocal("container.inventory"), 8, ySize - 96 + 2, 4210752);
}

@Override
protected void drawGuiContainerBackgroundLayer(float par1, int par2, int par3)
{
	//draw your Gui here, only thing you need to change is the path
	int texture = mc.renderEngine.getTexture("/hepolite/candy/guisugarsmelter.png");
	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
	this.mc.renderEngine.bindTexture(texture);
	int x = (width - xSize) / 2;
	int y = (height - ySize) / 2;
	this.drawTexturedModalRect(x, y, 0, 0, xSize, ySize);

	int time;

	if (smelter.isBurning())
	{
	    time = smelter.getBurnTimeRemainingScaled(12);
	    this.drawTexturedModalRect(x+56, y+36 + 12-time, 176, 12-time, 14, time+2);
	}

	time = smelter.getCookProgressScaled(24);
	drawTexturedModalRect(time+x+79, y+34, 176, 14, time+1, 16);
}

}

[/hide]

 

ContainerSugarsmelter:

[hide]

public class ContainerSugarsmelter extends Container
{

    protected TileEntitySugarsmelter tileEntity;
   
    public ContainerSugarsmelter(InventoryPlayer inventoryPlayer, TileEntitySugarsmelter te)
    {
        tileEntity = te;

        //the Slot constructor takes the IInventory and the slot number in that it binds to
        //and the x-y coordinates it resides on-screen
        //addSlotToContainer(new Slot(tileEntity, 0, 76, 37));
        this.addSlotToContainer(new Slot(te, 0, 56, 17));
        this.addSlotToContainer(new Slot(te, 1, 56, 53));
        this.addSlotToContainer(new SlotFurnace(inventoryPlayer.player, te, 2, 116, 35));
        
        //commonly used vanilla code that adds the player's inventory
        bindPlayerInventory(inventoryPlayer);
    }
    
    @Override
    public boolean canInteractWith(EntityPlayer player)
    {
        return tileEntity.isUseableByPlayer(player);
    }
    
    protected void bindPlayerInventory(InventoryPlayer inventoryPlayer)
    {
        for (int i = 0; i < 3; i++)
        {
            for (int j = 0; j < 9; j++)
            {
                addSlotToContainer(new Slot(inventoryPlayer, j + i * 9 + 9,
                                8 + j * 18, 84 + i * 18));
            }
        }

        for (int i = 0; i < 9; i++)
        {
            addSlotToContainer(new Slot(inventoryPlayer, i, 8 + i * 18, 142));
        }
    }
    
    @Override
    public ItemStack transferStackInSlot(int slot)
    {
    ItemStack stack = null;
    Slot slotObject = (Slot) inventorySlots.get(slot);

    //null checks and checks if the item can be stacked (maxStackSize > 1)
    if (slotObject != null && slotObject.getHasStack())
    {
        ItemStack stackInSlot = slotObject.getStack();
        stack = stackInSlot.copy();

        //merges the item into player inventory since its in the tileEntity
        if (slot == 0)
        {
            if (!mergeItemStack(stackInSlot, 1, inventorySlots.size(), true))
            {
                return null;
            }
        //places it into the tileEntity is possible since its in the player inventory
        }
        else if (!mergeItemStack(stackInSlot, 0, 1, false))
        {
            return null;
        }

        if (stackInSlot.stackSize == 0)
        {
            slotObject.putStack(null);
        }
        else
        {
            slotObject.onSlotChanged();
        }
    }

    return stack;
}
}

[/hide]

 

TileEntitySugarsmelter:

[hide]

	@SideOnly(Side.CLIENT)
public int getCookProgressScaled(int par1)
{
    return this.furnaceCookTime * par1 / this.cookTime;
}

@SideOnly(Side.CLIENT)
public int getBurnTimeRemainingScaled(int par1)
{
    if (this.currentItemBurnTime == 0)
    {
        this.currentItemBurnTime = this.cookTime;
    }

    return this.furnaceBurnTime * par1 / this.currentItemBurnTime;
}

public boolean isBurning()
{
    return this.furnaceBurnTime > 0;
}

[/hide]

 

getClientGuiElement:

[hide]

public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
    {
        TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
        if(tileEntity instanceof TileEntitySugarsmelter)
        {
            return new GuiSugarsmelter(player.inventory, (TileEntitySugarsmelter)tileEntity);
        }
        return null;
    }

[/hide]

 

[DarkGuardsman]

Its not simple but is needed. You need to make a packet system to send your data to the client. Use this as reference point :

https://github.com/DarkGuardsman/GSM-Guardsman/tree/master/src/common/npc/Network

[Hepolite]

Ah, thanks a lot! I got it to work. However, there's only one more thing I'm wondering about...

 

Right now I'm sending a packet in the onBlockActivated under BlockSugarsmelter, which is probably a terrible place to send this packet, as the values don't change while the GUI is open, only when opening the GUI. Where should I send this packet, so that it sends only when the GUI is open?

[DarkGuardsman]

in the TileEntity public void updateEntity() is where i send my packets but there are a few other place like getAuxPacket(). I suggest if you use updateEntity() to code it like this

int count = 0;
public void updateEntity()
{
if(count++ > 10)
{
count = 0;
if(!worldObj.isRemote)
{
//TODO send packet
}
}

this will only send the packet on the server and reduce lag to only send a packet 2 times a second.

[Hepolite]

I was afraid I had to use the updateEntity function, but oh well... Didn't think of adding a delay though, and with that it would definitely work well. Added some code, and it works perfectly, thanks again!