[1.7.10] Overwriting existing Enum

[Ieuan]

I'm trying to create a mod that changes an Enum in an already existing mod to allow more skins to be loaded. The idea was that I'd overwrite the existing Enum with the one from my mod, either by loading it before the other mod does and ignoring the one the other mod has, or by overwriting the other mod's class with mine.

 

I tested it in various ways, and I can't seem to get it working well. I got to the point where in my dev environment it works, but then in a normal client it errors out because the class was already injected.

 

Is there any (good) way to do this?

[FlameAtronach93]

Too little information.

 

What have you already tried? Are you using a Coremod and a Class Adapter? That's what I'd go with.

If it's just a variable you need to adjust, I'd try using reflection instead. I avoid core mods as far as possible... Makes your coding life slightly easier.

 

Also, do you see any error in the Launcher's output in a regular, non-dev environment?

 

Last but not least, you might want to post some code...

[Ieuan]

Well there really isn't a lot else to say. It's a mod that has an Enum used to load NPC textures, I need to overwrite that Enum from another mod.

 

The problem isn't that I can't access the Enum, it's that before the textures are loaded (i.e. before the Enum is called) I need to already change it so that it loads the added textures as well.

 

I'll reproduce my errors and post some logs.

[Ieuan]

You want to replace textures? Use a ResourcePack (mods are ResourcePacks, too, but they are always active).

 

No, why would I use an Enum to replace textures? There's basically an Enum with texture names in the mod, that Enum gets loaded and from there it selects the textures (using the Enum to iterate over the available textures). I need to add textures to this list, which is only possible by modifying the Enum. I right now have my own modified version of the mod (copied the deobfuscated class, built my file, copied my built class to the mod jar and copied the assets over as well) but I need it separate.

[Ieuan]

You can use Coremods to modify classes, but that is a very bad idea, especially when it comes to classes from other mods.

 

Well what other options do I have? I can't find any info on Class Adapters as mentioned before, not sure if that would work..

 

The thing is that the way this mod is built, the only thing it checks for the textures are that Enum. It's just for one NPC with multiple possible textures, and that Enum has all the current assets for that NPC in it. I simply have to add more to that Enum to get it to 'recognize' the assets I put in the folder.

 

It's either modifying just that Enum that doesn't have any real impact other than that one texture, or modifying the way it loads that texture by checking the Enum for possibilities..

[Ieuan]

Oh, so you just want to add new Enum instances. Look at Forge's EnumHelper class.

 

I don't want to reference the Enum though.. I want to change the Enum so that the mod itself can load my textures as well.. As far as I can find EnumHelper doesn't let me do that

[jeffryfisher]

Oh, so you just want to add new Enum instances. Look at Forge's EnumHelper class.

 

I don't want to reference the Enum though.. I want to change the Enum so that the mod itself can load my textures as well.. As far as I can find EnumHelper doesn't let me do that

EnumHelper should let you do exactly what you've talked about (shove some new enum values into somebody else's enum), so look again. If there's still a problem, then start posting code. Maybe you need to learn reflection from looking at how EnumHelper works. Then you can hack the enum the way you want.

[larsgerrits]

He doesn't want to add new enums to an existing one, but modify the ones that already exist.

[jabelar]

What about doing this differently -- why not try to intercept the textures where they are used, or during the render?  Also, as diesieben07 says, you should be able to replace textures using resource pack instead.

[Ieuan]

Oh, so you just want to add new Enum instances. Look at Forge's EnumHelper class.

 

I don't want to reference the Enum though.. I want to change the Enum so that the mod itself can load my textures as well.. As far as I can find EnumHelper doesn't let me do that

EnumHelper should let you do exactly what you've talked about (shove some new enum values into somebody else's enum), so look again. If there's still a problem, then start posting code. Maybe you need to learn reflection from looking at how EnumHelper works. Then you can hack the enum the way you want.

 

Alright. I'll look into EnumHelper. I can't post code because the only code that's relevant is not mine, which is also why I need to go the long way around instead of simply modifying that code.

 

I'll post my results when I have some.

 

[jeffryfisher]

He doesn't want to add new enums to an existing one, but modify the ones that already exist.

He said "I want to change the Enum so that the mod itself can load my textures as well."

That looks like adding new enum values.