Jump to content

Recommended Posts

Posted

Lately I have been trying to make a block that I can walk through as though it was air. I have tried isOpaqueCube and renderAsNormalBlock but they don't work. Also, the block has a custom render type. How can I make the block non-solid?

Posted

Hi

 

Those methods you mentioned are for rendering only, not collision.

 

Try this method from BlockTorch (you can't collide with a torch!)

    /**
     * Returns a bounding box from the pool of bounding boxes (this means this box can change after the pool has been
     * cleared to be reused)
     */
@Override
    public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int wx, int wy, int wz)
    {
        return null;
    }

-TGG

Posted

package com.noodles.MPMod;

 

import java.util.Random;

 

import net.minecraft.block.Block;

import net.minecraft.block.material.Material;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.init.Blocks;

import net.minecraft.item.Item;

import net.minecraft.server.MinecraftServer;

import net.minecraft.util.AxisAlignedBB;

import net.minecraft.world.IBlockAccess;

import net.minecraft.world.World;

 

public class BlockBase extends Block

{

    private static final String __OBFID = "CL_00000317";

    public static int render;

    public static int rid = 2;

    public static boolean opaque;

 

    public BlockBase(int render, boolean opaque)

    {

        super(Material.wood);

        this.render = render;

        this.opaque = opaque;

    }

 

    public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)

    {

        return Item.getItemFromBlock(this);

    }

   

    public void setRender() {

rid = render;

}

   

    public int getRenderType()

    {

        return rid;

    }

   

    public boolean isOpaqueCube()

    {

        return opaque;

    }

 

}

 

Posted

1. This is a slightly older class that I accidentally uploaded

2. This is a slightly older class that I accidentally uploaded

3. This is a slightly older class that I accidentally uploaded

4. It is supposed to set the render type (which is does perfectly)

5. This is a slightly older class that I accidentally uploaded

Posted

BTW, even with the newer class:

 

==================

 

package com.noodles.MPMod;

 

import java.util.Random;

 

import net.minecraft.block.Block;

import net.minecraft.block.material.Material;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.init.Blocks;

import net.minecraft.item.Item;

import net.minecraft.server.MinecraftServer;

import net.minecraft.util.AxisAlignedBB;

import net.minecraft.world.IBlockAccess;

import net.minecraft.world.World;

 

public class BlockBase extends Block

{

    public int render;

    public int rid = 2;

    public boolean opaque;

 

    public BlockBase(int render, boolean opaque)

    {

        super(Material.wood);

        this.render = render;

        this.opaque = opaque;

    }

 

    public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)

    {

        return Item.getItemFromBlock(this);

    }

   

    public void setRender() {

rid = render;

}

   

    @Override

    public int getRenderType()

    {

        return rid;

    }

   

    @Override

    public boolean isOpaqueCube()

    {

        return opaque;

    }

   

    @Override

    public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int wx, int wy, int wz)

    {

        return null;

    }

 

}

====================

 

It is still not letting me pass through the block and instead making me bounce off!

Posted

Yes, it matters, because this shows that you have no idea wtf you are doing.

If you really have that getCollisionBoundingBoxFromPool in your class you will be able to walk though it. If that's not the case, you are doing something wrong.

 

The setRender method has absolutely nothing to do with my question!!! My question SPECIFICALLY SAID: How to make a block that you can walk through!!!

Posted

Is opaque true or false?

 

Yes, opaque is true.

 

No reason to freak out. If you don't like constructive criticism about your code, don't post here.

 

How exactly was that constructive criticism? Sounded to me more like being completely off-topic.

  • Like 1
Posted

 

The setRender method has absolutely nothing to do with my question!!! My question SPECIFICALLY SAID: How to make a block that you can walk through!!!

 

When he is saying that, it does not matter if It pertains to the question at hand or not. He is basically just saying that its not needed, or that for good practice it should be done another way. One major thing about programming is to be efficient, organized, and being very anal about what is going on in the code. I'm not saying I'm a perfect at it or anything, but I would love for people to point stuff out like that. It helps in the long run, looks better, and may even run better. It's not like hes targeting you or anything, some things may be harsh and pretty straight forward, but it's part of how this kind of stuff goes. I been yelled at him multiple times when I was starting. I just took his advice and kept on.

  • 2 months later...
Posted

Just in case you were still trying to get this to work... Add this to your code:

@Override
public boolean renderAsNormalBlock()
{
return ConfigurationHelper.markerBlockCollide;
}

Posted

Just in case you were still trying to get this to work... Add this to your code:

@Override
public boolean renderAsNormalBlock()
{
return ConfigurationHelper.markerBlockCollide;
}

Given that that is the first post on your account im just going to assume that you are trolling. If not go learn how minecraft works.

 

As for the topic of this post overriding getCollisionBoundingBoxFromPool and returning null should work i have done it in the past and it worked perfectly. Just to make sure i wrote the following to test it.

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

/**
* Created by Brandon on 7/01/2015.
*/
public class TestBlock extends Block {
protected TestBlock() {
	super(Material.wood);
	this.setBlockName("testblock");
	this.setCreativeTab(CreativeTabs.tabBlock);
}

@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World p_149668_1_, int p_149668_2_, int p_149668_3_, int p_149668_4_) {
	return null;
}
}

That worked just fine for me so if it dosnt work for you there is something else going on.

 

But given how old this thread is im guessing no one cares anymore because this has long since been solved or abandoned.

 

Edit: So i figured out that the problem is when you stack two of them and try to walk through them. To fix it override renderAsNormalBlock and return false.

 

So maby Sbeagin's post wasnt as trolly as i thought but still not a great explanation.

I am the author of Draconic Evolution

Posted

Like you said, this is kinda an old topic.  But because you brought it up again, I'm interested in this.

 

Why wouldn't the collision bounding box override be sufficient even with stacked blocks?  I assumed that when Minecraft is looking for collisions it would invoke the message for all blocks that might possibly collide.  So what is explanation for why render as normal block would affect this?  Are blocks that are at different height checked differently for collisions?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

I believe if the material of a block is solid, even if it doesn't have a collision box, a player will suffocate in it (when it's stacked 2 blocks high). I ran into something where I could walk through the blocks, but they would push me out when I tried to stay in them.

Posted

Did a little digging and solved the mystery.

 

This is the code in EntityLivingBase that applies suffocation damage

if (this.isEntityAlive() && this.isEntityInsideOpaqueBlock())
{
      this.attackEntityFrom(DamageSource.inWall, 1.0F);
}

And the code that checks if the entity is inside an opaque block inside Entity

public boolean isEntityInsideOpaqueBlock()
{
    for (int i = 0; i < 8; ++i)
    {
        float f = ((float)((i >> 0) % 2) - 0.5F) * this.width * 0.8F;
        float f1 = ((float)((i >> 1) % 2) - 0.5F) * 0.1F;
        float f2 = ((float)((i >> 2) % 2) - 0.5F) * this.width * 0.8F;
        int j = MathHelper.floor_double(this.posX + (double)f);
        int k = MathHelper.floor_double(this.posY + (double)this.getEyeHeight() + (double)f1);
        int l = MathHelper.floor_double(this.posZ + (double)f2);

        if (this.worldObj.getBlock(j, k, l).isNormalCube())
        {
            return true;
        }
    }

    return false;
}

And finally isNormalCube inside Block

public boolean isNormalCube()
{
    return this.blockMaterial.isOpaque() && this.renderAsNormalBlock() && !this.canProvidePower();
}

 

And that is how renderAsNormalBlock affects suffocation damage.

I am the author of Draconic Evolution

  • 3 months later...
Posted

Just in case you were still trying to get this to work... Add this to your code:

@Override
public boolean renderAsNormalBlock()
{
return ConfigurationHelper.markerBlockCollide;
}

Given that that is the first post on your account im just going to assume that you are trolling. If not go learn how minecraft works.

 

As for the topic of this post overriding getCollisionBoundingBoxFromPool and returning null should work i have done it in the past and it worked perfectly. Just to make sure i wrote the following to test it.

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

/**
* Created by Brandon on 7/01/2015.
*/
public class TestBlock extends Block {
protected TestBlock() {
	super(Material.wood);
	this.setBlockName("testblock");
	this.setCreativeTab(CreativeTabs.tabBlock);
}

@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World p_149668_1_, int p_149668_2_, int p_149668_3_, int p_149668_4_) {
	return null;
}
}

That worked just fine for me so if it dosnt work for you there is something else going on.

 

But given how old this thread is im guessing no one cares anymore because this has long since been solved or abandoned.

 

Edit: So i figured out that the problem is when you stack two of them and try to walk through them. To fix it override renderAsNormalBlock and return false.

 

So maby Sbeagin's post wasnt as trolly as i thought but still not a great explanation.

I am so sorry I didn't copy/paste the right thing lol I meant to put this:

@Override
public boolean renderAsNormalBlock()
{
	return false;
}
@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int wx, int wy, int wz)
{
return null;
}

I don't know how I screwed that up...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.