Jump to content

[1.7.10] [SOLVED]Liquids in the Dimension problem


Recommended Posts

Posted

Registering liquid, dimension, biome, and testing it works fine, But when i add something new to my mod, all liquid in world get replaced with other block. Is it because of id changes? Will this issue stay in 1.8?

What i already tried: move registration to pre init, move = new SkyLiquid to init or pre-init, hothing helped

Class where i register liquid:

package code.blocktoolsarmormod.registry;

import net.minecraft.block.Block;
import code.blocktoolsarmormod.world.dimensions.Sky.SkyLiquidFlowing;
import code.blocktoolsarmormod.world.dimensions.Sky.SkyLiquidStill;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;

public class LiquidRegistry {

public static Block SkyLiquidStill = new SkyLiquidStill().setBlockName("SkyLiquidStill");
public static Block SkyLiquidFlowing = new SkyLiquidFlowing().setBlockName("SkyLiquidFlowing");

public static void preinit(FMLPreInitializationEvent event)
{ 

}


public static void init(FMLInitializationEvent event)
{ 
	GameRegistry.registerBlock(SkyLiquidStill, "SkyLiquidStill");
	GameRegistry.registerBlock(SkyLiquidFlowing, "SkyLiquidFlowing");
}


public static void postinit(FMLPostInitializationEvent event)
{ 

}
}

Posted

Yes:

Injecting existing block and item data into this server instance
[10:32:31] [server thread/INFO]: Injecting new block and item data into this server instance.
[10:32:31] [server thread/INFO]: Injected new block/item blocktoolsarmormod:blockA: 184 (init) -> 185 (map).
[10:32:31] [server thread/INFO]: Injected new block/item blocktoolsarmormod:blockA: 184 (init) -> 185 (map).
[10:32:31] [server thread/INFO]: Injected new block/item blocktoolsarmormod:itemB: 4458 (init) -> 4459 (map).

Posted

Also i found out this: Liquid automatically turns in another block even when placed by me and updated?

Reading through BlockDynamicLiquid and BlockStaticLiquid, if found methods, that are responsible for making in flow, where to detect another state of liquid, getIdFromBlock(this) - 1 is used, its private method, and it cannot be overrided...

 

STUPID MINECRAFT!!!!! JUST BY REGISTERING STILL LIQUID AFTER FLOWING MAKES IT WORK PROPERLY!!! FACEPALM

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
    • https://paste.ee/p/h1JX9bbl
    • Add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.