Jump to content

Recommended Posts

Posted

Okay, so, I want to make a mob spawner. According to the minecraft forge wiki I do the following:

TileEntityMobSpawner spawner1 = (TileEntityMobSpawner)world.getTileEntity(i + 21, j + 6, k + 33);
if (spawner1 == null) {
   System.out.println("TomBoy Spawner 1 is Null.");
} else {
   spawner1.func_145881_a().setEntityName("Zombie");
}

That works perfectly fine. Now the question is... I want to make this zombie spawner spawn Baby Zombies with armor and weapons. How would I go about doing that? I tried this, but it didn't do anything.

	    NBTTagCompound nbt = new NBTTagCompound();
    spawner1.writeToNBT(nbt);
    nbt.setBoolean("IsBaby",true);
    spawner1.readFromNBT(nbt);

Posted

Use

spawner1.func_145881_a().setRandomEntity(new WeightedRandomMinecart(nbt, entityName))

where

nbt

is the NBT you want to give your entities and

entityName

the name of the entity you want to spawn.

 

Using that, you can omit

spawner1.func_145881_a().setEntityName("Zombie");

, since above code does this as well.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

I feel like a noob here... I imagine with the "nbt" in that statement, I input the nbt into that part? Or do I set it up like before with the nbt stuff followed by that line of code? I'm not sure how to code the nbt data into that line if that's what I have to do, and I tried this, but got an error:

		    NBTTagCompound nbt = new NBTTagCompound();
	    spawner1.writeToNBT(nbt);
	    nbt.setBoolean("IsBaby",true);
	    spawner1.readFromNBT(nbt);
		spawner1.func_145881_a().setRandomEntity(new WeightedRandomMinecart(nbt, "Zombie"));

No enclosing instance of type MobSpawnerBaseLogic is accessible. Must qualify the allocation with an enclosing instance of type MobSpawnerBaseLogic (e.g. x.new A() where x is an instance of MobSpawnerBaseLogic).

I know it's probably just a matter of me not understanding the code 100%... but again, that's the problem, I don't understand the code... Like I said, I'm not sure how to input that nbt stuff into the nbt line, and putting the nbt info in and then calling that seems to cause the error, so now I'm confused x.x Sorry.

Posted

I feel like a noob here... I imagine with the "nbt" in that statement, I input the nbt into that part? Or do I set it up like before with the nbt stuff followed by that line of code? I'm not sure how to code the nbt data into that line if that's what I have to do, and I tried this, but got an error:

		    NBTTagCompound nbt = new NBTTagCompound();
	    spawner1.writeToNBT(nbt);
	    nbt.setBoolean("IsBaby",true);
	    spawner1.readFromNBT(nbt);
		spawner1.func_145881_a().setRandomEntity(new WeightedRandomMinecart(nbt, "Zombie"));

No enclosing instance of type MobSpawnerBaseLogic is accessible. Must qualify the allocation with an enclosing instance of type MobSpawnerBaseLogic (e.g. x.new A() where x is an instance of MobSpawnerBaseLogic).

I know it's probably just a matter of me not understanding the code 100%... but again, that's the problem, I don't understand the code... Like I said, I'm not sure how to input that nbt stuff into the nbt line, and putting the nbt info in and then calling that seems to cause the error, so now I'm confused x.x Sorry.

 

1.  you don't need the write/read NBT methods from your spawner.

2. The error has something to do that WeightedRandomMinecart is a non-static inner class from MobSpawnerBaseLogic, means you need to use an instance of MobSpawnerBaseLogic to create a new instance of WeightedRandomMinecart, like this:

spawner1.func_145881_a().new WeightedRandomChestMinecart(nbt, entityName)

 

Also I recommend to save the return value of func_145881_a() in a variable to avoid repeated calls to that method.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

I feel like a noob here... I imagine with the "nbt" in that statement, I input the nbt into that part? Or do I set it up like before with the nbt stuff followed by that line of code? I'm not sure how to code the nbt data into that line if that's what I have to do, and I tried this, but got an error:

		    NBTTagCompound nbt = new NBTTagCompound();
	    spawner1.writeToNBT(nbt);
	    nbt.setBoolean("IsBaby",true);
	    spawner1.readFromNBT(nbt);
		spawner1.func_145881_a().setRandomEntity(new WeightedRandomMinecart(nbt, "Zombie"));

No enclosing instance of type MobSpawnerBaseLogic is accessible. Must qualify the allocation with an enclosing instance of type MobSpawnerBaseLogic (e.g. x.new A() where x is an instance of MobSpawnerBaseLogic).

I know it's probably just a matter of me not understanding the code 100%... but again, that's the problem, I don't understand the code... Like I said, I'm not sure how to input that nbt stuff into the nbt line, and putting the nbt info in and then calling that seems to cause the error, so now I'm confused x.x Sorry.

 

1.  you don't need the write/read NBT methods from your spawner.

2. The error has something to do that WeightedRandomMinecart is a non-static inner class from MobSpawnerBaseLogic, means you need to use an instance of MobSpawnerBaseLogic to create a new instance of WeightedRandomMinecart, like this:

spawner1.func_145881_a().new WeightedRandomChestMinecart(nbt, entityName)

 

Also I recommend to save the return value of func_145881_a() in a variable to avoid repeated calls to that method.

I'm confused...didn't I have that code in there, though? Or am I missing something? I got rid of the read/write nbt lines, so now I have:

	    NBTTagCompound nbt = new NBTTagCompound();
	    nbt.setBoolean("IsBaby",true);
		spawner1.func_145881_a().setRandomEntity(new WeightedRandomMinecart(nbt, "Zombie"));

That last line there is the line you gave me... Unless I'm not supposed to be inputting the actual entityName into it and am supposed to be doing that separate somewhere else? I'm sorry I'm being a bit of a pain about this... This is probably something super simple that I should have been able to set up with just your initial statement... but I just don't understand how this works...

Posted

I'm guessing by the lack of help I've gotten since my last post that this is something super simple that I should understand but don't... problem is just that, though... I don't understand it... Could anyone help?

Posted

If you didn't see the difference in the code SanAndreasP posted and yours it's here:

 

spawner1.func_145881_a().new WeightedRandomChestMinecart(nbt, entityName)

 

This creates a new WeightedRandomChestMinecart object with the specified parameters

--Remember to "Thank you" posts that actually helped you, and if a person seems nice, why not give them an applaud while you're at it--

Posted

Oh wow... I feel stupid now. Yeah, that is different code. It looked very similar, so my mind read it as being the same code (I have a number of reading disorders). That said... I got an error on the WeightedRandomChestMinecart. Java told me to change it to "WeightedRandomMinecart".

MobSpawnerBaseLogic.WeightedRandomChestMinecart cannot be resolved to a type

I changed it to the WeightedRandomMinecart instead like it said...but it doesn't seem to change anything with the mob spawner. I'm still getting regular Zombies and I'm trying to make it spawn Baby Zombies.

 

EDIT: Correction... I forgot to destroy the spawners and then regenerate them. They've all turned into pig spawners now...

TileEntityMobSpawner spawner1 = (TileEntityMobSpawner)world.getTileEntity(i + 21, j + 6, k + 33);
	if (spawner1 == null) {
		System.out.println("TomBoy Spawner 1 is Null.");
	} else {
	    NBTTagCompound nbt = new NBTTagCompound();
	    nbt.setBoolean("IsBaby",true);
	    spawner1.func_145881_a().new WeightedRandomMinecart(nbt, "Zombie");
	}

Did I do this wrong again?

Posted

Anyone know why this still isn't working? I'm still not getting anything other then pig spawners from this code and I have no idea what else to do. Should I just abandon the idea of having baby zombies? Is that just not a thing I can do through modding?

Posted

Dont be silly anything is possible with modded minecraft!

 

I couldn't get what SanAndreasP was talking about to work for some reason but this works

 

TileEntity spawner = world.getTileEntity(x, y, z);
if (spawner instanceof TileEntityMobSpawner){
MobSpawnerBaseLogic logic = ((TileEntityMobSpawner)spawner).func_145881_a();
logic.setEntityName("Zombie");

EntityZombie zombie = new EntityZombie(world);
zombie.setChild(true);

NBTTagCompound compound = new NBTTagCompound();
zombie.writeEntityToNBT(compound);

NBTTagCompound compound2 = new NBTTagCompound();
logic.writeToNBT(compound2);
compound2.setTag("SpawnData", compound);

logic.readFromNBT(compound2);
}

 

This works by modifying the spanners nbt its not as good as what SanAndreasP suggested but it works. 

 

Edit: only down side i have found is that it only spawns one mob at a time like that.

I am the author of Draconic Evolution

Posted

Dont be silly anything is possible with modded minecraft!

 

I couldn't get what SanAndreasP was talking about to work for some reason but this works

 

TileEntity spawner = world.getTileEntity(x, y, z);
if (spawner instanceof TileEntityMobSpawner){
MobSpawnerBaseLogic logic = ((TileEntityMobSpawner)spawner).func_145881_a();
logic.setEntityName("Zombie");

EntityZombie zombie = new EntityZombie(world);
zombie.setChild(true);

NBTTagCompound compound = new NBTTagCompound();
zombie.writeEntityToNBT(compound);

NBTTagCompound compound2 = new NBTTagCompound();
logic.writeToNBT(compound2);
compound2.setTag("SpawnData", compound);

logic.readFromNBT(compound2);
}

 

This works by modifying the spanners nbt its not as good as what SanAndreasP suggested but it works. 

 

Edit: only down side i have found is that it only spawns one mob at a time like that.

If I could hit Thank You 100 times, I would. Thank you so much, this works finally! I've been trying to get this thing figured out for months now (before I made this topic). Thank you so much!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.