Packets for TileEntities

[shieldbug1]

This is a rather simple question. How would I send an update to all clients tracking (or clients 'associated' with) a TileEntity?

I know that with entities I can use

public static void sendToAllTracking(SimpleNetworkWrapper wrapper, Entity entity, IMessage message)
{
    if(entity.worldObj instanceof WorldServer)
    {
        ((WorldServer)entity.worldObj).getEntityTracker().func_151247_a(entity, wrapper.getPacketFrom(message));
    }
}

 

However, browsing through Vanilla code for TileEntities all I've found that would work is this:

public static void sendToAllTracking(SimpleNetworkWrapper wrapper, TileEntity tileEntity, IMessage message)
{
    if(entity.worldObj instanceof WorldServer)
    {
        ((WorldServer)entity.worldObj).getPlayerManager().getOrCreateChunkWatcher(tileEntity.xCoord, tileEntity.zCoord, false).sendToAllPlayersWatchingChunk(wrapper.getPacketFrom(message));
    }
}

 

However, those methods are private (and PlayerInstance is package private anyway), an reflection shouldn't be used for something as trivial as this.

 

Of course, I could just use SimpleNetworkWrapper#sendToAllAround(IMessage,TargetPoint) with a radius of 15 or 16 (and that's what I've been doing so far), but I would like to know if there is a 'proper' way to do this?

[shieldbug1]

What should this request contain? Would it just be changing the visibility of those methods, or would it have to be something more complex?

 

I have some spare time right now, I can go give it a try.

[shieldbug1]

Collections.unmodifiableList or ImmutableList.copyOf?

[shieldbug1]

Alright.

[shieldbug1]

How does this look?

public List<net.minecraft.entity.player.EntityPlayer> playersWatchingChunk(int x, int y)
{
    PlayerInstance pi = getOrCreateChunkWatcher(x, y, false);
    return pi != null ? java.util.Collections.unmodifiableList(pi.playersWatchingChunk) : java.util.Collections.emptyList();
}
    
public void sendPacketToWatching(int x, int y, Packet packet)
{
    PlayerInstance pi = getOrCreateChunkWatcher(x, y, false);
    if(pi != null)
    {
        pi.sendToAllPlayersWatchingChunk(packet);
    }
}

[shieldbug1]

Alright, done.