[1.7.2][Solved] Can still fly when gravity chestplate is off

[skullcrusher1005]

oops my bad it is .getItem() i am not very good at remembering methods outside my workspace.

 

Edit: add a println to each side of the if statment to see if it is detecting that you are wearing the item.

 

Still can't fly here's the code if I've done something incorrect

 

 

@SubscribeEvent

public void onEntityUpdate(PlayerTickEvent event) {

        if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

 

        if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate) {

String ownerName = event.player.getDisplayName();

playersWithFlight.put(event.player, true);

event.player.capabilities.allowFlying = true;

 

} else {

String ownerName = event.player.getDisplayName();

 

if (!playersWithFlight.containsKey(event.player)) {

playersWithFlight.put(event.player, false);

        }

 

if (playersWithFlight.get(event.player)) {

playersWithFlight.put(event.player, false);

 

if (!event.player.capabilities.isCreativeMode) {

event.player.capabilities.allowFlying = false;

event.player.capabilities.isFlying = false;

event.player.sendPlayerAbilities();

}

}

}

}

 

 

[brandon3055]

That looks ok assuming BetterThings.GravityChestplate is correct.

Add System.out.println("event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate")

 

after

 

if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

 

That should spamm your console with ether true or false and it should change when you equip/unequip the chest plate. If it dosnt print anything then you havent registered the event handler properly.

[skullcrusher1005]

That looks ok assuming BetterThings.GravityChestplate is correct.

Add System.out.println("event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate")

 

after

 

if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

 

That should spamm your console with ether true or false and it should change when you equip/unequip the chest plate. If it dosnt print anything then you havent registered the event handler properly.

Didn't get any spam so I must not have registered it correctly.

[brandon3055]

Show how you are registering it.

It should be

FMLCommonHandler.instance().bus().register(new EventHandlerClass());

And it should be in your preinit method

[skullcrusher1005]

Show how you are registering it.

It should be

FMLCommonHandler.instance().bus().register(new EventHandlerClass());

And it should be in your preinit method

Sorry for the delay, I had to watch a movie with my family, but here is the code.

 

FMLCommonHandler.instance().bus().register(new ArmorEventHandler());

 

Not really sure what I'm supposed to put in that class though.

[brandon3055]

That is where the

@SubscribeEvent

public void onEntityUpdate(PlayerTickEvent event)

method is supposed to be...

[skullcrusher1005]

That is where the

@SubscribeEvent

public void onEntityUpdate(PlayerTickEvent event)

method is supposed to be...

Question, How does the GravityArmor class know that the event it is looking for is located in the ArmorEventHandler?

Also, If I don't reply it means I wen't to sleep I have to get up for school in the morning But, I'll finish when I get home.

[brandon3055]

The armor class dosnt need to know anything. It is the ArmorEventHandler that detects if the players is wearing the chestplate and sets weather or not they can fly.

[brandon3055]

Message Deleted (Wrong thread)

[MuffinMonster]

Afaik the way you register eventHandlers is by using

MinecraftForge.EVENT_BUS.register(new EventHandlerClassHere() );

in the preInit or preLoad method.

 

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

[MrCaracal]

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

 

This is not what those annotations mean exactly. See here: http://www.minecraftforge.net/forum/index.php/topic,22764

[skullcrusher1005]

Wow I've been putting it into the wrong class the whole time It spams my console like you said it should but it still however doesn't allow me to fly.

[skullcrusher1005]

Afaik the way you register eventHandlers is by using

MinecraftForge.EVENT_BUS.register(new EventHandlerClassHere() );

in the preInit or preLoad method.

 

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

There are two ways of registering event handlers the MinecraftForge event is the 2nd way FMLCommonHandler.instance().bus().register(new ClassName()) is another way.

[brandon3055]

Afaik the way you register eventHandlers is by using

MinecraftForge.EVENT_BUS.register(new EventHandlerClassHere() );

in the preInit or preLoad method.

 

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

There are two ways of registering event handlers the MinecraftForge event is the 2nd way FMLCommonHandler.instance().bus().register(new ClassName()) is another way.

Thats kinda correct.

There are multiple different event busses

MinecraftForge.EVENT_BUS

and

FMLCommonHandler.instance().bus()

are just 2 of therm and they each handle different events so you need to register your event to the correct buss which in this case is

FMLCommonHandler.instance().bus()

 

And he isnt working on the client side.

 

@OP

Well you are closer atleast try adding

System.out.println("Equipment Stack "+getEquipmentInSlot(3).getItem());
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

 

bellow

if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

and tell me what is printed to the console.

 

 

[skullcrusher1005]

Afaik the way you register eventHandlers is by using

MinecraftForge.EVENT_BUS.register(new EventHandlerClassHere() );

in the preInit or preLoad method.

 

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

There are two ways of registering event handlers the MinecraftForge event is the 2nd way FMLCommonHandler.instance().bus().register(new ClassName()) is another way.

Thats kinda correct.

There are multiple different event busses

MinecraftForge.EVENT_BUS

and

FMLCommonHandler.instance().bus()

are just 2 of therm and they each handle different events so you need to register your event to the correct buss which in this case is

FMLCommonHandler.instance().bus()

 

And he isnt working on the client side.

 

@OP

Well you are closer atleast try adding

System.out.println("Equipment Stack "+getEquipmentInSlot(3).getItem());
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

 

bellow

if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

and tell me what is printed to the console.

That caused me to crash here's the report.

 

java.lang.NullPointerException: Ticking player

at com.skullcrusher.BetterThings.eventhandlers.ArmorEventHandler.onEntityUpdate(ArmorEventHandler.java:20)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_4_ArmorEventHandler_onEntityUpdate_PlayerTickEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)

at cpw.mods.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:344)

at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:274)

at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:341)

at net.minecraft.network.NetHandlerPlayServer.processPlayer(NetHandlerPlayServer.java:326)

at net.minecraft.network.play.client.C03PacketPlayer.processPacket(C03PacketPlayer.java:37)

at net.minecraft.network.play.client.C03PacketPlayer$C06PacketPlayerPosLook.processPacket(C03PacketPlayer.java:271)

at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:232)

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:720)

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:608)

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)

at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:746)

 

 

[skullcrusher1005]

Afaik the way you register eventHandlers is by using

MinecraftForge.EVENT_BUS.register(new EventHandlerClassHere() );

in the preInit or preLoad method.

 

EDIT: Also you should be using @SideOnly(Side.CLIENT) When you're working on the clientside.

There are two ways of registering event handlers the MinecraftForge event is the 2nd way FMLCommonHandler.instance().bus().register(new ClassName()) is another way.

Thats kinda correct.

There are multiple different event busses

MinecraftForge.EVENT_BUS

and

FMLCommonHandler.instance().bus()

are just 2 of therm and they each handle different events so you need to register your event to the correct buss which in this case is

FMLCommonHandler.instance().bus()

 

And he isnt working on the client side.

 

@OP

Well you are closer atleast try adding

System.out.println("Equipment Stack "+getEquipmentInSlot(3).getItem());
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

 

bellow

if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

and tell me what is printed to the console.

The  System.out.println("Equipment Stack "+getEquipmentInSlot(3).getItem()); is giving me the crash, I had to create a method for +getEquipmentInSlot(3) So I could get the error to go away. Not sure if that's why it crashed or not.

[brandon3055]

oops remove .getItem() from the first System.out so

System.out.println("Equipment Stack "+getEquipmentInSlot(3));
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

and make sure you are wearing the chestplate it crashed because it tried to get the item from the stack in your chestplate slot but that stack was null.

[skullcrusher1005]

oops remove .getItem() from the first System.out so

System.out.println("Equipment Stack "+getEquipmentInSlot(3));
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

and make sure you are wearing the chestplate it crashed because it tried to get the item from the stack in your chestplate slot but that stack was null.

No, it crashed on world load.

[brandon3055]

Oops another typo it should be event.player.getEquipmentInSlot(3) Didnt it give you an error on that line?

[skullcrusher1005]

oops remove .getItem() from the first System.out so

System.out.println("Equipment Stack "+getEquipmentInSlot(3));
if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
System.out.println("Target Item"+BetterThings.GravityChestplate);
if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

and make sure you are wearing the chestplate it crashed because it tried to get the item from the stack in your chestplate slot but that stack was null.

Heres the code for the armor event handler

 

package com.skullcrusher.BetterThings.eventhandlers;

 

import java.util.Map;

import java.util.WeakHashMap;

 

import com.skullcrusher.BetterThings.BetterThings;

 

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

import cpw.mods.fml.common.gameevent.TickEvent;

import cpw.mods.fml.common.gameevent.TickEvent.PlayerTickEvent;

 

public class ArmorEventHandler {

public static Map<EntityPlayer, Boolean> playersWithFlight = new WeakHashMap<EntityPlayer, Boolean>();

 

@SubscribeEvent

public void onEntityUpdate(PlayerTickEvent event) {

        if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;

        System.out.println("Equipment Stack "+getEquipmentInSlot(3).getItem());

        if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());

        System.out.println("Target Item"+BetterThings.GravityChestplate);

        if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

        System.out.println("event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate");

        if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate)

        if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate) {

String ownerName = event.player.getDisplayName();

playersWithFlight.put(event.player, true);

event.player.capabilities.allowFlying = true;

 

} else {

String ownerName = event.player.getDisplayName();

 

if (!playersWithFlight.containsKey(event.player)) {

playersWithFlight.put(event.player, false);

        }

 

if (playersWithFlight.get(event.player)) {

playersWithFlight.put(event.player, false);

 

if (!event.player.capabilities.isCreativeMode) {

event.player.capabilities.allowFlying = false;

event.player.capabilities.isFlying = false;

event.player.sendPlayerAbilities();

}

}

}

}

 

 

}

 

 

[brandon3055]

Ok thats a bit of a mess... Try this i think i fixed the null pointer and may have figured out why it isnt working.

 

package com.skullcrusher.BetterThings.eventhandlers;

import java.util.Map;
import java.util.WeakHashMap;

import com.skullcrusher.BetterThings.BetterThings;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import cpw.mods.fml.common.gameevent.TickEvent;
import cpw.mods.fml.common.gameevent.TickEvent.PlayerTickEvent;

public class ArmorEventHandler {
   public static Map<EntityPlayer, Boolean> playersWithFlight = new WeakHashMap<EntityPlayer, Boolean>();

   @SubscribeEvent
   public void onEntityUpdate(PlayerTickEvent event) {
           if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;
         
            System.out.println("Equipment Stack "+event.player.getEquipmentInSlot(3));
           if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
           System.out.println("Target Item "+BetterThings.GravityChestplate);

           System.out.println(event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate);


           if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate) {
         
         playersWithFlight.put(event.player, true);
         event.player.capabilities.allowFlying = true;

      } else {

         if (!playersWithFlight.containsKey(event.player)) {
            playersWithFlight.put(event.player, false);
              }

         if (playersWithFlight.get(event.player)) {
            playersWithFlight.put(event.player, false);

            if (!event.player.capabilities.isCreativeMode) {
               event.player.capabilities.allowFlying = false;
               event.player.capabilities.isFlying = false;
               event.player.sendPlayerAbilities();
            }
         }
      }
   }


}

 

[skullcrusher1005]

Oops another typo it should be event.player.getEquipmentInSlot(3) Didnt it give you an error on that line?

Yes, thats what was giving me the error fixed the error launching now.

[skullcrusher1005]

Ok thats a bit of a mess... Try this i think i fixed the null pointer and may have figured out why it isnt working.

 

package com.skullcrusher.BetterThings.eventhandlers;

import java.util.Map;
import java.util.WeakHashMap;

import com.skullcrusher.BetterThings.BetterThings;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import cpw.mods.fml.common.gameevent.TickEvent;
import cpw.mods.fml.common.gameevent.TickEvent.PlayerTickEvent;

public class ArmorEventHandler {
   public static Map<EntityPlayer, Boolean> playersWithFlight = new WeakHashMap<EntityPlayer, Boolean>();

   @SubscribeEvent
   public void onEntityUpdate(PlayerTickEvent event) {
           if (event.phase != TickEvent.Phase.START || event.player.worldObj.isRemote) return;
         
            System.out.println("Equipment Stack "+event.player.getEquipmentInSlot(3));
           if (event.player.getEquipmentInSlot(3) != null) System.out.println("Item "+event.player.getEquipmentInSlot(3).getItem());
           System.out.println("Target Item "+BetterThings.GravityChestplate);

           System.out.println(event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate);


           if (event.player.getEquipmentInSlot(3) != null && event.player.getEquipmentInSlot(3).getItem() == BetterThings.GravityChestplate) {
         
         playersWithFlight.put(event.player, true);
         event.player.capabilities.allowFlying = true;

      } else {

         if (!playersWithFlight.containsKey(event.player)) {
            playersWithFlight.put(event.player, false);
              }

         if (playersWithFlight.get(event.player)) {
            playersWithFlight.put(event.player, false);

            if (!event.player.capabilities.isCreativeMode) {
               event.player.capabilities.allowFlying = false;
               event.player.capabilities.isFlying = false;
               event.player.sendPlayerAbilities();
            }
         }
      }
   }


}

 

Ok it worked as we planned

When it was on:

Equipment Stack 1xitem.GravityChestplate@0

Item com.skullcrusher.BetterThings.Armor.GravityArmor@4aa33ead

Target Item com.skullcrusher.BetterThings.Armor.GravityArmor@4aa33ead

true

When it was off:

Equipment Stack null

Target Item com.skullcrusher.BetterThings.Armor.GravityArmor@4aa33ead

false

 

[brandon3055]

i think i see the problem can you please show me your moditems class (where you have you instance of GravityChestplate)

 

Edit:wait... i dont see the problem... that should work

[skullcrusher1005]

i think i see the problem can you please show me your moditems class (where you have you instance of GravityChestplate)

This is the whole gravity armor class

 

 

package com.skullcrusher.BetterThings.Armor;

 

import java.util.List;

import java.util.Map;

import java.util.WeakHashMap;

 

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemArmor;

import net.minecraft.item.ItemStack;

import net.minecraft.potion.Potion;

import net.minecraft.potion.PotionEffect;

import net.minecraft.util.DamageSource;

import net.minecraft.util.EnumChatFormatting;

import net.minecraft.util.MathHelper;

import net.minecraft.world.World;

import net.minecraftforge.common.ISpecialArmor.ArmorProperties;

 

import com.skullcrusher.BetterThings.BetterThings;

 

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

import cpw.mods.fml.common.gameevent.TickEvent;

import cpw.mods.fml.common.gameevent.TickEvent.PlayerTickEvent;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

 

 

public class GravityArmor extends ItemArmor

{

public GravityArmor(ArmorMaterial armormaterial, int renderID, int partID)

{

super(armormaterial, renderID, partID);

}

 

public String getArmorTexture(ItemStack itemstack, Entity entity, int slot, String layer)

{

if((itemstack.getItem() == BetterThings.GravityChestplate))

{

return "betterthings:textures/models/armor/8_layer_1.png";

}

else return null;

}

 

@SideOnly(Side.CLIENT)

public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean par4)

{

list.add(EnumChatFormatting.DARK_BLUE + "Indestructible");

}

}