Jump to content

[SOLVED][1.7.10]Projectile doesn't register hitting entities


blfngl

Recommended Posts

So I wrote a simple gun item, but a huge problem with it is that the bullet won't ever register hitting an entity. Hits blocks fine though. Help?

 

Code:

 

package blfngl.fallout.entity.projectile;

import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.projectile.EntityThrowable;
import net.minecraft.util.DamageSource;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.world.World;

public class EntityBullet extends EntityThrowable
{
public float damage;

public EntityBullet(World world, EntityLivingBase entity, float par1)
{
	super(world, entity);
	damage = par1;
}

@Override
protected void onImpact(MovingObjectPosition position)
{
	if (position.entityHit instanceof Entity)
	{
		EntityLiving entity = (EntityLiving) position.entityHit;
		//entity.setHealth(entity.getHealth() - damage);
		position.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), damage);
	}

	this.setDead();
}

@Override
protected float getGravityVelocity()
{
	return 0.0F;
}

private void setSpeed()
{
	setThrowableHeading(this.motionX, this.motionY, this.motionZ, 4.0F, 1.0F);
}
}

 

Link to comment
Share on other sites

First, if you are going to register your item, add a constructor that has only a World parameter.

Further, I have a strange thing that is a little bit the same as your problem.

In my code, the entity get attacked, but if the hit is an entity, it doesn't make a nice ball.

@Override
public void onImpact(MovingObjectPosition mop) {
	EnergyBall.makeBall(worldObj, posX, posY, posZ, 0.5, 1, 10, 5, 5000);
	if(mop.entityHit instanceof EntityLivingBase){
		EntityLivingBase entity = (EntityLivingBase) mop.entityHit;
		DamageSource source = new EntityDamageSourceIndirect("ice spell", this, getThrower());
		entity.attackEntityFrom(source, power);
		entity.addPotionEffect(new PotionEffect(2, (int) (20 * power), 1));
	}
	setDead();
}

 

I have never understanded it, but your problem is almost the same as mine.

Link to comment
Share on other sites

Hi

 

> the bullet won't ever register hitting an entity. Hits blocks fine though.

 

Do you mean - the bullet goes right through the block? or it just does no damage?

 

Have you tried placing a breakpoint in onImpact() on the first line and trying to hit an entity with the bullet?

 

-TGG

So I tried your breakpoint idea but it never "stopped" and the onImpact was simply never called, ever, even when it hit the ground.

 

I also added this line of code to test it in-game, but the explosion only occurred on the block behind the entity and the bullet kept traveling through entities.

this.worldObj.createExplosion(this, this.posX, this.posY, this.posZ, 1.0F, true);

 

I've also tried changing the instanceof to different classes, such as Entity, EntityLiving, EntityLivingBase, etc, but none seem to work. Pretty stumped with this one.

Link to comment
Share on other sites

Did you register your projectile using EntityRegistry#registerModEntity ?

 

Are you spawning the entity on the server?

 

Your Entity should have a constructor with a single World argument as well:

public YourEntity(World world {

super(world);

}

 

I had forgotten to register the entity :P

However, before I did this the entity would show up as a cube but now it just doesn't render at all.

 

I put the code here, in my client proxy:

package blfngl.fallout.proxy;

import net.minecraft.client.renderer.entity.RenderSnowball;
import blfngl.fallout.Fallout;
import blfngl.fallout.entity.projectile.EntityBullet;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class ClientProxy extends CommonProxy
{
@Override
@SideOnly(Side.CLIENT)
public void initRender()
{
	EntityRegistry.registerModEntity(EntityBullet.class, "Bullet", 0, Fallout.instance, 80, 1, true);
	RenderingRegistry.registerEntityRenderingHandler(EntityBullet.class, new RenderSnowball(Fallout.emptySyringe));
	LanguageRegistry.instance().addStringLocalization("entity.bullet.fallout.name", "fallout");
}
}

 

Link to comment
Share on other sites

You are registering your entity on the client side, that is not good.

Only rendering goes on client side, the other part should be server side.

I moved the registration to main init method but it didn't change anything.

 

Could it be my spawn code, as in I'm spawning it but not where I want it?

 

This is called when you right click:

world.spawnEntityInWorld(new EntityBullet(world, damage));

 

And this is the object code:

 

package blfngl.fallout.entity.projectile;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.projectile.EntityThrowable;
import net.minecraft.util.DamageSource;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.world.World;

public class EntityBullet extends EntityThrowable
{
public float damage;

public EntityBullet(World world, float par1)
{
	super(world);
	damage = par1;
	setSpeed();
}

@Override
protected void onImpact(MovingObjectPosition position)
{
	if (position.entityHit instanceof EntityLivingBase)
	{
		EntityLivingBase entity = (EntityLivingBase) position.entityHit;
		//entity.setHealth(entity.getHealth() - damage);
		position.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), damage);
	}

	this.worldObj.createExplosion(this, this.posX, this.posY, this.posZ, 1.0F, true);
	this.setDead();
}

@Override
protected float getGravityVelocity()
{
	return 0.0F;
}

private void setSpeed()
{
	setThrowableHeading(this.motionX, this.motionY, this.motionZ, 4.0F, 1.0F);
}
}

 

 

Once again, the problem is the entity is now no longer visible (used to render as a cube) and does not detect when it hits an entity.

Link to comment
Share on other sites

You must use the constructor (World, EntityLivingBase) or your entity will spawn at 0,0,0

Fixed the super so it included that param, *facepalm*

 

However, the bullet still doesn't collide with any entities, but it does render fine and the explosion occurs when it hits the ground.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.