Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.7.10] [SOLVED] ridingEntity and riddenByEntity return null

Rui

By Rui
in Modder Support

 Share

Recommended Posts

Rui Tree Puncher

Rui

Posted
Posted

Alright.. so... maybe this was a "duh" sort of thing, but originally I just had it so the player was passed into the method and not the pig (which was stored in a global). Upon passing the pig into the method, I was able to use setLocationAndAngles to correct the jittering. Hurrah!

 

The player still occasionally bobs, but I'm not sure if I can do much about that. Right now I have the position update alternating with a single sleep tick so the comp doesn't go nuts while updating.

 

------------ SOLVED -------------

 

I need to update the rider's position on my new model for the pig since it is no longer in the correct area, however...

 

Whenever I call ridingEntity or riddenByEntity, they both return null-- even while riding the entity. I have tried this with the EntityJoinWorldEvent for both the player and pig, as well as EntityInteractEvent for the player. For the EntityJoinWorldEvent I have tried it by mounting a pig, then restarting the game (so i  would be mounted when I joined), and for EntityInteractEvent I of course mounted the pig once it was saddled. For some reason when the player is the object of the event, the method gets called twice, but in any circumstance the values return null when they should be returning an entity.

 

I don't have any code yet, just a print statement to show me the result of ridingEntity/riddenByEntity in an EntityJoinWorldEvent. So, what's going on,  and how am I actually supposed to detect if a pig is being ridden or if a player is riding a pig?

Link to comment
Share on other sites
Rui Tree Puncher

Rui

Posted
  • Author
Posted

Okay, so I tested out a theory and it was right. I'm not sure why, but it takes the game a moment to set the ridingEntity and riddenByEntity variables. So I made a thread specifically to wait for this change.

 

With EntityPlayer as the parameter in EntityJoinWorldEvent it still gets called twice. Does anyone know why?

Link to comment
Share on other sites
Rui Tree Puncher

Rui

Posted
  • Author
Posted

Made the change to check for EntityPlayerMP instead of EntityPlayer. It cuts it down to one call, but is it an acceptable way of dealing with that problem?

 

Meanwhile, I'm having trouble actually updating the rider's position. Using setLocation and setLocationAndAngles don't seem to have any effect (other than making my computer's fans whirr). Not particularly happy about the position being coded in on the Player's side... who's wise idea was that? Anyway, if anyone can give me an idea for how to change the player's position, that would be great.

Link to comment
Share on other sites
SanAndreaP World Shaper

SanAndreaP

Posted
Posted

Those 2 calls you get is because of server and client. Just check for 

worldObj.isRemote == false

to make sure you're on the server.

 

To update the rider's position, override 

updateRiderPosition

and use 

this.riddenByEntity.setPosition(x, y, z)

. Make sure you do not check for the server here, you need to do that on both client and server or else it will stutter.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites
Rui Tree Puncher

Rui

Posted
  • Author
Posted

Those 2 calls you get is because of server and client. Just check for 

worldObj.isRemote == false

to make sure you're on the server.

 

To update the rider's position, override 

updateRiderPosition

and use 

this.riddenByEntity.setPosition(x, y, z)

. Make sure you do not check for the server here, you need to do that on both client and server or else it will stutter.

 

Ah, thank you for that first answer, I'll definitely change that.

 

I can't override updateRiderPosition though. I'm kind of hacking the original pig entity with events and such, so unfortunately method overriding is unavailable for me.

Link to comment
Share on other sites
larsgerrits Reality Controller

larsgerrits

Posted
Posted

While I'm at it, could someone tell me how to add mods to eclipse? I tried just shoving the mods into the "mods" folder, but it crashed because it couldn't find the appropriate classes.

That's because the standard mods are obuscated to work in a normal environment, and not in a dev-environment. To solve this, add CodeChickenCore to the mods folder, as it will runtime-deobfuscate the mods so they can work in a dev-environment.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites
Rui Tree Puncher

Rui

Posted
  • Author
Posted

Excellent, thank you!

 

Well, with some more testing I found that the position of the player DOES change... but the render doesn't. I don't... <i>why doesn't the render update to reflect the position</i>.

 

Guess that means I'll have to do it myself. Um... any ideas?

Link to comment
Share on other sites
Rui Tree Puncher

Rui

Posted
  • Author
Posted

Alright, I'm an idiot. Of course you don't put a check for the server, because then the client has no idea that you've moved. A hurr durr.

 

New problem: For some reason if you enter the world already mounted on a pig, the pig refuses to move. It can turn, but not move. Otherwise, when you mount a pig the pig's body jerks awkwardly as it moves. I tried doing setLocationAndAngles() for the pig, but then the render wouldn't update to reflect the pig's movement and yaw/pitch.

 

Relevant class: http://pastebin.com/q3aNZ5wq

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • DroidCrafter23
      How do I make a drink item?

      By DroidCrafter23 · Posted

      I have done this now but have got the error:   'food(net.minecraft.world.food.FoodProperties)' in 'net.minecraft.world.item.Item.Properties' cannot be applied to                '(net.minecraftforge.registries.RegistryObject<net.minecraft.world.item.Item>)' public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register( "lemon_juice", () -> new Item( new HoneyBottleItem.Properties().stacksTo(1).food( (new FoodProperties.Builder()) .nutrition(3) .saturationMod(0.25F) .effect(() -> new MobEffectInstance(MobEffects.DAMAGE_RESISTANCE, 1500), 0.01f ) .build() ) )); The code above is from the ModFoods class, the one below from the ModItems class. public static final RegistryObject<Item> LEMON_JUICE = ITEMS.register("lemon_juice", () -> new Item(new Item.Properties().food(ModFoods.LEMON_JUICE)));   I shall keep going between them to try and figure out the cause. I am sorry if this is too much for you to help with, though I thank you greatly for your patience and all the effort you have put in to help me.
    • DroidCrafter23
      How do I make a drink item?

      By DroidCrafter23 · Posted

      I have been following these exact tutorials for quite a while, I must agree that they are amazing and easy to follow. I have registered the item in the ModFoods class, I tried to do it in ModItems (Where all the items should be registered) but got errors, I think I may need to revert this and figure it out from there. Once again, thank you for your help! 👍 Just looking back, I have noticed in your code you added ITEMS.register, which I am guessing means that they are being registered in ModFoods, I shall go through the process of trial and error to figure this out.
    • Orladodgreat
      𓅓+2349027025197𓅓 I WANT TO JOIN SECRET SOCIETY FOR MONEY RITUAL {¶}

      By Orladodgreat · Posted

      ♈+2349027025197ஜ Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join a brotherhood for protection and wealth here’s is your opportunity, but you should know there’s no ritual without repercussions but with the right guidance and support from this great temple your destiny is certain to be changed for the better and equally protected depending if you’re destined for greatness Call now for enquiry +2349027025197☎+2349027025197₩™ I want to join ILLUMINATI occult without human sacrificeGREATORLDRADO BROTHERHOOD OCCULT , Is The Club of the Riches and Famous; is the world oldest and largest fraternity made up of 3 Millions Members. We are one Family under one father who is the Supreme Being. In Greatorldrado BROTHERHOOD we believe that we were born in paradise and no member should struggle in this world. Hence all our new members are given Money Rewards once they join in order to upgrade their lifestyle.; interested viewers should contact us; on. +2349027025197 ۝ஐℰ+2349027025197 ₩Greatorldrado BROTHERHOOD OCCULT IS A SACRED FRATERNITY WITH A GRAND LODGE TEMPLE SITUATED IN G.R.A PHASE 1 PORT HARCOURT NIGERIA, OUR NUMBER ONE OBLIGATION IS TO MAKE EVERY INITIATE MEMBER HERE RICH AND FAMOUS IN OTHER RISE THE POWERS OF GUARDIANS OF AGE+. +2349027025197   SEARCHING ON HOW TO JOIN THE Greatorldrado BROTHERHOOD MONEY RITUAL OCCULT IS NOT THE PROBLEM BUT MAKE SURE YOU'VE THOUGHT ABOUT IT VERY WELL BEFORE REACHING US HERE BECAUSE NOT EVERYONE HAS THE HEART TO DO WHAT IT TAKES TO BECOME ONE OF US HERE, BUT IF YOU THINK YOU'RE SERIOUS MINDED AND READY TO RUN THE SPIRITUAL RACE OF LIFE IN OTHER TO ACQUIRE ALL YOU NEED HERE ON EARTH CONTACT SPIRITUAL GRANDMASTER NOW FOR INQUIRY +2349027025197   +2349027025197 Are you a pastor, business man or woman, politician, civil engineer, civil servant, security officer, entrepreneur, Job seeker, poor or rich Seeking how to join
    • KeBaB95
      Mod Pack hooror

      By KeBaB95 · Posted

      hi bitch
    • ANtonYL
      Caused by: java.lang.IllegalStateException: Duplicate recipe compressed:compressed_diamond

      By ANtonYL · Posted

      Hi, I'm trying to use datagen to create json files in my own mod. This is my ModRecipeProvider class. public class ModRecipeProvider extends RecipeProvider implements IConditionBuilder { public ModRecipeProvider(PackOutput pOutput) { super(pOutput); } @Override protected void buildRecipes(Consumer<FinishedRecipe> pWriter) { ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', ModItems.COMPRESSED_DIAMOND.get()) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); ShapelessRecipeBuilder.shapeless(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get(),9) .requires(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()) .unlockedBy(getHasName(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get()), has(ModBlocks.COMPRESSED_DIAMOND_BLOCK.get())) .save(pWriter); ShapedRecipeBuilder.shaped(RecipeCategory.MISC, ModItems.COMPRESSED_DIAMOND.get()) .pattern("SSS") .pattern("SSS") .pattern("SSS") .define('S', Blocks.DIAMOND_BLOCK) .unlockedBy(getHasName(ModItems.COMPRESSED_DIAMOND.get()), has(ModItems.COMPRESSED_DIAMOND.get())) .save(pWriter); } } When I try to run the runData client, it shows an error:  Caused by: java.lang.IllegalStateException: Duplicate recipe compressed:compressed_diamond I know that it's caused by the fact that there are two recipes for the ModItems.COMPRESSED_DIAMOND. But I need both of these recipes, because I need a way to craft ModItems.COMPRESSED_DIAMOND_BLOCK and restore 9 diamond blocks from ModItems.COMPRESSED_DIAMOND. Is there a way to solve this?

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept