Jump to content

Trying to regenerate chunks


McJty

Recommended Posts

Hi, I'm trying to regenerate chunks from within Minecraft. I looked at ICBM source code for the rejuvenation bomb as well as the MCEdit mod which can regenerate chunks. Here is the adapted ICBM code:

 

    public static void refreshChunksBAD2(World world) {
        try {
            ChunkProviderServer chunkServer = (ChunkProviderServer) world.getChunkProvider();

            List<ChunkCoordIntPair> toUnload = new ArrayList<ChunkCoordIntPair>();
            for (Object obj : chunkServer.loadedChunks) {
                Chunk chunk = (Chunk) obj;
                toUnload.add(chunk.getChunkCoordIntPair());
            }

            for (ChunkCoordIntPair pair : toUnload) {
                Chunk oldChunk = world.getChunkFromChunkCoords(pair.chunkXPos, pair.chunkZPos);
                WorldServer worldServer = (WorldServer) world;
                ChunkProviderServer chunkProviderServer = worldServer.theChunkProviderServer;
//                IChunkProvider chunkProviderGenerate = ObfuscationReflectionHelper.getPrivateValue(ChunkProviderServer.class, chunkProviderServer, "d", "field_73246_d");
                IChunkProvider chunkProviderGenerate = chunkProviderServer.currentChunkProvider;

                Chunk newChunk = chunkProviderGenerate.provideChunk(oldChunk.xPosition, oldChunk.zPosition);

                for (int x = 0; x < 16; x++) {
                    for (int z = 0; z < 16; z++) {
                        for (int y = 0; y < world.getHeight(); y++) {
                            Block blockID = newChunk.getBlock(x, y, z);
                            int metadata = newChunk.getBlockMetadata(x, y, z);
                            worldServer.setBlock(x + oldChunk.xPosition * 16, y, z + oldChunk.zPosition * 16, blockID, metadata, 2);
                            TileEntity tileEntity = newChunk.getTileEntityUnsafe(x, y, z);
                            if (tileEntity != null) {
                                worldServer.setTileEntity(x + oldChunk.xPosition * 16, y, z + oldChunk.zPosition * 16, tileEntity);
                            }
                        }
                    }
                }

                oldChunk.isTerrainPopulated = false;
                chunkProviderGenerate.populate(chunkProviderGenerate, oldChunk.xPosition, oldChunk.zPosition);
            }
        } catch (Exception e) {
            RFTools.logError("Failed to regenerate chunks!");
            e.printStackTrace();
        }
    }

 

and here is the adapted MCEdit code:

 

    public static void refreshChunksBad(World world) {
        try {
            ChunkProviderServer chunkServer = (ChunkProviderServer) world.getChunkProvider();

            Field u;
            try {
                u = ChunkProviderServer.class.getDeclaredField("field_73248_b"); // chunksToUnload
            } catch(NoSuchFieldException e) {
                u = ChunkProviderServer.class.getDeclaredField("chunksToUnload");
            }
            u.setAccessible(true);
            Set<?> unloadQueue = (Set<?>) u.get(chunkServer);

            Field m;
            try {
                m = ChunkProviderServer.class.getDeclaredField("field_73244_f"); // loadedChunkHashMap
            } catch(NoSuchFieldException e) {
                m = ChunkProviderServer.class.getDeclaredField("loadedChunkHashMap");
            }
            m.setAccessible(true);
            LongHashMap loadedMap = (LongHashMap) m.get(chunkServer);

            Field lc;
            try {
                lc = ChunkProviderServer.class.getDeclaredField("field_73245_g"); // loadedChunkHashMap
            } catch(NoSuchFieldException e) {
                lc = ChunkProviderServer.class.getDeclaredField("loadedChunks");
            }
            lc.setAccessible(true);
            @SuppressWarnings("unchecked") List<Chunk> loaded = (List<Chunk>) lc.get(chunkServer);

            Field p;
            try {
                p = ChunkProviderServer.class.getDeclaredField("field_73246_d"); // currentChunkProvider
            } catch(NoSuchFieldException e) {
                p = ChunkProviderServer.class.getDeclaredField("currentChunkProvider");
            }
            p.setAccessible(true);
            IChunkProvider chunkProvider = (IChunkProvider) p.get(chunkServer);

            List<ChunkCoordIntPair> toUnload = new ArrayList<ChunkCoordIntPair>();
            for (Object obj : chunkServer.loadedChunks) {
                Chunk chunk = (Chunk) obj;
                toUnload.add(chunk.getChunkCoordIntPair());
            }

            for (ChunkCoordIntPair pair : toUnload) {
                int x = pair.chunkXPos;
                int z = pair.chunkZPos;
                long pos = ChunkCoordIntPair.chunkXZ2Int(x, z);
                Chunk chunk;
                if (chunkServer.chunkExists(x, z)) {
                    chunk = chunkServer.loadChunk(x, z);
                    chunk.onChunkUnload();
                }
                unloadQueue.remove(pos);
                loadedMap.remove(pos);
                chunk = chunkProvider.provideChunk(x, z);
                loadedMap.add(pos, chunk);
                loaded.add(chunk);
                if (chunk != null) {
                    chunk.onChunkLoad();
                    chunk.populateChunk(chunkProvider, chunkProvider, x, z);
                }
            }
        } catch (Exception e) {
            RFTools.logError("Failed to regenerate chunks!");
            e.printStackTrace();
        }
    }

 

Both crash with exactly the same problem inside populateChunk() (showing the ICBM version crash log):

 

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:461]: net.minecraft.util.ReportedException: Exception getting block type in world

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.World.getBlock(World.java:396)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.gen.feature.WorldGenMinable.generate(WorldGenMinable.java:77)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.genStandardOre1(BiomeDecorator.java:369)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.generateOres(BiomeDecorator.java:394)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.genDecorations(BiomeDecorator.java:154)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.decorateChunk(BiomeDecorator.java:145)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeGenBase.decorate(BiomeGenBase.java:412)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.gen.ChunkProviderGenerate.populate(ChunkProviderGenerate.java:444)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.dimension.world.WorldRefresher.refreshChunks(WorldRefresher.java:54)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.commands.CmdRefreshWorld.execute(CmdRefreshWorld.java:24)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.commands.DefaultCommand.processCommand(DefaultCommand.java:77)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.command.CommandHandler.executeCommand(CommandHandler.java:96)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetHandlerPlayServer.handleSlashCommand(NetHandlerPlayServer.java:788)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetHandlerPlayServer.processChatMessage(NetHandlerPlayServer.java:764)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.play.client.C01PacketChatMessage.processPacket(C01PacketChatMessage.java:47)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.play.client.C01PacketChatMessage.processPacket(C01PacketChatMessage.java:68)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:488]: Caused by: java.lang.RuntimeException: Already decorating!!

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.biome.BiomeDecorator.decorateChunk(BiomeDecorator.java:137)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.biome.BiomeGenBase.decorate(BiomeGenBase.java:412)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderGenerate.populate(ChunkProviderGenerate.java:444)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.populate(ChunkProviderServer.java:313)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.chunk.Chunk.populateChunk(Chunk.java:1157)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:144)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:119)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.provideChunk(ChunkProviderServer.java:221)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.World.getChunkFromChunkCoords(World.java:482)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.World.getBlock(World.java:387)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:492]: ... 22 more

 

Any idea how I can fix this?

 

It says 'Already decorating!' which is a bit strange. It appears to recurse into the decorating stuff.

 

If refreshing chunks like this fails I'm also happy with a method that simply cleans out the current dimension so that it gets regenerated again. I need this to test dimension changes faster.

 

Thanks,

 

 

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.