Jump to content

Recommended Posts

Posted

Hi, I'm trying to regenerate chunks from within Minecraft. I looked at ICBM source code for the rejuvenation bomb as well as the MCEdit mod which can regenerate chunks. Here is the adapted ICBM code:

 

    public static void refreshChunksBAD2(World world) {
        try {
            ChunkProviderServer chunkServer = (ChunkProviderServer) world.getChunkProvider();

            List<ChunkCoordIntPair> toUnload = new ArrayList<ChunkCoordIntPair>();
            for (Object obj : chunkServer.loadedChunks) {
                Chunk chunk = (Chunk) obj;
                toUnload.add(chunk.getChunkCoordIntPair());
            }

            for (ChunkCoordIntPair pair : toUnload) {
                Chunk oldChunk = world.getChunkFromChunkCoords(pair.chunkXPos, pair.chunkZPos);
                WorldServer worldServer = (WorldServer) world;
                ChunkProviderServer chunkProviderServer = worldServer.theChunkProviderServer;
//                IChunkProvider chunkProviderGenerate = ObfuscationReflectionHelper.getPrivateValue(ChunkProviderServer.class, chunkProviderServer, "d", "field_73246_d");
                IChunkProvider chunkProviderGenerate = chunkProviderServer.currentChunkProvider;

                Chunk newChunk = chunkProviderGenerate.provideChunk(oldChunk.xPosition, oldChunk.zPosition);

                for (int x = 0; x < 16; x++) {
                    for (int z = 0; z < 16; z++) {
                        for (int y = 0; y < world.getHeight(); y++) {
                            Block blockID = newChunk.getBlock(x, y, z);
                            int metadata = newChunk.getBlockMetadata(x, y, z);
                            worldServer.setBlock(x + oldChunk.xPosition * 16, y, z + oldChunk.zPosition * 16, blockID, metadata, 2);
                            TileEntity tileEntity = newChunk.getTileEntityUnsafe(x, y, z);
                            if (tileEntity != null) {
                                worldServer.setTileEntity(x + oldChunk.xPosition * 16, y, z + oldChunk.zPosition * 16, tileEntity);
                            }
                        }
                    }
                }

                oldChunk.isTerrainPopulated = false;
                chunkProviderGenerate.populate(chunkProviderGenerate, oldChunk.xPosition, oldChunk.zPosition);
            }
        } catch (Exception e) {
            RFTools.logError("Failed to regenerate chunks!");
            e.printStackTrace();
        }
    }

 

and here is the adapted MCEdit code:

 

    public static void refreshChunksBad(World world) {
        try {
            ChunkProviderServer chunkServer = (ChunkProviderServer) world.getChunkProvider();

            Field u;
            try {
                u = ChunkProviderServer.class.getDeclaredField("field_73248_b"); // chunksToUnload
            } catch(NoSuchFieldException e) {
                u = ChunkProviderServer.class.getDeclaredField("chunksToUnload");
            }
            u.setAccessible(true);
            Set<?> unloadQueue = (Set<?>) u.get(chunkServer);

            Field m;
            try {
                m = ChunkProviderServer.class.getDeclaredField("field_73244_f"); // loadedChunkHashMap
            } catch(NoSuchFieldException e) {
                m = ChunkProviderServer.class.getDeclaredField("loadedChunkHashMap");
            }
            m.setAccessible(true);
            LongHashMap loadedMap = (LongHashMap) m.get(chunkServer);

            Field lc;
            try {
                lc = ChunkProviderServer.class.getDeclaredField("field_73245_g"); // loadedChunkHashMap
            } catch(NoSuchFieldException e) {
                lc = ChunkProviderServer.class.getDeclaredField("loadedChunks");
            }
            lc.setAccessible(true);
            @SuppressWarnings("unchecked") List<Chunk> loaded = (List<Chunk>) lc.get(chunkServer);

            Field p;
            try {
                p = ChunkProviderServer.class.getDeclaredField("field_73246_d"); // currentChunkProvider
            } catch(NoSuchFieldException e) {
                p = ChunkProviderServer.class.getDeclaredField("currentChunkProvider");
            }
            p.setAccessible(true);
            IChunkProvider chunkProvider = (IChunkProvider) p.get(chunkServer);

            List<ChunkCoordIntPair> toUnload = new ArrayList<ChunkCoordIntPair>();
            for (Object obj : chunkServer.loadedChunks) {
                Chunk chunk = (Chunk) obj;
                toUnload.add(chunk.getChunkCoordIntPair());
            }

            for (ChunkCoordIntPair pair : toUnload) {
                int x = pair.chunkXPos;
                int z = pair.chunkZPos;
                long pos = ChunkCoordIntPair.chunkXZ2Int(x, z);
                Chunk chunk;
                if (chunkServer.chunkExists(x, z)) {
                    chunk = chunkServer.loadChunk(x, z);
                    chunk.onChunkUnload();
                }
                unloadQueue.remove(pos);
                loadedMap.remove(pos);
                chunk = chunkProvider.provideChunk(x, z);
                loadedMap.add(pos, chunk);
                loaded.add(chunk);
                if (chunk != null) {
                    chunk.onChunkLoad();
                    chunk.populateChunk(chunkProvider, chunkProvider, x, z);
                }
            }
        } catch (Exception e) {
            RFTools.logError("Failed to regenerate chunks!");
            e.printStackTrace();
        }
    }

 

Both crash with exactly the same problem inside populateChunk() (showing the ICBM version crash log):

 

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:461]: net.minecraft.util.ReportedException: Exception getting block type in world

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.World.getBlock(World.java:396)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.gen.feature.WorldGenMinable.generate(WorldGenMinable.java:77)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.genStandardOre1(BiomeDecorator.java:369)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.generateOres(BiomeDecorator.java:394)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.genDecorations(BiomeDecorator.java:154)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeDecorator.decorateChunk(BiomeDecorator.java:145)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.biome.BiomeGenBase.decorate(BiomeGenBase.java:412)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.world.gen.ChunkProviderGenerate.populate(ChunkProviderGenerate.java:444)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.dimension.world.WorldRefresher.refreshChunks(WorldRefresher.java:54)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.commands.CmdRefreshWorld.execute(CmdRefreshWorld.java:24)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at com.mcjty.rftools.commands.DefaultCommand.processCommand(DefaultCommand.java:77)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.command.CommandHandler.executeCommand(CommandHandler.java:96)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetHandlerPlayServer.handleSlashCommand(NetHandlerPlayServer.java:788)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetHandlerPlayServer.processChatMessage(NetHandlerPlayServer.java:764)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.play.client.C01PacketChatMessage.processPacket(C01PacketChatMessage.java:47)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.play.client.C01PacketChatMessage.processPacket(C01PacketChatMessage.java:68)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:464]: at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:488]: Caused by: java.lang.RuntimeException: Already decorating!!

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.biome.BiomeDecorator.decorateChunk(BiomeDecorator.java:137)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.biome.BiomeGenBase.decorate(BiomeGenBase.java:412)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderGenerate.populate(ChunkProviderGenerate.java:444)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.populate(ChunkProviderServer.java:313)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.chunk.Chunk.populateChunk(Chunk.java:1157)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:144)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:119)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.gen.ChunkProviderServer.provideChunk(ChunkProviderServer.java:221)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.World.getChunkFromChunkCoords(World.java:482)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:490]: at net.minecraft.world.World.getBlock(World.java:387)

[13:52:34] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTraceAsCause:492]: ... 22 more

 

Any idea how I can fix this?

 

It says 'Already decorating!' which is a bit strange. It appears to recurse into the decorating stuff.

 

If refreshing chunks like this fails I'm also happy with a method that simply cleans out the current dimension so that it gets regenerated again. I need this to test dimension changes faster.

 

Thanks,

 

 

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to create block with entity, that will have height of 3 or more(configurable) and I tried to change first VoxelShape by increasing collision box on height I want and for changing block height on visual side i tried to configure BlockModelBuilder:  base.element() .from(0, 0, 0) .to(16f, 48f, 16f) .face(Direction.UP).texture("#top").end() .face(Direction.DOWN).texture("#bottom").end() .face(Direction.NORTH).texture("#side").end() .face(Direction.SOUTH).texture("#side").end() .face(Direction.WEST).texture("#side").end() .face(Direction.EAST).texture("#side").end() .end(); but, getting crash with next error: Position y out of range, must be within [-16, 32]. Found: %d [48.0]; Looks like game wont to block height modified by more than 32. Is there any way to fix that problem?
    • As long as the packets you are sending aren't lost, there's nothing wrong with what you're currently doing. Although, this sounds like something that would benefit from you making your own datapack registry instead of trying to arbitrarily sync static maps. Check out `DataPackRegistryEvent.NewRegistry`.
    • Hey all, I've been working a lot with datapacks lately, and I'm wondering what the most efficient way to get said data from server to client is.  I'm currently using packets, but given that a lot of the data I'm storing involves maps along the lines of Map<ResourceLocation, CustomDataType>, it can easily start to get messy if I need to transmit a lot of that data all at once. Recently I started looking into the ReloadableServerResources class, which is where Minecraft stores its built-ins.  I see you can access it via the server from the server's resources.managers, and it seems like this can be done even from the client to appropriately retrieve data from the server, unless I'm misunderstanding.  However, from what I can tell, this only works via built-in methods such as getRecipeManager() or getLootTables(), etc.  These are all SimpleJsonResourceReloadListeners, just like my datapack entries are, so it seems like it could be possible for me to access my datapack entries similarly?  But I don't see anywhere in ReloadableServerResources that stores loaded modded entries, so either I'm looking in the wrong place or it doesn't seem to be a thing. Are packets really the best way of doing this, or am I missing a method that would let me use ReloadableServerResources or something similar?
    • Hi, everyone! I'm new to minecraft modding stuff and want ask you some questions. 1. I checked forge references and saw there com.mojang and net.minecraft (not net.minecraftforge) and as I understand it's original game packages with all minecraft logic inside including renderers and so on, right? 2. Does it mean that forge has a limited set of instruments which doesn't cover all the aspects of the game? If make my question more specific then does forge provide such instruments that allow me totally change minecraft itself, like base mechanics and etc.? Or I have to use "original game packages" to implement such things? 3. I actively learning basic concepts with forge documentation and tutorials. So in my plans make different inventory system like in diabloids. Is that possible with forge? 4. It is last question related to the second one. So how deeply I can change minecraft with forge? I guess all my questions above because of that I haven't globally understanding what forge is and how it works inside and how it works with minecraft. It would be great if you provide some links or topics about it or explain it by yourself but I guess it's to big to be explained in that post at once. Anyway, thank you all for any help!
    • Im trying add to block a hole in center, just a usual block and in center of it on up side, there is should be a hole. I tried to add it via BlockModelBuilder, but its not working. Problem is that it only can change block size outside. I tried it to do with VoxelShape and its working, but its has been on server side and looks like its just changed collision shape, but for client, there is a texture covering this hole. I tried to use: base.renderType("cutout"); and removed some pixels from texture. I thought its should work, but game optimization makes block inside looks transparent. So, only custom model?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.