Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.7.10] Spawn custom mob in all biomes


AlekBardzo
 Share

Recommended Posts

Ok, so as You probably noticed already, learing Forge makes a man bang his head against the wall quite often. To spare You that, I decided do describe what I found. I know one might find the answer through search on this humble forum, but if I had this problem, I'd rather find it in a nice single post detailing that particular situation.

 

And the issue is :

"I made a custom mode with a tutorial, and I want it to spawn in custom and moded biomes"

 

Presented solution works for 1.7.10 (yay, no erratas for 1.6.4/1.7.2 upgrades !) :

 

Go to the place in Your code where You register Your mob, like :

EntityRegistry.addSpawn(BrigandEntity.class, spawnRate, 2, 4, EnumCreatureType.monster, this.all_biomes);

 

All tutorials I've seen ask You to provide BiomeGenBase.SOMETHING as the last parameter of .addSpawn() , You may however pass an array of BiomeGenBase objects. It is important for this to be an array, not a ArrayList. You need to prepare it before, the solution that I've found to work :

ArrayList<BiomeGenBase> all_biomesList = new ArrayList<BiomeGenBase>();
	for( BiomeGenBase biome : BiomeGenBase.getBiomeGenArray() ) {
		if( biome != null ) {
			all_biomesList.add(biome);
			// here You may filter biomes which are You like by their properties and insert them in separate ArrayLists
		}
	}
	BiomeGenBase[] all_biomes_array = new BiomeGenBase[all_biomesList.size()]; // type casting from List to array
	all_biomes = all_biomesList.toArray(all_biomes_array);

and "all_biomes" will be Your passable array.

 

Mind You, You may further filter biomes within "if" loop, in order to create more specyfic list of biomes, and than convert it to array as well.

 

TIP: in earlier versions, field BiomeGenBase.biomesList was public, as of 1.7.10 it is not, it can be fetched with BiomeGenBase.getBiomeGenArray().

 

A living, breathing example (I sure love those in tutorials) :

public void register(int banditRate, int brigandRate, int tribesmanRate){	
	// prepare biomes lists
	// ArrayList<BiomeGenBase> all_biomesList = new ArrayList<BiomeGenBase>();
	ArrayList<BiomeGenBase> cold_biomesList = new ArrayList<BiomeGenBase>();
	ArrayList<BiomeGenBase> warmAndMedium_biomesList = new ArrayList<BiomeGenBase>();
	for( BiomeGenBase biome : BiomeGenBase.getBiomeGenArray() ) {
		if( biome != null ) {
			//all_biomesList.add(biome);					
			if(
					biome.getIntRainfall()>8000 && 
					biome.getTempCategory()!=TempCategory.OCEAN &&
					biome.heightVariation<0.5F){
				// hospitable biomes only
				if(biome.getTempCategory()==TempCategory.COLD){
					// cold biomes
					cold_biomesList.add(biome);
				}else{
					// medium and warm biomes
					warmAndMedium_biomesList.add(biome);
				}
			}
		}
	}
	//BiomeGenBase[] all_biomes_array = new BiomeGenBase[all_biomesList.size()]; // type casting from List to array and stuff
	//all_biomes = all_biomesList.toArray(all_biomes_array);

	BiomeGenBase[] cold_biomes_array = new BiomeGenBase[cold_biomesList.size()];		
	BiomeGenBase[] warmAndMedium_biomes_array = new BiomeGenBase[warmAndMedium_biomesList.size()];

	this.registerBrigand(brigandRate,warmAndMedium_biomesList.toArray(warmAndMedium_biomes_array));
	this.registerBandit(banditRate,warmAndMedium_biomesList.toArray(warmAndMedium_biomes_array));
	this.registerTribesman(tribesmanRate,cold_biomesList.toArray(cold_biomes_array));
}

 

EDIT:

Or... if You may acomplish the same quicker by using BiomeDictionary, like that :

// prepare biomes
	BiomeGenBase[] biomes = new BiomeGenBase[0];
	biomes = ArrayUtils.addAll(biomes, BiomeDictionary.getBiomesForType(Type.DENSE));
	biomes = ArrayUtils.addAll(biomes, BiomeDictionary.getBiomesForType(Type.FOREST));
	biomes = ArrayUtils.addAll(biomes, BiomeDictionary.getBiomesForType(Type.RIVER));
	EntityRegistry.addSpawn(BanditEntity.class, spawnRate, 2, 4, EnumCreatureType.monster, biomes);	

Link to comment
Share on other sites

I approved this for now, but please clean it up a bit.

Don't store the array in a field in your Mod it only takes up unnecessary memory.

Also: Take into consideration it might not always be desired to make your mob spawn literally everywhere. The BiomeDictionary allows you to get all biomes with a certain tag, which sounds more like what you want (You don't want your mob in the nether for example, do you?).

Link to comment
Share on other sites

Yay, approved, so perhaps me be bit smart, ya ? ;)

 

As for the stored array, I don't know much about Java, so it never occured to me that might be wasting memory, lesson learned, thanks :D

 

Wow, I was not even aware that BiomeDictionary even existed, its kinda awesome. It does make my method kinda pointless by rendering it obsolete though.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Thanks for your reply! I have done it using data generation now. It works well for world generation, and I have realised that I don't care about saplings, so it works well. For anyone looking to do something similar, I include files to show what I did. They are just a bit hacky and incomplete now, but they can probably easily be generalised.   import static net.anju.larus.data.ResourceLocationUtil.prefix; import static net.anju.larus.data.ResourceLocationUtil.slash; @MethodsReturnNonnullByDefault @ParametersAreNonnullByDefault public abstract class LarusFeatureProvider<T> implements DataProvider { private static final Gson GSON = new GsonBuilder().setPrettyPrinting().disableHtmlEscaping().create(); protected final Set<FeatureEntry> featureEntries = new HashSet<>(); private final DataGenerator generator; protected LarusFeatureProvider(DataGenerator generator, Registry<T> registry) { this.generator = generator; for (Map.Entry<ResourceKey<T>, T> entry : registry.entrySet()) { ResourceKey<T> key = entry.getKey(); T feature = entry.getValue(); JsonElement jsonElement = getJson(feature); if (jsonElement != null) { FeatureEntry featureEntry = new FeatureEntry(prefix(key.location(), key.getRegistryName()), jsonElement); featureEntries.add(featureEntry); } } } private void addFeatures() { for (FeatureEntry featureEntry : featureEntries) { modifyFeatureEntry(featureEntry); } } protected abstract void modifyFeatureEntry(FeatureEntry featureEntry); @Override public void run(HashCache cache) { addFeatures(); writeFiles(cache, this.generator.getOutputFolder(), featureEntries); } // Actually write out the tables in the output folder private static void writeFiles(HashCache cache, Path outputFolder, Set<FeatureEntry> featureEntries) { for (FeatureEntry featureEntry : featureEntries) { if (featureEntry.isModified()) { ResourceLocation key = featureEntry.resourceLocation; JsonElement jsonElement = featureEntry.jsonElement; Path path = getPath(outputFolder, key); try { DataProvider.save(GSON, cache, jsonElement, path); } catch (IOException e) { LarusMod.LOGGER.error("Couldn't write data {}", key, e); } } } } @Override public String getName() { return "Larus features"; } @Nullable public JsonElement getJson(T feature) { if (feature instanceof ConfiguredFeature<?, ?> configuredFeature) { Optional<JsonElement> optional = ConfiguredFeature.DIRECT_CODEC.encodeStart(JsonOps.INSTANCE, configuredFeature).result(); return optional.orElse(null); } return null; } public static Path getPath(Path outputFolder, ResourceLocation key) { return outputFolder.resolve("data/" + slash(key) + ".json"); } protected static class FeatureEntry { boolean modified = false; private final ResourceLocation resourceLocation; private final JsonElement jsonElement; private FeatureEntry(ResourceLocation resourceLocation, JsonElement jsonElement) { this.resourceLocation = resourceLocation; this.jsonElement = jsonElement; } public JsonElement getJsonElement() { return jsonElement; } protected void markModified() { this.modified = true; } private boolean isModified() { return this.modified; } } } public class LarusLeavesFeatureProvider extends LarusFeatureProvider<ConfiguredFeature<?, ?>> { public LarusLeavesFeatureProvider(DataGenerator generator) { super(generator, BuiltinRegistries.CONFIGURED_FEATURE); } @Override protected void modifyFeatureEntry(FeatureEntry featureEntry) { JsonElement jsonElement = featureEntry.getJsonElement(); if (jsonElement.isJsonObject()) { JsonObject jsonObject = jsonElement.getAsJsonObject(); if (jsonObject.has("config")) { JsonObject config = jsonObject.get("config").getAsJsonObject(); if (config.has("foliage_provider")) { JsonObject mcFoliage = config.get("foliage_provider").getAsJsonObject(); JsonObject larusFoliage = larusFoliage(mcFoliage); if (larusFoliage != null) { config.add("foliage_provider", larusFoliage); featureEntry.markModified(); } } } } } @Nullable protected JsonObject larusFoliage(JsonObject mcFoliage) { JsonElement type = mcFoliage.get("type"); if (type.getAsString().equals("minecraft:simple_state_provider")) { JsonObject state = mcFoliage.get("state").getAsJsonObject(); // Change leaves String mcLeaves = state.get("Name").getAsString(); LarusLeavesBlock larusLeavesBlock = larusLeavesBlock(mcLeaves); if (larusLeavesBlock == null || larusLeavesBlock.getRegistryName() == null) return null; String larusLeaves = larusLeavesBlock.getRegistryName().toString(); state.add("Name", new JsonPrimitive(larusLeaves)); // Transform properties JsonObject mcProperties = state.get("Properties").getAsJsonObject(); transformProperties(mcProperties, larusLeavesBlock); } else { LarusMod.LOGGER.warn("Unexpected type for MC foliage " + mcFoliage); } return mcFoliage; } protected void transformProperties(JsonObject properties, LarusLeavesBlock larusLeavesBlock) { if (larusLeavesBlock instanceof LarusDeciduousLeavesBlock) properties.add("leafy", new JsonPrimitive("green")); } @Nullable protected LarusLeavesBlock larusLeavesBlock(String mcLeaves) { switch (mcLeaves) { case "minecraft:oak_leaves" -> { return LarusBlocks.OAK_LEAVES.get(); } case "minecraft:birch_leaves" -> { return LarusBlocks.BIRCH_LEAVES.get(); } case "minecraft:acacia_leaves" -> { return LarusBlocks.ACACIA_LEAVES.get(); } case "minecraft:jungle_leaves" -> { return LarusBlocks.JUNGLE_LEAVES.get(); } case "minecraft:dark_oak_leaves" -> { return LarusBlocks.DARK_OAK_LEAVES.get(); } case "minecraft:spruce_leaves" -> { return LarusBlocks.SPRUCE_LEAVES.get(); } } return null; } }  
    • the reason for that is the PlayerModel positions and rotations are set after the RenderPlayerEvent.Pre is fired change to Event to RenderPlayerEvent.Post
    • you can use BiomeLoadingEvent, loop through the Features you get from the Event and remove the Feature if it's the AmethystGeode Feature
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.