Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.7.10] Code running multiple times?


Scriph
 Share

Recommended Posts

Before I start, code will NOT be formatted. BBcode is not working for me.

 

My code runs multiple times sometimes.

When I break a block, sometimes it does 2 things. I wan't it to only do 1 thing. It randomly happens.

Read all the code before replying.

 

Thanks in advance!

 

package com.scriph.luckybox.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.command.ICommandManager;
import net.minecraft.command.ICommandSender;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityList;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.ChunkCoordinates;
import net.minecraft.util.IChatComponent;
import net.minecraft.world.World;


public class blockLuckyBlock extends Block{

int randomWithRange(int min, int max){
int range = (max - min) + 1;     
return (int)(Math.random() * range) + min;
}

public blockLuckyBlock(){
super(Material.rock);
this.setCreativeTab(CreativeTabs.tabBlock);
this.setBlockName("luckyboxblock");
this.setCreativeTab(CreativeTabs.tabBlock);
this.setBlockTextureName("luckybox:lucky_box");
this.setResistance(1000);
}

public void onBlockDestroyedByPlayer(World world, int x, int y, int z, int meta) {
MinecraftServer minecraftserver = MinecraftServer.getServer();
ICommandManager icommandmanager = minecraftserver.getCommandManager();
ICommandSender thisi = minecraftserver;	

int jf=randomWithRange(3,7);

switch (jf) {

case 3: jf=3;
icommandmanager.executeCommand(thisi,"/give @p minecraft:dirt 1");
break;

case 4: jf=4;
icommandmanager.executeCommand(thisi,"/give @p minecraft:diamond "+randomWithRange(3,34));
break;

case 5: jf=5;
Entity gravel = EntityList.createEntityByID(2, world);
gravel.setPosition(x, y, z);
world.spawnEntityInWorld(gravel);

Entity gravelz = EntityList.createEntityByID(2, world);
gravelz.setPosition(x, y, z);
world.spawnEntityInWorld(gravelz);
break;

case 6: jf=6;
Entity gravel1 = EntityList.createEntityByID(50, world);
gravel1.setPosition(x, y, z);
world.spawnEntityInWorld(gravel1);

Entity gravel2 = EntityList.createEntityByID(50, world);
gravel2.setPosition(x, y, z);
world.spawnEntityInWorld(gravel2);
world.spawnEntityInWorld(gravel2);
world.spawnEntityInWorld(gravel2);
world.spawnEntityInWorld(gravel2);
world.spawnEntityInWorld(gravel2);
break;

case 7: jf=7;
Entity EntityTNTPrimed = EntityList.createEntityByID(20, world);
EntityTNTPrimed.setPosition(x, y, z);
world.spawnEntityInWorld(EntityTNTPrimed);
    
Entity EntityTNTPrimedz = EntityList.createEntityByID(20, world);
EntityTNTPrimedz.setPosition(x-3, y, z);
world.spawnEntityInWorld(EntityTNTPrimedz);
    
Entity EntityTNTPrimedm = EntityList.createEntityByID(20, world);
EntityTNTPrimedm.setPosition(x+3, y, z);
world.spawnEntityInWorld(EntityTNTPrimedm);
    
Entity EntityTNTPrimedz1 = EntityList.createEntityByID(20, world);
EntityTNTPrimedz1.setPosition(x, y, z-3);
world.spawnEntityInWorld(EntityTNTPrimedz1);
    
Entity EntityTNTPrimedz2 = EntityList.createEntityByID(20, world);
EntityTNTPrimedz2.setPosition(x, y, z+3);
world.spawnEntityInWorld(EntityTNTPrimedz2);
break;

}return;}}

Link to comment
Share on other sites

1. It's really not that hard to put code and /code around your code.

2. On block destroyed by player is called on both the client and server sides. Use world.isRemote (true if client side) to check wether the code is running on the client or server side, you'll only want your code to execute if it's on the server.

3. From looking at your code it seems like you are making a clone of the Lucky Blocks mod, why?

Don't make mods if you don't know Java.

Check out my website: http://shadowfacts.net

Developer of many mods

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.