Search the Forums BEFORE making a new post.

[1.7.10][Resolved] Code appears not to be working

Posted February 18, 201510 yr

Excuse this mess,

public class MIEventHandler {

@SubscribeEvent
public void onInterect(PlayerInteractEvent e) {
	//Following lines of code control creation of chiseled ruby/sapphire using chisel.
	EntityPlayer player = e.entityPlayer;
	ItemStack itemstack = player.getHeldItem();
	World world = e.world;
	int x = e.x;
	int y = e.y;
	int z = e.z;
		if(e.action == e.action.RIGHT_CLICK_BLOCK){
			if(itemstack == new ItemStack(MIMain.chisel)) {
				if(world.getBlock(x, y, z) != null) {
					if(world.getBlock(x, y, z) == MIMain.rubyBlock) {
						world.setBlock(x, y, z, MIMain.chiseledRuby);
						if(!player.capabilities.isCreativeMode) {
							itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}	else if(world.getBlock(x, y, z) == MIMain.sapphireBlock) {
						world.setBlock(x, y, z, MIMain.chiseledSapphire);
						if(!player.capabilities.isCreativeMode) {
							itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}
			}
		}

I'm trying to test whether the player has a chisel in their hand, and if they do, then it will check whether they have clicked a sapphire block or ruby block, and if it is, set it to a chiseled version of the block, however, it appears not to be working. Could anyone help me out here?

There's 10 types of people in this world; Those that understand binary and those that don't.

Quote

February 18, 201510 yr

Excuse this mess,

public class MIEventHandler {

@SubscribeEvent
public void onInterect(PlayerInteractEvent e) {
	//Following lines of code control creation of chiseled ruby/sapphire using chisel.
	EntityPlayer player = e.entityPlayer;
	ItemStack itemstack = player.getHeldItem();
	World world = e.world;
	int x = e.x;
	int y = e.y;
	int z = e.z;
		if(e.action == e.action.RIGHT_CLICK_BLOCK){
			if(itemstack == new ItemStack(MIMain.chisel)) {
				if(world.getBlock(x, y, z) != null) {
					if(world.getBlock(x, y, z) == MIMain.rubyBlock) {
						world.setBlock(x, y, z, MIMain.chiseledRuby);
						if(!player.capabilities.isCreativeMode) {
							itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}	else if(world.getBlock(x, y, z) == MIMain.sapphireBlock) {
						world.setBlock(x, y, z, MIMain.chiseledSapphire);
						if(!player.capabilities.isCreativeMode) {
							itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}
			}
		}

What does not working mean?

Is there a crash?

Or does it just not do anything. If this is the case, put in debug comments and narrow down the problem.

One thing I can see wrong for certain is that you check it on both sides, the client and the server.

Use if(!world.isRemote) to see

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Quote

February 18, 201510 yr

Make sure you're registering your EventHandler.

Quote

February 18, 201510 yr

Author

I've already registered the EventHandler @charsmud,

I made a few changes to it, and now it fails to start (previously it would start).

[18:25:21] [main/INFO] [FML/]: Forge Mod Loader version 7.10.18.1180 for Minecraft 1.7.10 loading
[18:25:21] [main/INFO] [FML/]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_25, running on Windows 8.1:amd64:6.3, installed at C:\Program Files (x86)\Minecraft\runtime\jre-x64\1.8.0_25
[18:25:21] [main/DEBUG] [FML/]: Java classpath at launch is C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\minecraftforge\forge\1.7.10-10.13.0.1180\forge-1.7.10-10.13.0.1180.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\minecraft\launchwrapper\1.9\launchwrapper-1.9.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\ow2\asm\asm-all\4.1\asm-all-4.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\typesafe\akka\akka-actor_2.11\2.3.3\akka-actor_2.11-2.3.3.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\typesafe\config\1.2.1\config-1.2.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-actors-migration_2.11\1.1.0\scala-actors-migration_2.11-1.1.0.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-compiler\2.11.1\scala-compiler-2.11.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\plugins\scala-continuations-library_2.11\1.0.2\scala-continuations-library_2.11-1.0.2.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\plugins\scala-continuations-plugin_2.11.1\1.0.2\scala-continuations-plugin_2.11.1-1.0.2.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-library\2.11.1\scala-library-2.11.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-parser-combinators_2.11\1.0.1\scala-parser-combinators_2.11-1.0.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-reflect\2.11.1\scala-reflect-2.11.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-swing_2.11\1.0.1\scala-swing_2.11-1.0.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\scala-lang\scala-xml_2.11\1.0.2\scala-xml_2.11-1.0.2.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\sf\jopt-simple\jopt-simple\4.5\jopt-simple-4.5.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\lzma\lzma\0.0.1\lzma-0.0.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\mojang\realms\1.3.1\realms-1.3.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\commons\commons-compress\1.8.1\commons-compress-1.8.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\httpcomponents\httpclient\4.3.3\httpclient-4.3.3.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\commons-logging\commons-logging\1.1.3\commons-logging-1.1.3.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\httpcomponents\httpcore\4.3.2\httpcore-4.3.2.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\java3d\vecmath\1.3.1\vecmath-1.3.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\sf\trove4j\trove4j\3.0.3\trove4j-3.0.3.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\ibm\icu\icu4j-core-mojang\51.2\icu4j-core-mojang-51.2.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\paulscode\codecjorbis\20101023\codecjorbis-20101023.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\paulscode\codecwav\20101023\codecwav-20101023.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\paulscode\libraryjavasound\20101123\libraryjavasound-20101123.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\paulscode\librarylwjglopenal\20100824\librarylwjglopenal-20100824.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\paulscode\soundsystem\20120107\soundsystem-20120107.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\io\netty\netty-all\4.0.10.Final\netty-all-4.0.10.Final.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\google\guava\guava\16.0\guava-16.0.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\commons\commons-lang3\3.2.1\commons-lang3-3.2.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\commons-io\commons-io\2.4\commons-io-2.4.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\commons-codec\commons-codec\1.9\commons-codec-1.9.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\java\jinput\jinput\2.0.5\jinput-2.0.5.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\net\java\jutils\jutils\1.0.0\jutils-1.0.0.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\google\code\gson\gson\2.2.4\gson-2.2.4.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\com\mojang\authlib\1.5.16\authlib-1.5.16.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\logging\log4j\log4j-api\2.0-beta9\log4j-api-2.0-beta9.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\apache\logging\log4j\log4j-core\2.0-beta9\log4j-core-2.0-beta9.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\lwjgl\lwjgl\lwjgl\2.9.1\lwjgl-2.9.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\org\lwjgl\lwjgl\lwjgl_util\2.9.1\lwjgl_util-2.9.1.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\libraries\tv\twitch\twitch\5.16\twitch-5.16.jar;C:\Users\Ryan\AppData\Roaming\.minecraft\versions\1.7.10-Forge10.13.0.1180\1.7.10-Forge10.13.0.1180.jar
[18:25:21] [main/DEBUG] [FML/]: Java library path at launch is C:\Users\Ryan\AppData\Roaming\.minecraft\versions\1.7.10-Forge10.13.0.1180\1.7.10-Forge10.13.0.1180-natives-441561050886975
[18:25:21] [main/DEBUG] [FML/]: Enabling runtime deobfuscation
[18:25:21] [main/DEBUG] [FML/]: Instantiating coremod class FMLCorePlugin
[18:25:21] [main/DEBUG] [FML/]: Added access transformer class cpw.mods.fml.common.asm.transformers.AccessTransformer to enqueued access transformers
[18:25:21] [main/DEBUG] [FML/]: Enqueued coremod FMLCorePlugin
[18:25:21] [main/DEBUG] [FML/]: Instantiating coremod class FMLForgePlugin
[18:25:21] [main/DEBUG] [FML/]: Added access transformer class net.minecraftforge.transformers.ForgeAccessTransformer to enqueued access transformers
[18:25:21] [main/DEBUG] [FML/]: Enqueued coremod FMLForgePlugin
[18:25:21] [main/DEBUG] [FML/]: All fundamental core mods are successfully located
[18:25:21] [main/DEBUG] [FML/]: Discovering coremods
[18:25:21] [main/DEBUG] [FML/]: Examining for coremod candidacy FNAF-1.7.10-0.0.1.jar
[18:25:21] [main/DEBUG] [FML/]: Not found coremod data in FNAF-1.7.10-0.0.1.jar
[18:25:21] [main/INFO] [LaunchWrapper/]: Loading tweak class name cpw.mods.fml.common.launcher.FMLInjectionAndSortingTweaker
[18:25:21] [main/INFO] [LaunchWrapper/]: Loading tweak class name cpw.mods.fml.common.launcher.FMLDeobfTweaker
[18:25:21] [main/INFO] [LaunchWrapper/]: Calling tweak class cpw.mods.fml.common.launcher.FMLInjectionAndSortingTweaker
[18:25:21] [main/ERROR] [LaunchWrapper/]: Unable to launch
java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[?:1.8.0_25]
at java.util.ArrayList$Itr.remove(ArrayList.java:865) ~[?:1.8.0_25]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:117) [launchwrapper-1.9.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]

public class MIEventHandler {

@SubscribeEvent
public void onInterect(PlayerInteractEvent e) {
	//Following lines of code control creation of chiseled ruby/sapphire using chisel.
	EntityPlayer player = e.entityPlayer;
	ItemStack itemstack = player.getHeldItem();
	World world = e.world;
	int x = e.x;
	int y = e.y;
	int z = e.z;
		if(e.action == e.action.RIGHT_CLICK_BLOCK){
			player.addChatComponentMessage(new ChatComponentText(EnumChatFormatting.AQUA + "Right click block check working."));
			if(!world.isRemote){
				player.addChatComponentMessage(new ChatComponentText(EnumChatFormatting.AQUA + "Side check working."));
				if(itemstack == new ItemStack(MIMain.chisel)) {
					player.addChatComponentMessage(new ChatComponentText(EnumChatFormatting.AQUA + "Chisel check working."));
					if(world.getBlock(x, y, z) != null) {
						if(world.getBlock(x, y, z) == MIMain.rubyBlock) {
							player.addChatComponentMessage(new ChatComponentText(EnumChatFormatting.AQUA + "Ruby block check working."));
							world.setBlock(x, y, z, MIMain.chiseledRuby);
							if(!player.capabilities.isCreativeMode) {
								itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}	else if(world.getBlock(x, y, z) == MIMain.sapphireBlock) {
					player.addChatComponentMessage(new ChatComponentText(EnumChatFormatting.AQUA + "Sapphire block check working."));
						world.setBlock(x, y, z, MIMain.chiseledSapphire);
						if(!player.capabilities.isCreativeMode) {
							itemstack.setItemDamage(itemstack.getItemDamage() - 1);
					}
				}
			}
		}

There's 10 types of people in this world; Those that understand binary and those that don't.

Quote

February 18, 201510 yr

Not that I know direct answer but there are few flaws in your code:

if(itemstack == new ItemStack(MIMain.chisel))

You should NEVER do this. Don't declare new ItemStack. you should:

if (stack != null) if (stack.getItem() == YourItemRegistry.itemChiselInstance)

As to main problem: Do you know how to use Debug mode in eclipse? Place breakpoint in your event (maybe even in EACH line) follow them and say when does it crash.

Last question: Are you sure you are using right event bus?

1.7.10 is no longer supported by forge, you are on your own.

Quote

February 18, 201510 yr

Author

I am aware of the debug mode in eclipse, however, I cannot use it for some reason (fails to start the client everytime).

I have just checked over myself, and it appears I had not registered my EventHandler. Should be resgistered now.

To answer your last question Ernio, I believe I am using the correct bus,

MinecraftForge.EVENT_BUS.register(new MIEventHandler());

There's 10 types of people in this world; Those that understand binary and those that don't.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/27770-1710resolved-code-appears-not-to-be-working/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

exit code 1

S

By Drizzmic86 · Posted 7 hours ago7 hr
Orbital strike cannon fishing rod mod

its nice that the rod breaks now but for some reason the stab shot just sents u flying even with low tnt also are u gonna do versions 1.21+ @FoxyWoxy

By Astoxy · 9 hours ago9 hr
Orbital strike cannon fishing rod mod

@Astoxy The rods will break Ok that was a early build im just waiting for curse forge and modrinth to accept my mod btw here is v1.1.5
https://drive.google.com/file/d/1wa3-awKMEoxe2WUbxGZZDIxFo_QfLWCM/view?usp=sharing
v1.2.0 will be the final version

By FoxyWoxy · 13 hours ago13 hr
Orbital strike cannon fishing rod mod

mod works well it would be better if the fishing rod wasnt unbrekable tho hope u can make it for the newer versions @FoxyWoxy

By Astoxy · 14 hours ago14 hr
New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 17 hours ago17 hr

Astoxy

Sign In

[1.7.10][Resolved] Code appears not to be working

Featured Replies

Join the conversation

Posts

exit code 1

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)