Jump to content

Recommended Posts

Posted

Hey guys,

 

I am trying to make ground slams, which attack all entities within a certain radius. It's all working good, except the actual entity attacks aren't working. I keep trying different things, even using vanilla Damage Sources, but it's still not working.

 

Ground Slam Code:

private void doGroundSlam(EntityPlayer player, World world) {

	if(!world.isRemote) {

		return;

	}

	double groundSlamRadius = 5;
	double startX = player.posX - groundSlamRadius;
	double startY = player.posY - groundSlamRadius;
	double startZ = player.posZ - groundSlamRadius;
	double endX = player.posX + groundSlamRadius;
	double endY = player.posY + groundSlamRadius;
	double endZ = player.posZ + groundSlamRadius;

	for(Object obj : world.getEntitiesWithinAABBExcludingEntity(player, AxisAlignedBB.getBoundingBox(startX, startY, startZ, endX, endY, endZ))) {

		Entity entity = (Entity)obj;
		double distance = entity.getDistanceToEntity(player);

		if(entity instanceof EntityLivingBase) {

			((EntityLivingBase) entity).attackEntityAsMob(player);

		}

		entity.attackEntityFrom(new DamageSourceGroundSlam(entity, player), (float)distance / 20f);

	}

}

 

DamageSource code:

package assets.aw.common.utils;

import net.minecraft.entity.Entity;
import net.minecraft.util.EntityDamageSourceIndirect;

public class DamageSourceGroundSlam extends EntityDamageSourceIndirect {

public DamageSourceGroundSlam(Entity p_i1568_2_, Entity p_i1568_3_) {

	super("aw.slam", p_i1568_2_, p_i1568_3_);
	this.setDamageBypassesArmor();

}

}

 

Anyone got any ideas?

- Romejanic

Romejanic

 

Creator of Witch Hats, Explosive Chickens and Battlefield!

Posted

Ahh, here's the problem:

 

if(!world.isRemote) {

return;

}

 

I've changed it to world.isRemote and fixed up my packets a bit. But now, the attacks work in multiplayer fine, but world.isRemote is ALWAYS true on singleplayer. It even tells me that it registered the event on the server, but the doGroundSlam runs on the client!

Romejanic

 

Creator of Witch Hats, Explosive Chickens and Battlefield!

Posted

I know. I send a packet from the client to be processed on the server. It works perfectly on multiplayer, but singleplayer doesn't work at all.

Romejanic

 

Creator of Witch Hats, Explosive Chickens and Battlefield!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.