Search the Forums BEFORE making a new post.

[1.7.10] [SOLVED] Checking Player for Custom Armor w/ NBT Data

Posted February 21, 201510 yr

I'm trying to make a mod which adds custom armor and a GUI that can display certain properties of the armor, namely it's operation mode. These properties are stored as NBT tags, which I can set and acces, however I'm trying to write a function that checks the player's armor slots and detects if he's/she's wearing the custom armor and, if he/she is, get the NBT data from it.

Every attempt I've made at this so far only resulted in my game crashing or simply nothing happening. My code looked something like this

//Helmet
if (player.inventory.armorInventory[3] != null) {
   if (player.inventory.armorInventory[3].getItem() == MODNAME.Helmet) {
       return player.inventory.armorInventory[3].getCompoundTag().getInterger("mode");
   }
}

However, like I said this just crashes. Any help would be appreciated.

(Also, this code is being run in the onArmorTick method of the helmet, as it's supposed to serve as a sort of heads-up-display.)

EDIT: After doing some testing, it seems as though the crash is coming from trying to get the NBT data itself. The data is formatted as an interger with a value of 2.

Quote

February 22, 201510 yr

I'm trying to make a mod which adds custom armor and a GUI that can display certain properties of the armor, namely it's operation mode. These properties are stored as NBT tags, which I can set and acces, however I'm trying to write a function that checks the player's armor slots and detects if he's/she's wearing the custom armor and, if he/she is, get the NBT data from it.

Every attempt I've made at this so far only resulted in my game crashing or simply nothing happening. My code looked something like this
//Helmet
if (player.inventory.armorInventory[3] != null) {
   if (player.inventory.armorInventory[3].getItem() == MODNAME.Helmet) {
       return player.inventory.armorInventory[3].getCompoundTag().getInterger("mode");
   }
}
However, like I said this just crashes. Any help would be appreciated.

(Also, this code is being run in the onArmorTick method of the helmet, as it's supposed to serve as a sort of heads-up-display.)

Give the crash.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Quote

February 22, 201510 yr

Author

Here's the crash report

---- Minecraft Crash Report ----
// My bad.

Time: 2/21/15 7:20 PM

Description: Ticking player

java.lang.NullPointerException: Ticking player

at com.sciman.cyborg.items.ItemCyborgHelmet.grabArmorModes(ItemCyborgHelmet.java:49)

at com.sciman.cyborg.items.ItemCyborgHelmet.onArmorTick(ItemCyborgHelmet.java:38)

at net.minecraft.entity.player.InventoryPlayer.decrementAnimations(InventoryPlayer.java:355)

at net.minecraft.entity.player.EntityPlayer.onLivingUpdate(EntityPlayer.java:610)

at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:1816)

at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:327)

at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:330)

at net.minecraft.network.NetHandlerPlayServer.processPlayer(NetHandlerPlayServer.java:329)

at net.minecraft.network.play.client.C03PacketPlayer.processPacket(C03PacketPlayer.java:37)

at net.minecraft.network.play.client.C03PacketPlayer.processPacket(C03PacketPlayer.java:111)

at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)

at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace:

at com.sciman.cyborg.items.ItemCyborgHelmet.grabArmorModes(ItemCyborgHelmet.java:49)

at com.sciman.cyborg.items.ItemCyborgHelmet.onArmorTick(ItemCyborgHelmet.java:38)

at net.minecraft.entity.player.InventoryPlayer.decrementAnimations(InventoryPlayer.java:355)

at net.minecraft.entity.player.EntityPlayer.onLivingUpdate(EntityPlayer.java:610)

at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:1816)

at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:327)

-- Player being ticked --

Details:

Entity Type: null (net.minecraft.entity.player.EntityPlayerMP)

Entity ID: 0

Entity Name: Player206

Entity's Exact location: 1323.34, 56.00, 186.43

Entity's Block location: World: (1323,56,186), Chunk: (at 11,3,10 in 82,11; contains blocks 1312,0,176 to 1327,255,191), Region: (2,0; contains chunks 64,0 to 95,31, blocks 1024,0,0 to 1535,255,511)

Entity's Momentum: 0.00, -0.08, 0.00

Stacktrace:

at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:330)

at net.minecraft.network.NetHandlerPlayServer.processPlayer(NetHandlerPlayServer.java:329)

at net.minecraft.network.play.client.C03PacketPlayer.processPacket(C03PacketPlayer.java:37)

at net.minecraft.network.play.client.C03PacketPlayer.processPacket(C03PacketPlayer.java:111)

at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

-- Ticking connection --

Details:

Connection: net.minecraft.network.NetworkManager@794dfd82

Stacktrace:

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)

at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

-- System Details --

Details:

Minecraft Version: 1.7.10

Operating System: Windows 7 (amd64) version 6.1

Java Version: 1.7.0_75, Oracle Corporation

Java VM Version: Java HotSpot 64-Bit Server VM (mixed mode), Oracle Corporation

Memory: 881999816 bytes (841 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)

JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M

AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0

FML: MCP v9.05 FML v7.10.85.1291 Minecraft Forge 10.13.2.1291 4 mods loaded, 4 mods active

mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

FML{7.10.85.1291} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.2.1291.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

Forge{10.13.2.1291} [Minecraft Forge] (forgeSrc-1.7.10-10.13.2.1291.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

cyborgmod{1.0} [cyborgmod] (bin) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available

Profiler Position: N/A (disabled)

Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

Player Count: 1 / 8; [EntityPlayerMP['Player206'/0, l='Mod Testing', x=1323.34, y=56.00, z=186.43]]

Type: Integrated Server (map_client.txt)

Is Modded: Definitely; Client brand changed to 'fml,forge'

Quote

February 22, 201510 yr

Put a != null check on the getTagCompound as well. I've learned the hard way if you try to get a value from a null tag compound you're gonna have a bad time.

Quote

February 22, 201510 yr

Author

Ok, so I tried that with this code

public int[] grabArmorModes(EntityPlayer player) {
	int[] ret_mod = new int[] {0,0,0,0};
	if (player.inventory.armorInventory[3] != null) {
		if (player.inventory.armorInventory[3].getItem() == CyborgMod.cyborgHelmet) {
			System.out.println(player.inventory.armorInventory[3].getItem().getUnlocalizedName());
			NBTTagCompound temp = player.inventory.armorInventory[3].getTagCompound();
			if (temp != null) {
				ret_mod[0] = temp.getInteger("mode");
				System.out.println("Sucess! got int" + String.valueOf(temp.getInteger("mode")));
			}
		}
	}
	return ret_mod;

}

(grabArmorModes is the function used by the helmet object to pass the armor values to the GUI to display)

It prints the item's name to the console, but never gets to the next print value, so the NBT tag must be return null.

This is where I declare the NBT data

//Declare NBT data
	NBTTagCompound tag = new NBTTagCompound();
	tag.setInteger("mode", 2);
	tag.setFloat("power",0F);

What am I doing wrong?

EDIT: I'm going to try changing it so that the GUI itself gets the armor values, not the helmet.

EDIT AGAIN: It looks like the NBT data always returns null. I'm goign to try and see if I can fix that.

Quote

February 22, 201510 yr

My guess you are declaring it wrong.

//Declare NBT data
	NBTTagCompound tag = new NBTTagCompound();
	tag.setInteger("mode", 2);
	tag.setFloat("power",0F);

What is this doing? You simply make new NBT object, that's all.

write wraped getter for NBTTag:

if (stack.getTagCompound() == null) stack.tagCompound = new NBTTagCompound()
return stack.getTagCompound() ;

1.7.10 is no longer supported by forge, you are on your own.

Quote

February 22, 201510 yr

Author

in what method would I put the getter, since it would go into an armor item?

Edit: Actually, maybe I should just change this thread to 'How do I add NBT data to an item on creation and retrieve that data from a GUI?'

Quote

February 22, 201510 yr

I'll just write it: post whole code of your armour.

Creating new local (in-method) NBT and putting values into it doesn't magically make that NBTTag be itemstack's one. You need to itemstack.nbttag = new NBT whenever it is null;

1.7.10 is no longer supported by forge, you are on your own.

Quote

February 23, 201510 yr

Author

Nevermind, i figured it out.

I put this code into the armor

if (stack.stackTagCompound == null) {
		stack.stackTagCompound = new NBTTagCompound();
		stack.stackTagCompound.setInteger("mode", 2);
		stack.stackTagCompound.setFloat("power", 0F);
		System.out.println("Made NBT data");
	}

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/27872-1710-solved-checking-player-for-custom-armor-w-nbt-data/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 10 hours ago10 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 18 hours ago18 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 18 hours ago18 hr
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · 23 hours ago23 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day

There are no registered users currently online

Sign In

[1.7.10] [SOLVED] Checking Player for Custom Armor w/ NBT Data

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)