Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

So I am making several types of wood for my mod, and I am having a problem with the rendering of the block. The problem is not that I don't get to render the block, but the fact that one of the types of plank are using the wrong texture. Namely the alder plank.  Where it use the texture of the yew plank.  If you look at the code in the class BlockPlank you can see that I have placed in some System.out.println() for checking what values or strings are used. When placing the alderplank, it outputs

 

[11:12:27] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Alder]
[11:12:27] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Alder]

which it should, but when broken it outputs

[11:14:37] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16

 

Which now means that the game thinks it is Yew plank. I have been trying to look for why it does this, but havn't really found the error. If someone could help me that would be great

 

 

Code:

 

BlockPlank:

package com.tommywithatiger.extendedminecraft.blocks;

import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import com.tommywithatiger.extendedminecraft.handler.ExtendedMinecraftCreativeTabHandler;

public class BlockPlank extends Block{

public BlockPlank() {
	super(Material.wood);
	this.setCreativeTab(ExtendedMinecraftCreativeTabHandler.ExtendedMinecraftBlocksTab);
	this.setDefaultState(this.blockState.getBaseState().withProperty(PROPERTYTYPE, BlockPlank.EnumWoodType.ALDER));
}

public static final PropertyEnum PROPERTYTYPE = PropertyEnum.create("woodtype", EnumWoodType.class);


@Override
@SideOnly(Side.CLIENT)
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list){
	for(EnumWoodType type: EnumWoodType.values()){
			list.add(new ItemStack(itemIn, 1, type.getMetadata()));
	}
}

@Override
protected BlockState createBlockState()  {
	return new BlockState(this, new IProperty[] {PROPERTYTYPE});
    }

@Override
public IBlockState getStateFromMeta(int meta){
	EnumWoodType type = EnumWoodType.byMetadata(meta);
	System.out.println(this.getDefaultState().withProperty(PROPERTYTYPE, type));
	return this.getDefaultState().withProperty(PROPERTYTYPE, type);
}

@Override
public int getMetaFromState(IBlockState state){
	EnumWoodType type = (EnumWoodType)state.getValue(PROPERTYTYPE);
	System.out.println(type);
	int typebit = type.getMetadata();
	System.out.println(typebit);
	return typebit;
}

@Override
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing blockFaceClickedOn, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
{
	EnumWoodType type = EnumWoodType.byMetadata(meta);
	System.out.println(this.getDefaultState().withProperty(PROPERTYTYPE, type));
	return this.getDefaultState().withProperty(PROPERTYTYPE, type);
}

public static enum EnumWoodType implements IStringSerializable
{
    ALDER(0,"Alder","alder"),
    ASH(1,"Ash","ash"),
    ASPEN(2,"Aspen","aspen"),
    CEDAR(3,"Cedar","cedar"),
    CHERRY(4,"Cherry","cherry"),
    ELM(5,"Elm","elm"),
    EUCALYPTUS(6,"Eucalyptus","eucalyptus"),
    FIR(7,"Fir","fir"),
    HICKORY(8,"Hickory","hickory"),
    MAHOGANY(9,"Mahogany","mahogany"),
    MAPLE(10,"Maple","maple"),
    PINE(11,"Pine","pine"),
    POPLAR(12,"Poplar","poplar"),
    REDWOOD(13,"Redwood","redwood"),
    TEAK(14,"Teak","teak"),
    WILLOW(15,"Willow","willow"),
    YEW(16,"Yew","yew");
    
    private final int meta;
    private final String name;
    private final String substring;
    private static final EnumWoodType[] META_LOOKUP = new BlockPlank.EnumWoodType[values().length];
    
    private EnumWoodType(int i_meta, String i_name, String i_substring){
    	this.meta = i_meta;
    	this.name = i_name;
    	this.substring = i_substring;
    }
    
    public int getMetadata(){
    	return this.meta;
    }
    
    @Override
    public String toString()
    {
    	return this.name;
    }
    
    public String getSubstring(){
    	return this.substring;
    }
    
    public static EnumWoodType byMetadata(int meta)
    {
    	if (meta < 0 || meta >= META_LOOKUP.length)
    	{
    		meta = 0;
    	}
    	
    	return META_LOOKUP[meta];
    }
    
    public String getName(){
    	return this.name;
    }
    	    
    static
    {
    	for ( EnumWoodType woodType : values()){
    		META_LOOKUP[woodType.getMetadata()] = woodType;
    	}
    }

}

}

 

plank.json:

{
    "variants": {
        "woodtype=alder": { "model": "em:alderplank" },
        "woodtype=ash": {"model": "em:medium_crafting_table"},
        "woodtype=aspen": {"model": "em:medium_crafting_table"},
        "woodtype=cedar": {"model": "em:medium_crafting_table"},
        "woodtype=cherry": {"model": "em:medium_crafting_table"},
        "woodtype=elm": {"model": "em:medium_crafting_table"},
        "woodtype=eucalyptus": {"model": "em:medium_crafting_table"},
        "woodtype=fir": {"model": "em:medium_crafting_table"},
        "woodtype=hickory": {"model": "em:medium_crafting_table"},
        "woodtype=mahogany": {"model": "em:medium_crafting_table"},
        "woodtype=maple": {"model": "em:medium_crafting_table"},
        "woodtype=pine": {"model": "em:medium_crafting_table"},
        "woodtype=poplar": {"model": "em:medium_crafting_table"},
        "woodtype=redwood": {"model": "em:medium_crafting_table"},
        "woodtype=teak": {"model": "em:medium_crafting_table"},
        "woodtype=willow": {"model": "em:medium_crafting_table"},
        "woodtype=yew": {"model": "em:small_crafting_table"}
    }
}

 

 

You have 17 types. You can only have 16 of those being saved as metadata (metadata is still saved as 4 bits => 0-15).

The world now thinks the block is from the last type when it's actually the first one.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

So what you are saying is that I can only have 16 different types saved in metadata. So if you want more than 16 you have to register several blocks? Or is it possibly to setup another Enum?

Guest
This topic is now closed to further replies.

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.