Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Oredictionary issues

jordsta95

By jordsta95
in Modder Support

 Share

Recommended Posts

jordsta95 Creeper Killer

jordsta95

Posted
Posted

Hey, I am getting this crash after registering ores: http://pastebin.com/SnFrfL3N

I understand that it's an issue with damage values, but I don't get why it is doing it...

Here's the code registering the oreDict stuff:

	OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 1, 3));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 2, 3));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3, 3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 4, 3));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 5, 3));

And if I comment that out, everything runs just fine. And I have tried that code like that and like

	OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 1));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 2));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 4));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 5));

both of which had the same outcome...

 

Sorry for sounding like a noob on something that is probably really obvious, but I just don't know what is wrong, as that looks fine to me, and using it (this code) without the metadata item(s) works just fine...

Why bother?

Link to comment
Share on other sites
Lewis_McReu Tree Puncher

Lewis_McReu

Posted
Posted

Another thing might be this: in your ItemStack constructor you might be filling in the parameters wrongly: the first parameter is the Item, the second is the stacksize and the third is the metadata/item damage. So in the first case you're not actually defining a damage value (the constructor thus sets it to 0). In the second, you're setting the damage value to 3 for each ItemStack.

 

So, assuming this is what you want, here's the correction:

OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 3, 1));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 3, 2));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3, 3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 3, 4));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 3, 5));

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing


  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • iker.
      Custom Model Block Rotation

      By iker. · Posted

      Hello, I'm working on my first Minecraft 1.20.2 mod. However, I've created a custom block model and everything works perfectly except the rotation of the block. The code is implemented but it still doesnt work. Need help. This is the code of the object class. import net.minecraft.core.BlockPos; import net.minecraft.world.item.context.BlockPlaceContext; import net.minecraft.world.level.BlockGetter; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.block.HorizontalDirectionalBlock; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.level.block.state.StateDefinition; import net.minecraft.world.level.block.state.properties.BlockStateProperties; import net.minecraft.world.level.block.state.properties.DirectionProperty; import net.minecraft.world.phys.shapes.CollisionContext; import net.minecraft.world.phys.shapes.VoxelShape; import net.minecraft.world.level.block.Rotation; import net.minecraft.world.level.block.Mirror; public class DirtyRock extends HorizontalDirectionalBlock { public static final DirectionProperty FACING = BlockStateProperties.HORIZONTAL_FACING; public static final VoxelShape SHAPE = Block.box(4, 0, 4, 12, 2, 11); public DirtyRock(Properties pProperties) { super(pProperties); } @Override public VoxelShape getShape(BlockState pState, BlockGetter pLevel, BlockPos pPos, CollisionContext pContext) { return SHAPE; } @Override public BlockState getStateForPlacement(BlockPlaceContext pContext) { return this.defaultBlockState().setValue(FACING, pContext.getHorizontalDirection().getOpposite()); } @Override public BlockState rotate(BlockState pState, Rotation pRot) { return pState.setValue(FACING, pRot.rotate(pState.getValue(FACING))); } @Override public BlockState mirror(BlockState pState, Mirror pMirror) { return pState.rotate(pMirror.getRotation(pState.getValue(FACING))); } @Override protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> pBuilder) { pBuilder.add(FACING); } } In the ModBlocks class the block is registred like this public static final RegistryObject<Block> DIRTY_ROCK=registerBlock("dirty_rock", ()-> new DirtyRock(BlockBehaviour.Properties.copy(Blocks.STONE_BUTTON))); private static <T extends Block>RegistryObject<T> registerBlock(String name, Supplier<T> block){ RegistryObject<T> toReturn=BLOCKS.register(name,block); registerBlockItem(name,toReturn); return toReturn; } In the Data, ModBlockStateProvider the blockstate is implemened simpleBlock(ModBlocks.DIRTY_ROCK.get(), new ModelFile.UncheckedModelFile(modLoc("block/dirty_rock"))); And in resources/assets/modname/models/block dirty_rock.json is implemented { "credit": "Made with Blockbench", "textures": { "0": "wildandhunt:block/dirty_bricks_block", "particle": "wildandhunt:block/dirty_bricks_block" }, "elements": [ { "from": [5, 0, 4], "to": [9, 1, 8], "rotation": {"angle": 22.5, "axis": "y", "origin": [10, 0, 7]}, "faces": { "north": {"uv": [5, 4, 10, 5], "texture": "#0"}, "east": {"uv": [5, 5, 10, 6], "texture": "#0"}, "south": {"uv": [5, 6, 10, 7], "texture": "#0"}, "west": {"uv": [5, 7, 10, 8], "texture": "#0"}, "up": {"uv": [5, 5, 0, 0], "texture": "#0"}, "down": {"uv": [5, 5, 0, 10], "texture": "#0"} } }, { "from": [9, 0, 4.05], "to": [11, 2, 6.05], "rotation": {"angle": 22.5, "axis": "y", "origin": [8, 0, 9]}, "faces": { "north": {"uv": [5, 4, 10, 5], "texture": "#0"}, "east": {"uv": [5, 5, 10, 6], "texture": "#0"}, "south": {"uv": [5, 6, 10, 7], "texture": "#0"}, "west": {"uv": [5, 7, 10, 8], "texture": "#0"}, "up": {"uv": [5, 5, 0, 0], "texture": "#0"}, "down": {"uv": [5, 5, 0, 10], "texture": "#0"} } }, { "from": [5, 0, 7], "to": [6, 1, 8], "rotation": {"angle": 22.5, "axis": "y", "origin": [10, 0, 10]}, "faces": { "north": {"uv": [5, 4, 10, 5], "texture": "#0"}, "east": {"uv": [5, 5, 10, 6], "texture": "#0"}, "south": {"uv": [5, 6, 10, 7], "texture": "#0"}, "west": {"uv": [5, 7, 10, 8], "texture": "#0"}, "up": {"uv": [5, 5, 0, 0], "texture": "#0"}, "down": {"uv": [5, 5, 0, 10], "texture": "#0"} } }, { "from": [10, 0, 8], "to": [12, 1, 9], "rotation": {"angle": 22.5, "axis": "y", "origin": [15, 0, 11]}, "faces": { "north": {"uv": [5, 4, 10, 5], "texture": "#0"}, "east": {"uv": [5, 5, 10, 6], "texture": "#0"}, "south": {"uv": [5, 6, 10, 7], "texture": "#0"}, "west": {"uv": [5, 7, 10, 8], "texture": "#0"}, "up": {"uv": [5, 5, 0, 0], "texture": "#0"}, "down": {"uv": [5, 5, 0, 10], "texture": "#0"} } }, { "from": [9.4, 0, 5], "to": [12.4, 1, 8.5], "rotation": {"angle": 22.5, "axis": "y", "origin": [12, 0, 7]}, "faces": { "north": {"uv": [8, 0, 11, 1], "texture": "#0"}, "east": {"uv": [8, 2, 10, 3], "texture": "#0"}, "south": {"uv": [8, 1, 11, 2], "texture": "#0"}, "west": {"uv": [8, 3, 10, 4], "texture": "#0"}, "up": {"uv": [8, 2, 5, 0], "texture": "#0"}, "down": {"uv": [8, 2, 5, 4], "texture": "#0"} } }, { "from": [6, 1, 6], "to": [10, 1.75, 10], "rotation": {"angle": 22.5, "axis": "y", "origin": [9, 0, 7]}, "faces": { "north": {"uv": [8, 0, 11, 1], "texture": "#0"}, "east": {"uv": [8, 2, 10, 3], "texture": "#0"}, "south": {"uv": [8, 1, 11, 2], "texture": "#0"}, "west": {"uv": [8, 3, 10, 4], "texture": "#0"}, "up": {"uv": [8, 2, 5, 0], "texture": "#0"}, "down": {"uv": [8, 2, 5, 4], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [0, 7.75, 0] }, "thirdperson_lefthand": { "translation": [0, 7.75, 0] }, "firstperson_righthand": { "translation": [0, 8.25, 0] }, "firstperson_lefthand": { "translation": [0, 8.25, 0] }, "ground": { "translation": [0, 4, 0] }, "gui": { "rotation": [32, 32, 9], "translation": [-1.25, 6.25, 0], "scale": [1.31, 1.31, 1.31] }, "fixed": { "translation": [0, 6.75, 0] } }, "groups": [ { "name": "dirty_stone", "origin": [8, 0, 7], "color": 0, "children": [0, 1, 2, 3, 4, 5] } ] }  
    • Type-32
      Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: -1

      By Type-32 · Posted

      has anyone encountered an issue where they have the same mod installed on client and server but when the client tries to join the server the client disconnects immediately and gives this `Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: -1` while the problem exists only when the mod is loaded? Repo: https://github.com/Type-32/PreciseManufacturing/tree/1.20.1 Forge 1.20.1 Mod, logs gives no useful info, but I'm still gonna put it here Server logs: https://pastebin.com/SUBbg0fF No client logs here because when client disconnects it only shows that is has disconnected, and nothing more  
    • BiancaBR
      Anyone can help me ? I can't play my game

      By BiancaBR · Posted

      i'm tryin to play All The Mods 8 modpack using curseforge, in 1.19.2 and forge 43.3.8. The game is unable to launch... 8gb ram allocated to the game (i have 16gb) The error code is in pastebin.com/2WydJ7y4
    • PanTristeHB
      Minecraft 1.19.2 crashed, display error and i already deleted all toml config files... What I can do?

      By PanTristeHB · Posted

      SOLVED
    • LuciDASeal
      My game keeps crashing when i attack a entity

      By LuciDASeal · Posted

      Not sure what's causing this but I'm having my problem where my game crashes when i attack   Crash Log = https://pastebin.com/MrznXcx9

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept