Oredictionary issues

[jordsta95]

Hey, I am getting this crash after registering ores: http://pastebin.com/SnFrfL3N

I understand that it's an issue with damage values, but I don't get why it is doing it...

Here's the code registering the oreDict stuff:

	OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 1, 3));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 2, 3));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3, 3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 4, 3));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 5, 3));

And if I comment that out, everything runs just fine. And I have tried that code like that and like

	OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 1));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 2));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 4));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 5));

both of which had the same outcome...

 

Sorry for sounding like a noob on something that is probably really obvious, but I just don't know what is wrong, as that looks fine to me, and using it (this code) without the metadata item(s) works just fine...

[jordsta95]

This means that

itemRegist.ingots

is

null

at the point where this code runs.

 

THAT WOULD BE WHY!

I always do that and never notice why v_v Thanks

I tried registering ores before registering items... Sometimes I feel like a complete idiot

[Lewis_McReu]

Another thing might be this: in your ItemStack constructor you might be filling in the parameters wrongly: the first parameter is the Item, the second is the stacksize and the third is the metadata/item damage. So in the first case you're not actually defining a damage value (the constructor thus sets it to 0). In the second, you're setting the damage value to 3 for each ItemStack.

 

So, assuming this is what you want, here's the correction:

OreDictionary.registerOre("ingotCopper", new ItemStack(itemRegist.ingots));
	OreDictionary.registerOre("ingotLead", new ItemStack(itemRegist.ingots, 3, 1));
	OreDictionary.registerOre("ingotTin", new ItemStack(itemRegist.ingots, 3, 2));
	OreDictionary.registerOre("ingotNickel", new ItemStack(itemRegist.ingots,3, 3));
	OreDictionary.registerOre("ingotAluminum", new ItemStack(itemRegist.ingots, 3, 4));
	OreDictionary.registerOre("ingotSilver", new ItemStack(itemRegist.ingots, 3, 5));