Checking if sound is playing && ISound[srsly noone?]

[Lua]

Hi, Im adding background music but Ive ran into a problem making sure no other music is playing before I play mine.

 

Heres what I got

 

@SubscribeEvent
public void playMyMusic(ClientTickEvent event)
{
	Random rand = new Random();
	ISound soundCache = null;
	SoundHandler handler = Minecraft.getMinecraft().getSoundHandler();
	int i = rand.nextInt(1000);
	if(soundCache == null || !handler.isSoundPlaying(soundCache))
	{
		if(i == 0)
		{
			System.out.println("playing sound");
			soundCache = new PositionedSoundRecord(new ResourceLocation(Arcticraft.MOD_ID + ":records.frozen_feelings"), 1.0F, 1.0F, 1.0F, 1.0F, 1.0F);
			handler.playSound(soundCache);
		}
	}
}

 

My sound plays but it will play over the top of any currently playing which I dont want. Obviously, its playing because soundCache does = null but thats because I have no idea how ISound works and didnt get any google results.

[Lua]

Bbbbbump

[Lua]

nobody at all?

 

[Elix_x]

Do you want to play your music always???

If you want just to add music, do it like resource pack would...

[Izzy Axel]

Doesn't music via resource packs replace the vanilla music?

[jabelar]

Okay, there is the Minecraft.getMinecraft().getSoundHandler().isSoundPlaying(ISound), stopSounds() and stopSound(ISound) methods available.

 

The stopSounds() will stop all sounds.

 

To stop a specific sound, you'd need to have the instance of the ISound to pass to the stopSound() method, which you probably won't have if it is a vanilla sound. But for your own sounds you can stop them this way.

[Izzy Axel]

So it's just not possible to add your own music properly, you can't check if vanilla songs are playing, so you always run the risk of playing your music over the vanilla tracks.

[jabelar]

So it's just not possible to add your own music properly, you can't check if vanilla songs are playing, so you always run the risk of playing your music over the vanilla tracks.

 

Unless you turn off all sounds yes.

 

However, you might be able to use reflection. The sound handler has a private field for the sound manager which has a private field for playingSounds map from which you could iterate through and check the ISound returned to find the private resource location.

 

I'm not that strong in reflection but I think that is possible.

[Izzy Axel]

Ok, this post was getting messy, there's no reason to show the totally incorrect things I tried, so here's what works:

 

 

SoundManager mng = ReflectionHelper.getPrivateValue(SoundHandler.class, Minecraft.getMinecraft().getSoundHandler(), "sndManager");
Map playingSounds = ReflectionHelper.getPrivateValue(SoundManager.class, mng, "playingSounds");
Iterator it = playingSounds.keySet().iterator();
while(it.hasNext())
{
   PositionedSound ps = (PositionedSound)playingSounds.get(it.next());
   ResourceLocation reloc = ReflectionHelper.getPrivateValue(PositionedSound.class, ps, "field_147664_a");
   if("music.game".equals(reloc.getResourcePath()))
   {
      Minecraft.getMinecraft().getSoundHandler().stopSound(ps);
      System.out.println("stopped music");
      break;
   }
}

[jabelar]

Awesome! Good work.

[Izzy Axel]

And here we are, in total: Adding Custom Music

[Elix_x]

Ok, this post was getting messy, there's no reason to show the totally incorrect things I tried, so here's what works:

 

 

SoundManager mng = ReflectionHelper.getPrivateValue(SoundHandler.class, Minecraft.getMinecraft().getSoundHandler(), "sndManager");
Map playingSounds = ReflectionHelper.getPrivateValue(SoundManager.class, mng, "playingSounds");
Iterator it = playingSounds.keySet().iterator();
while(it.hasNext())
{
   PositionedSound ps = (PositionedSound)playingSounds.get(it.next());
   ResourceLocation reloc = ReflectionHelper.getPrivateValue(PositionedSound.class, ps, "field_147664_a");
   if("music.game".equals(reloc.getResourcePath()))
   {
      Minecraft.getMinecraft().getSoundHandler().stopSound(ps);
      System.out.println("stopped music");
      break;
   }
}

This will crash in obf environment. When passing field name to reflection helper, pass both obfuscated and not obf names, reflection helper will not convert them into obfuscated fields...

[Izzy Axel]

So, how do you get the obfuscated names?

[Elix_x]

So, how do you get the obfuscated names?

Or you can use ObfuscationReflectionHelper, that will convert them automatically, or you go to user\.gradle\caches\minecraft\net\minecraftforge\forge\[forge version]\unpacked\conf and search in files fields.csv and methods.csv. It looks like obfName,deobfname,desccription. So you can find by one name another...

[Izzy Axel]

Alrighty, updated the Gist: Adding Custom Music v2