[1.8] Problems with Single player packet loss. [Solved]

[portablejim]

Code:

Network Registration: Lines 136 & 151

Packet sent from server to client.

Packet sent form client to server

 

I load a single player world, wait a second, back to title screen and load the world again. Log file.

 

Now in the log file, why does line 105 happen after 104 the first time I log in, but next time it is not the same as line 141. The packet seems to go missing?

 

Or maybe there is something I am missing?

[Abastro]

Where do you send PacketPingClient message?

[portablejim]

PacketPingClient is sent from PlayerLoggedInEvent.

[Ernio]

In 1.8 Minecraft has beed split into 4 threads, not 2 like it was before. New threads are: Client, Server, Client Netty and Server Netty. Those 2 last are threads responsinble for handling packets. What happens in your code:

Client logs in, server creates instance of player entity and sends packet to client via LoggedIn event. The problem here is that the client HASN'T created EntityPlayer yet, since spawnin entity to world (spawn packet) occurs after LoggedIn event. This results in packet being delivered but not processed since you don't have entity to process it on (player).

 

EVERYTIME (strongly suggeted) you send packt from server to client you have to ensure thread-safety by creating new Runnable and putting it into main client thread.

@Override
	public IMessage handleClientMessage(PacketSendData message, MessageContext ctx)
	{
		Minecraft.getMinecraft().addScheduledTask(new ScheludedClientTaskData(message));
		return null;
	}

ScheludedClientTaskData implements Runnable and in run() you put all code to be processed.

 

Note: This way you don't have to ever worry about packet being lost to non-existant client entities (that includes mobs if you e.g send packet from EntityJoinWorld, which also happens on server first).

[portablejim]

Thanks. Have fixed it.