So I was following a tutorial to add a potion effect when holding item, my code is:

@Override

public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5){

System.out.println("First update is Successfull");

super.onUpdate(stack, world, entity, par4, par5);

System.out.println("Update Successfull");

{

EntityPlayer player = (EntityPlayer) entity;

ItemStack equipped = player.getCurrentEquippedItem();

System.out.println("Found held item");

if(player.getCurrentEquippedItem().equals(stack)){

System.out.println("Found Item Successfully");

player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 5, 3));

System.out.println("Added Potion Effect Successfully");

}

}

}

 

I have all of the System.out.println to see where my code was getting stuck and it is getting stuck on the first line. This code works for many people but not me. I am using the most recent version of Eclipse, Forge 1.7.10 and jre1.8.0_45.

-The extra braces are to close of the ones I opened.

-What can I remove?

-So this mod would not work in single player?

-Then what would I put instead of entity?

My full code for that item is:

 

package com.farline.item;

 

 

import com.farline.creativetabs.MCreativeTabs;

 

import com.farline.lib.RefStrings;

 

 

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.Entity;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.potion.Potion;

import net.minecraft.potion.PotionEffect;

import net.minecraft.world.World;

import net.minecraftforge.common.util.EnumHelper;

import cpw.mods.fml.common.registry.GameRegistry;

 

public class SpeedStick extends Item{

 

public SpeedStick() {

this.setFull3D();

}

 

public static void main(String[] args){

 

}

 

public static void mainRegistry(){

initializeItem();

registerItem();

}

 

public static Item sStick;

 

public static void initializeItem(){

sStick = new Item().setUnlocalizedName("sStick").setMaxStackSize(1).setCreativeTab(MCreativeTabs.tabItems).setTextureName(RefStrings.MODID + ":SpeedStick");

 

}

 

public static void registerItem(){

GameRegistry.registerItem(sStick, sStick.getUnlocalizedName());

System.out.println("Added Item Successfully");

}

 

@Override

public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5){

System.out.println("First update is Successfull");

super.onUpdate(stack, world, entity, par4, par5);

System.out.println("Update Successfull");

{

EntityPlayer player = (EntityPlayer) entity;

ItemStack equipped = player.getCurrentEquippedItem();

System.out.println("Found held item");

if(player.getCurrentEquippedItem().equals(stack)){

System.out.println("Found Item Successfully");

player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 5, 3));

System.out.println("Added Potion Effect Successfully");

}

}

}

 

}

 

If that helps at all.

Just wondering how would I check if it's a player first?

Sorry about PM'ing you I just needed a fast repsonse.

I have removed those extra brackets and the if statement but still, nothing working.

New code:

 

@Override

public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5){

System.out.println("First update is Successfull");

super.onUpdate(stack, world, entity, par4, par5);

System.out.println("Update Successfull");

 

EntityPlayer player = (EntityPlayer) entity;

ItemStack equipped = player.getCurrentEquippedItem();

System.out.println("Found held item");

System.out.println("Found Item Successfully");

player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 5, 3));

System.out.println("Added Potion Effect Successfully");

}

world.isRemote - client

!world.isRemote - server

 

Everything that is "logic" part of game should always happen on server (spawning, updates, changing values, etc.)

 

entity instanceof EntityPlayer - if true you know that it is player, before that you can't touch player methods.

I have never touched this part of mods before, so can someone please help me out and insert what everyone is telling me to insert into the proper place, because i don't know where to put it.

I have tryed

if(!world.isRemote && entity instanceof EntityPlayer){

player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 5, 3));

}

NO luck though

The println messages are not apearing. The first line:

public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5){

println message isnt even apearing

Whole class:

http://pastebin.com/Tk1DuxEc

Okay so what do I do? I thought I registered the SpeedStick?

What's the point of adding that code if I already have it?

You told me to register the item, and then I asked how and you told me to put the code in that I already have.

Okay, so what do I put if not new Item()

Sorry but I'm new to the detect item stuff.

Ignore my last response, I'll try that and tell you whats happens.

OMG!! That worked! Thanks so much, and sorry for being such a noob and asking so many pointless questions.