Jump to content

Recommended Posts

Posted

I'm trying to update a block to 1.8 that has a toggleable state between solid and ethereal / invisible, but I'm having some trouble with the rendering (or rather, NOT rendering).

 

In 1.7, returning 'false' for isOpaqueCube and isNormalCube and then setting the block bounds all to zero was enough to get the block to 'disappear'; this no longer works.

 

I tried using an ISmartBlockModel to return the default model for air which, of course, there isn't one.

 

What I (think I) really need is to be able to dynamically return the renderType based on the block state, e.g.

// Inject this method into Block class:
public int getRenderType(IBlockState state) {
    return getRenderType(); // and deprecate this mo-fo
}

Then I could return -1 (do not render) or 3 (render as solid block) based on state.

 

Barring that, does anyone have any suggestions? I've been banging around trying all sorts of things trying to get it working, to no avail.

 

EDIT: Also, is it just me or is the block state sometimes not up to date on the client side? When first joining the world, I am occasionally able to walk through one of these blocks as though it were ethereal when it's not (and default state is not), but after a few seconds it figures out it's supposed to be solid. Are there just general clipping issues sometimes?

Posted

I took a quick look in Block.class and it has some stuff that might simplify that a bit. You could potentially override 'isOpaqueCube' and 'isCollidable' and just set them to false. I haven't tested it though so I might be way off.

If you had read my post more carefully, you'd see I already override isOpaqueCube, and isCollidable, per the Java-doc, is 'only used by Fire'. I do override canCollideCheck based on state, but my problem is not being able to walk through the block or not, it is getting the block not to render at all when it is ethereal.

 

As it is, it always renders like it is a solid block, even when it should be invisible. The ISmart/IFlexible block model interfaces do not allow for cancelling the rendering altogether, which is what I need it to do. Maybe if I try it in the cut-out layer...

 

EDIT: Lol, well that sorta worked - the blocks were invisible, even the solid ones! However, as soon as I entered into the block's space, even though its bounding box is supposedly all zero, the inside of the block renders and blocks out the screen. Hm.

Posted

I took a quick look in Block.class and it has some stuff that might simplify that a bit. You could potentially override 'isOpaqueCube' and 'isCollidable' and just set them to false. I haven't tested it though so I might be way off.

If you had read my post more carefully, you'd see I already override isOpaqueCube, and isCollidable, per the Java-doc, is 'only used by Fire'. I do override canCollideCheck based on state, but my problem is not being able to walk through the block or not, it is getting the block not to render at all when it is ethereal.

 

As it is, it always renders like it is a solid block, even when it should be invisible. The ISmart/IFlexible block model interfaces do not allow for cancelling the rendering altogether, which is what I need it to do. Maybe if I try it in the cut-out layer...

 

As getRenderType(IBlockState state) does not exist, you should make your own model invisible for the invisibility state.

So what was the problem with ISmartBlockModel?

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

That was my next step: seeing about creating a completely empty texture (all alpha transparency) and seeing if that would work.

 

The problem with the ISmartBlockModel is it still requires a model to render; air does not have a model (I tried and it gives you the infamous missing model texture) as well as air is render type -1 which does not look for a model at all in the render code but instead returns false.

 

ISmartBlockModel does not allow one to return false before anything even tries to render; I suppose that would be another alternative - change ISmartBlockModel to query whether to render a model or just return false without doing anything else.

Posted

That was my next step: seeing about creating a completely empty texture (all alpha transparency) and seeing if that would work.

 

The problem with the ISmartBlockModel is it still requires a model to render; air does not have a model (I tried and it gives you the infamous missing model texture) as well as air is render type -1 which does not look for a model at all in the render code but instead returns false.

 

ISmartBlockModel does not allow one to return false before anything even tries to render; I suppose that would be another alternative - change ISmartBlockModel to query whether to render a model or just return false without doing anything else.

 

Then what about giving empty list of quads on getFaceQuads() and getGeneralQuads()?

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

Already return null for those, same. However, TGG to the rescue as always with rendering-related questions.

 

Solution: Create fully transparent 16x16 texture for the invisible state and change the block's render layer to CUTOUT_MIPPED. Works perfectly EXCEPT for when inside the block, where everything renders completely black.

 

Overriding isFullCube, isOpaqueCube, and isNormalCube to all return false fixed that, in combination of course with setting the block bounds all to 0 when invisible. I'm going to experiment some more and see which, if any, of those three cube methods I can safely leave with the default value and still get the desired effect.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.