I'm trying to make an item that contains other items and has the attributes of a selected item within itself, sort of like a swiss army knife. I currently have an item that switches between a diamond hoe, shovel, pick, axe, and sword on shift right-click. The texture, damage value, and block mining attributes all switch to appropriate values when the item switches modes. The problem is that when the sword or hoe are selected, right-clicking does not do anything. I have already used print statements to prove that the onItemRightClick method for the appropriate item is called. Is there a way to do what I'm describing?

 

 

 

package mcnutty.multitool;

 

import java.util.Set;

 

import net.minecraft.block.Block;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.util.IIcon;

import net.minecraft.world.World;

 

import org.lwjgl.input.Keyboard;

 

import com.google.common.collect.HashMultimap;

import com.google.common.collect.Multimap;

 

import cpw.mods.fml.common.registry.GameData;

 

public class ItemMultitool extends Item{

 

private Item[] contained;

private int active;

 

public ItemMultitool(){

super();

setMaxStackSize(1);

setCreativeTab(CreativeTabs.tabMisc);

setUnlocalizedName("multitool");

active=0;

contained=new Item[] {GameData.getItemRegistry().getObject("diamond_hoe"),GameData.getItemRegistry().getObject("diamond_shovel"),GameData.getItemRegistry().getObject("diamond_pickaxe"),GameData.getItemRegistry().getObject("diamond_axe"),GameData.getItemRegistry().getObject("diamond_sword")};

    setTextureName("multitool:multitool");

    setMaxDamage(3000);

}

 

@Override

public Multimap getItemAttributeModifiers() {

if(contained.length>0){

        return contained[active].getItemAttributeModifiers();

} else {

return HashMultimap.create();

}

    }

 

    @Override

public boolean canHarvestBlock(Block par1Block, ItemStack itemStack){

    return contained[active].canHarvestBlock(par1Block, itemStack);

    }

 

@Override

public IIcon getIcon(ItemStack itemStack, int pass){

return contained[active].getIconFromDamage(0);

}

 

    @Override

public ItemStack onItemRightClick(ItemStack p_77659_1_, World p_77659_2_, EntityPlayer p_77659_3_)

    {

    if(!p_77659_2_.isRemote){

    if (Keyboard.isKeyDown(Keyboard.KEY_RSHIFT) || Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)){

        active=(active+1)%contained.length;

    } else {

    contained[active].onItemRightClick(p_77659_1_, p_77659_2_, p_77659_3_);

    System.out.println("Right-clicking "+contained[active].getUnlocalizedName());

    }

    }

        return p_77659_1_;

    }

   

    @Override

public Set<String> getToolClasses(ItemStack stack) {

        return contained[active].getToolClasses(stack);

    }

   

    @Override

public float func_150893_a(ItemStack p_150893_1_, Block p_150893_2_)

    {

        return contained[active].func_150893_a(p_150893_1_,p_150893_2_);

    }

   

    @Override

public int getHarvestLevel(ItemStack stack, String toolClass){

    return contained[active].getHarvestLevel(stack, toolClass);

    }

}

 

 

Sounds like you need to switch the return in Item#getItemUseAction based on the NBT too, though I'm not sure that'll work right...

 

Edit: Wait, that's another thing, you can't have a class variable changing the item, you have to put that in NBT, as it is now, if one player switches their tool, everyone's will switch.

Thanks for the thing about NBT. I noticed that would be a problem, but I didn't know how to fix it and was going to work on it later. I overrode getItemUseAction, but it still doesn't work. In the Item class, it says that getItemUseAction specifies the animation to use while right-clicking. My code doesn't execute the right-click function at all: the sword doesn't reduce damage and the hoe doesn't till dirt blocks.

 

Edit: Ok, I just fixed and tested the NBT thing. Apart from that, I'm still at square one as far as accessing each item's right-click action.

 

Here is my updated code:

 

 

package mcnutty.multitool;

 

import java.util.Set;

 

import net.minecraft.block.Block;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.EnumAction;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.util.IIcon;

import net.minecraft.world.World;

 

import org.lwjgl.input.Keyboard;

 

import com.google.common.collect.HashMultimap;

import com.google.common.collect.Multimap;

 

import cpw.mods.fml.common.registry.GameData;

 

public class ItemMultitool extends Item{

 

private Item[] contained;

 

public ItemMultitool(){

super();

setMaxStackSize(1);

setCreativeTab(CreativeTabs.tabMisc);

setUnlocalizedName("multitool");

contained=new Item[] {GameData.getItemRegistry().getObject("diamond_hoe"),GameData.getItemRegistry().getObject("diamond_shovel"),GameData.getItemRegistry().getObject("diamond_pickaxe"),GameData.getItemRegistry().getObject("diamond_axe"),GameData.getItemRegistry().getObject("diamond_sword")};

    setTextureName("multitool:multitool");

    setMaxDamage(3000);

}

 

private int getActive(ItemStack itemStack){

try{

return itemStack.stackTagCompound.getInteger("active");

} catch(NullPointerException e){

return 0;

}

}

 

@Override

public void onCreated(ItemStack itemStack, World world, EntityPlayer player) {

itemStack.stackTagCompound = new NBTTagCompound();

itemStack.stackTagCompound.setInteger("active",0);

}

 

@Override

    public Multimap getAttributeModifiers(ItemStack itemStack) {

return contained[getActive(itemStack)].getItemAttributeModifiers();

    }

 

    public int getDamage(ItemStack itemStack) {

        return contained[getActive(itemStack)].getDamage(itemStack);

    }

 

    @Override

public boolean canHarvestBlock(Block par1Block, ItemStack itemStack){

    return contained[getActive(itemStack)].canHarvestBlock(par1Block, itemStack);

    }

 

@Override

public IIcon getIcon(ItemStack itemStack, int pass){

return contained[getActive(itemStack)].getIconFromDamage(0);

}

 

    @Override

public EnumAction getItemUseAction(ItemStack itemStack)

    {

        return contained[getActive(itemStack)].getItemUseAction(itemStack);

    }

 

    @Override

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

    if(!world.isRemote){

    if (Keyboard.isKeyDown(Keyboard.KEY_RSHIFT) || Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)){

    if(itemStack.stackTagCompound==null){

    this.onCreated(itemStack, world, player);

    }

    int active=itemStack.stackTagCompound.getInteger("active");

    active=(active+1)%contained.length;

    itemStack.stackTagCompound.setInteger("active",active);

    } else {

    contained[getActive(itemStack)].onItemRightClick(itemStack, world, player);

//    System.out.println("Right-clicking "+contained[getActive(itemStack)].getUnlocalizedName());

    }

    }

        return itemStack;

    }

   

    @Override

public Set<String> getToolClasses(ItemStack itemStack) {

        return contained[getActive(itemStack)].getToolClasses(itemStack);

    }

   

    @Override

public float func_150893_a(ItemStack itemStack, Block p_150893_2_)

    {

        return contained[getActive(itemStack)].func_150893_a(itemStack,p_150893_2_);

    }

   

    @Override

public int getHarvestLevel(ItemStack itemStack, String toolClass){

    return contained[getActive(itemStack)].getHarvestLevel(itemStack, toolClass);

    }

}

 

 

Overriding onItemUse worked for the hoe, thanks. I removed the exception handling; you are totally right that it was a bad idea. I don't know what you mean about the server checking the keyboard. It seems to work fine when I tested it in-game.

 

Now I just need to figure out how to make it able to block when the sword is selected.

It seems to work fine when I tested it in-game.

You should try (!) to start a Dedicated Server with your mod.

 

I don't have access to a server. Would the solution be to put if(!world.isRemote) inside the keyboard check?

It seems to work fine when I tested it in-game.

You should try (!) to start a Dedicated Server with your mod.

 

I don't have access to a server. Would the solution be to put if(!world.isRemote) inside the keyboard check?

No, you have. Instead of pressing launch, select little arrow right next to it and select from dropdown server...

 

Server is a server. It has NO KEYBOARD. So it will crash on server. For that keys, you will need keybindings and packets...

I fixed everything you've mentioned, but I'm still having my original issue: when the sword is selected, the item doesn't block. I've done some debugging, and the onItemRightClick method of the contained sword is never called, even though the onItemRightClick of my item is called. Does anyone know why that is?

 

onItemRightClick method is here:

 

 

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

if(!world.isRemote){

if (player.isSneaking()){

    if(itemStack.stackTagCompound==null){

    this.onCreated(itemStack, world, player);

    }

    int active=itemStack.stackTagCompound.getInteger("active");

    active=(active+1)%contained.length;

    itemStack.stackTagCompound.setInteger("active",active);

    } else {

        getActiveItem(itemStack).onItemRightClick(getActiveStack(itemStack), world, player);

    }

    }

        return itemStack;

    }

 

 

getActiveItem returns the Item of the currently active ItemStack, in this case the ItemSword item.

bump

Never mind, found a solution. I moved "getActiveItem(itemStack).onItemRightClick(itemStack, world, player);" outside of "if(!world.isRemote)". I didn't do enough testing to figure out why this works, just that it does.