Jump to content

Recommended Posts

Posted

I set up my packet like in Diesieben's tutorial for my custom entity, but get an null pointer when I try sending one. I am not entirely sure how to set it up for entities, as don't know what to do in the onMessage() method, and this is where the error occurs.

 

public class GolemAttackTimerMessage implements IMessage
{   
private EntityGolem golem;
private float attackTimer; 

private NBTTagCompound tag;

public GolemAttackTimerMessage()
{

}

public GolemAttackTimerMessage(EntityGolem golem, float attackTimer)
{
	this.golem = golem;
	this.attackTimer = attackTimer;

	tag = new NBTTagCompound();
    }

@Override
public void fromBytes(ByteBuf buf)
{
	tag = ByteBufUtils.readTag(buf);
	attackTimer = tag.getFloat("attackTimer");
    }

@Override
public void toBytes(ByteBuf buf)
{
	ByteBufUtils.writeTag(buf, tag);
	tag.setFloat("attackTimer", attackTimer);
    }

public static class Handler implements IMessageHandler<GolemAttackTimerMessage, IMessage>
{
	@Override
	public IMessage onMessage(GolemAttackTimerMessage message, MessageContext ctx)
	{
		message.golem.setAttackTimer(message.attackTimer);
		return null; 
        }
    }
}

Posted

The side that sends the packet knows about the golem entity, but the side that receives it is a new instance of your message class and doesn't know about anything until it reads in the packet data.

 

For an entity like that, you need to send the entity Id (i.e. entity.getEntityId()) with the packet as well, then read that integer in during read, and retrieve the entity from the world when the packet processes.

Entity entity = player.worldObj.getEntityById(this.entityId);
if (entity instanceof EntityGolem) {
// continue processing
} else {
// log error message
}

Get the player from the current context via your proxy classes: see here and the ClientProxy implementation as well.

 

That said, if all you want to do is set the attack timer on the client side for your golem entity, use worldObj.setEntityState(customFlag) and handleHealthUpdate(byte flag) - they work in tandem to send byte flags to the client side, allowing the entity to do different things like display heart particles when in love or set the attack timer for the arm-swing animation like golems.

 

You can see how the vanilla golems do it just like that, and I prefer that to a packet when I can (though it sends a packet in the background) because it keeps everything encapsulated in the class.

Posted

Thanks for the responses :) I have now got everything set up like this, but the value of message.entityID is 0 so I must be doing something wrong somewhere, any ideas?

 

public class GolemAttackTimerMessage implements IMessage
{   
private int entityID;
private float attackTimer; 

private NBTTagCompound tag;

public GolemAttackTimerMessage()
{

}

public GolemAttackTimerMessage(int entityID, float attackTimer)
{
	tag = new NBTTagCompound();
	this.entityID = entityID;
	this.attackTimer = attackTimer;
    }

@Override
public void fromBytes(ByteBuf buf)
{
	tag = ByteBufUtils.readTag(buf);
	entityID = tag.getInteger("ID");
	attackTimer = tag.getFloat("attackTimer");
    }

@Override
public void toBytes(ByteBuf buf)
{
	ByteBufUtils.writeTag(buf, tag);
	tag.setInteger("ID", entityID);
	tag.setFloat("attackTimer", attackTimer);
    }

public static class Handler implements IMessageHandler<GolemAttackTimerMessage, IMessage>
{
	@Override
	public IMessage onMessage(GolemAttackTimerMessage message, MessageContext ctx)
	{
		Entity entity = null;

		if(ctx.side.isClient())
		{
			entity = golems.proxy.getPlayerEntity(ctx).worldObj.getEntityByID(message.entityID);

			System.out.println(message.entityID);
		}

		if(entity instanceof EntityGolem)
		{
			EntityGolem golem = (EntityGolem) entity;

			golem.setAttackTimer(message.attackTimer);
		}
		else
		{

		}

		return null; 
        }
    }
}

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Honestly, the forums are a back burner thing. Not many people use it. Best option is discord. I know that I haven't looked at the forums for more then admin tasks in quite a while. You're also best off not following tutorials which give you code. Knowing programming and reading the MC/Forge code yourself would be the best way to go.
    • on my last computer, i had a similar problem with forge/ neoforge mods but instead them launcher screen was black
    • I am trying to make a mod, all it is, a config folder that tells another mod to not require a dependency, pretty simple right.. well, I dont want whoever downloads my mod to have to download 4 other mods and then decide if they want 2 more that they kinda really need.. i want to make my mod basically implement all of these mods, i really dont care how it does it, ive tried putting them in every file location you can think of, ive downloaded intellij, mcreator, and tried vmware but thats eh (had it from school). I downloaded them in hopes theyd create the correct file i needed but honestly im only more lost now. I have gotten my config file to work, if i put all these mods into my own mods folder and the config file into the config and it works (unvbelievably) but i want to share this to everyone else, lets just say this mod will legitimately get 7M downloads.  I tried putting them in a run folder then having it create all the contents in that for a game (mods,config..etc) then i drop the mods in and all the sudden i cant even open the game, like it literally works with my own world i play on, but i cant get it to work on any coding platform, they all have like built in java versions you cant switch, its a nightmare. I am on 1.20.1 I need Java 17 (i dont think the specific versions of 17 matter) I have even tried recreating the mods i want to implement and deleting import things like net.adamsandler.themodsname and replacing it with what mine is. that only creates other problems, where im at right now is i got the thing to start opening then it crashes, closest ive gotten it, then it just says this  exception in thread "main" cpw.mods.niofs.union.unionfilesystem$uncheckedioexception: java.util.zip.zipexception: zip end header not found caused by: java.util.zip.zipexception: zip end header not found basically saying theres something wrong with my java.exe file, so i tried downloading so many different versions of java and putting them all in so many different spots, nothing, someone online says its just a mod that isnt built right so i put the mod into an editor and bunch of errors came up, id post it but i deleted it on accident, i just need help integrating mods
    • Vanilla 1.16.5 Crash Report [#L2KYKaK] - mclo.gs  
    • Hello, probably the last update, if anyone has the same problem or this can be of any help, the answer was pretty simple, textures started rendering just using a Tesselator instead of a VertexConsumer given by a MultibufferSource and a RenderType, pretty simple
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.