Hey,

Im trying to make an item and when you right click it you will get another item (same one) and this:

 

@Override
public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player) {
        player.inventory.addItemStackToInventory(new ItemStack(this));
        return stack ;
    }

 

i know why but is there any way to solve it ?

See that the return value is an ItemStack? Return a different one. The one you have, 'stack', is the ItemStack that called the method.

Basically what i need to do - the current stack + another one.

Well, you can't have two stacks in one inventory slot, so you'll need to put one of them somewhere else. You can use player.inventory.addItemStackToInventory(new ItemStack(whatever)) to do just that, and then return the original stack as you have it there.

I did that here :

@Override
public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player) {
        player.inventory.addItemStackToInventory(new ItemStack(this));
        return stack ;
    }

 

or i dont understand you

You don't understand java and/or ItemStack.

 

A method that returns object (ItemStack) can't suddenly return two stacks.

What exacly do you need to do?

 

Right now:

@Override
public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player) { // When player right-clicks
        player.inventory.addItemStackToInventory(new ItemStack(this)); //add to player's first free or stackable slot a new ItemStack of this item
        return stack ; // return the stack you have right-clicked with
    }

So its not possible then...

You should add the itemstack on the server side, ie: !world.isRemote. You might have to call player.inventoryContainer.detectAndSendChanges(); after you add the new itemstack for it to update to the client.

WHAT is not possible? I don't think anyone in this thread actually understood what you want to happen.

 

I want just add the same item when the item is right clicked no matter what. Idealy the onItemRightClick would be void.

I just dont know how to deal with the return statement.

I just tried this:

 

@Override
public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player){
if (!world.isRemote){
	player.inventory.addItemStackToInventory(new ItemStack(SirenMod.FireExtinguisherItem, 1));
	player.inventoryContainer.detectAndSendChanges();
}
return stack;		
}

 

and it worked fine for me.

Wow cool i just dont understand the detectAndSendChanges thing but thank you very much

detectAndSendChanges() scans the players server side inventory and pushes the changes to the client, forcing it to update.