Jump to content

Recommended Posts

Posted

So really this is a weird bug I'm having. I've tried and checked and just can't find what's wrong with it. Basically there's an inventory with 29 slots, 27 are storage slots, 1 is a "foodprint" (blueprint) slot, and the final is the output slot. When the entity updates it's supposed to check if the item in the foodprint can be crafted (So if the foodprint is bread it needs 3 wheat in the storage slots) and if it can, it will take 3 wheat, and put one bread in the output slot. However after the first time the item is crafted per game instance (So you restart and it works again) the recipe outputs stack size goes down to 0 for some reason and any bread put into the output slot is fake and upon trying to eat it, it disappears. Here's the code, any help would be nice

 

@Override public void updateEntity() {
	if (this.worldObj.isRemote) return;
	if (ticksUntilCheck > 0) {
		ticksUntilCheck --;
		return;
	} else {
		if (!recipesCached) {
			if (getStackInSlot(27) != null) {
				ItemStack stack = getStackInSlot(27);
				if (stack.getItem() instanceof ItemFoodprint) {
					ItemStack stored = new ItemStack(((ItemFoodprint) stack.getItem()).getStoredItem(stack));
					for (Object obj : CraftingManager.getInstance().getRecipeList()) {
						if (obj instanceof ShapedRecipes) {
							ShapedRecipes recipe = (ShapedRecipes) obj;
							if (recipe.getRecipeOutput().getItem().equals(stored.getItem())) {
								cachedRecipes.add(new ShapelessRecipes(recipe.getRecipeOutput().copy(), Lists.newArrayList(recipe.recipeItems)));
							}
						} else if (obj instanceof ShapelessRecipes) {
							ShapelessRecipes recipe = (ShapelessRecipes) obj;
							if (recipe.getRecipeOutput().getItem().equals(stored.getItem())) {
								cachedRecipes.add(new ShapelessRecipes(recipe.getRecipeOutput().copy(), Lists.newArrayList(recipe.recipeItems)));
							}
						}
					}
					recipesCached = true;
				}
			}
		}

		ticksUntilCheck = 10;
		if (getStackInSlot(27) == null) return;
		ItemStack stack = getStackInSlot(27);
		if (!(stack.getItem() instanceof ItemFoodprint)) return;
		ItemFoodprint print = (ItemFoodprint) stack.getItem();
		if (print.isBlank(stack)) return;
		Item foodStored = print.getStoredItem(stack);
		if (getStackInSlot(28) != null) {
			if (getStackInSlot(28).getItem() != foodStored) return;
		}

		recipescan: for (ShapelessRecipes reciperaw : cachedRecipes) {
			ShapelessRecipes recipe = new ShapelessRecipes(reciperaw.getRecipeOutput().copy(), Lists.newArrayList(reciperaw.recipeItems));
			if (getStackInSlot(28) != null) {
				if (getStackInSlot(28).stackSize + recipe.getRecipeOutput().stackSize > getStackInSlot(28).getMaxStackSize()) continue recipescan;
			}
			HashMap<Item, Integer> reqItems = new HashMap<Item, Integer>();
			for (Object obj : recipe.recipeItems) {
				if (obj instanceof ItemStack) {
					ItemStack ing = (ItemStack) obj;
					if (reqItems.containsKey(ing.getItem())) {
						reqItems.put(ing.getItem(), reqItems.get(ing.getItem()) + 1);
					} else {
						reqItems.put(ing.getItem(), 1);
					}
				}
			}
			HashMap<Item, Integer> storedItems = new HashMap<Item, Integer>();
			slotscan: for (int slot = 0; slot < 27; slot ++) {
				if (inventory[slot] == null) continue slotscan;
				Item storedItem = inventory[slot].getItem();
				if (storedItems.containsKey(storedItem)) {
					storedItems.put(storedItem, storedItems.get(storedItem) + inventory[slot].stackSize);
				} else {
					storedItems.put(storedItem, inventory[slot].stackSize);
				}
			}
			for (Item item : reqItems.keySet()) {
				if (!storedItems.containsKey(item)) continue recipescan;
				if (storedItems.get(item) < reqItems.get(item)) continue recipescan;
			}
			slotscan: for (int slot = 0; slot < 27; slot ++) {
				if (this.inventory[slot] == null) continue slotscan;
				if (reqItems.containsKey(this.inventory[slot].getItem())) {
					int toTake = reqItems.get(this.inventory[slot].getItem());
					if (toTake <= this.inventory[slot].stackSize) {
						reqItems.remove(this.inventory[slot].getItem());
						this.inventory[slot].stackSize -= toTake;
						if (this.inventory[slot].stackSize == 0) this.inventory[slot] = null;
					} else {
						int newToTake = toTake - this.inventory[slot].stackSize;
						reqItems.put(this.inventory[slot].getItem(), newToTake);
						this.inventory[slot] = null;
					}
				}
			}
			if (this.inventory[28] == null) {
				this.inventory[28] = recipe.getRecipeOutput();
			} else {
				this.inventory[28].stackSize = this.inventory[28].stackSize + recipe.getRecipeOutput().stackSize;
			}
			break recipescan;
		}
	}
}

Posted

That's why when I cache the recipe and start the recipe scan loop I create a new ShapelessRecipes with what should be a copy

 

recipescan: for (ShapelessRecipes reciperaw : cachedRecipes) {
ShapelessRecipes recipe = new ShapelessRecipes(reciperaw.getRecipeOutput().copy(), Lists.newArrayList(reciperaw.recipeItems));

 

Shouldn't that be enough as long as I just use recipe everywhere and not reciperaw, or can you point out where I've messed it up

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Reach Out To Rapid Digital: What sapp Info: +1 41 4 80 7 14 85 Email INFO: rap iddi gita lrecov ery @ exe cs. com Hello, my name is Jayson, and I’m 35 years old from the United Kingdom. My family and I recently endured an incredibly challenging experience that I wouldn’t wish on anyone. We became victims of a cryptocurrency investment fraud scheme that saw us lose a staggering $807,000 in USDT and Bitcoins. The fraudsters had created a convincing facade, and we were lured into investing, only to discover later that the platform was a complete scam. We were left devastated, not just financially, but emotionally, as we had trusted these people and believed in the legitimacy of the investment. After the initial shock wore off, we desperately searched for ways to recover the lost funds. It seemed like an impossible task, and we felt as though there was no hope. That’s when, by sheer luck, we stumbled across a post about Rapid Digital Recovery, a cryptocurrency and funds recovery organization with a proven track record in cybersecurity and fraud recovery. We decided to reach out to them, and from the first interaction, we were impressed with their professionalism and transparency. They explained the recovery process in detail and reassured us that they had the skills and expertise to track down the perpetrators and recover our funds. This gave us a renewed sense of hope, something we hadn’t felt in months. What truly stood out during our experience with Rapid Digital Recovery was their dedication to the recovery process. The team went above and beyond, using sophisticated tracking tools and cyber forensics to gather critical information. Within a matter of weeks, they had successfully located the funds and traced the scam back to the fraudsters responsible. They worked with the authorities to ensure the criminals were held accountable for their actions. To our relief, the team at Rapid Digital Recovery was able to recover every single penny we had lost. The funds were returned in full, and the sense of closure we felt was invaluable. We couldn’t have imagined such a positive outcome in the early stages of our recovery journey, and we are deeply grateful for the work they did. If you ever find yourself in a similar situation, I highly recommend contacting Rapid Digital Recovery. Their expertise, transparency, and dedication to their clients make them the go-to choice for anyone seeking to recover lost cryptocurrency or funds. They truly gave us back our financial future.  
    • This is my first time modding anything, so maybe just skill issue. I'm using Forge 54.0.12 and Temurin 21.0.5+11-LTS I wanted to create a custom keybind and to check whether it works I'd like to send a chat message. I tried using Minecraft.getInstance().player.sendSystemMessage(Component.literal("test")); but IntelliJ couldnt resolve sendSystemMessage(...). Since I saw people using it in earlier versions, I tried the same thing with 1.20.6(- 50.1.0), where it works fine, now I can't figure out if this is intentional and whether there are other options for sending chat messages. On that note, is there more documentation than https://docs.minecraftforge.net/en/1.21.x/? It seems very incomplete compared to something like the Oracle Java docs
    • Hi, i'm having this error and I wanna fix it. we try: -Reload drivers -Eliminate .minecraft -Eliminate Java -Restart launcher -Verify if minecraft is using gpu -Mods  in .minecraft is empty -Install the latest and recomended version of forge idk what i have to do, help me pls. the lastest log is: https://mclo.gs/WAMao8x  
    • Read the FAQ, Rule #2. (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/)  
    • The link to your log does not work, it says it is forbidden, Error, this is a private paste or is pending moderation.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.