Jump to content

Doing more damage based on NBT


Recommended Posts

I'm trying to make my item do more damage than normal based on its NBT. This is what I've been trying but it makes all the entities in the world freeze.



public void hitEntity(LivingHurtEvent event){
	System.out.println("Hit entity " + event.entityLiving.getHealth());			
	if(event.source instanceof EntityDamageSource){

		EntityDamageSource source = (EntityDamageSource) event.source;
		if(source.getEntity() instanceof EntityLivingBase){
			EntityLivingBase attackerEntity = (EntityLivingBase) source.getEntity();

			if(attackerEntity.getHeldItem() != null && attackerEntity.getHeldItem().getItem() == ItemManager.rpgSword){
				ItemStack is = attackerEntity.getHeldItem();
				int damage = is.stackTagCompound.getInteger("totalDamage")/25;
				event.entityLiving.attackEntityFrom(DamageSource.causeMobDamage(attackerEntity), damage);






What am I doing wrong and how do I make my item do more damage based on NBT?

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Link to comment
Share on other sites

1. NBTs can be null (1st check if stack has nbt)

2. If you have your own sword - do NOT use events. Events are for vanilla (and maybe other mods) only.


If it doesn't crash:

Make prints after each line - at which it stops?



1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

While I don't know how to fix this, I'm pretty sure that that's not how you use hitEntity. I believe it's used more like this:

public boolean hitEntity(ItemStack item, EntityLivingBase target, EntityLivingBase player)
        target.worldObj.addWeatherEffect(new EntityLightningBolt(target.worldObj, target.posX, target.posY, target.posZ));
        item.damageItem(1, player);
        return true;

(this code is for a lightning sword, but I think you get the idea)

I'll put something here when I have something of value I need to put at the end of every post. For now it's this mostly pointless text.

Link to comment
Share on other sites

You want to override getAttributeModifiers and then change the damage attribute, like shown in the ItemSword class. Just choose the version of getAttributeModifiers that takes an ItemStack.


Awesome that worked thanks!

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.