Jump to content

[SOLVED][1.8] Ores not generating


JimiIT92

Recommended Posts

Hi, i'm trying to generate ores in my world but the code seems not working :/

The first thing i've done is a world generator class

 

public class WorldGenMinableMW implements IWorldGenerator {

@Override
public void generate(Random random, int chunkX, int chunkZ, World world,
		IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

	switch(world.provider.getDimensionId()) {
		case 0:
			generateOverworld(random, world, chunkX*16, chunkZ*16);
			break;
		default:
			generateOverworld(random, world, chunkX*16, chunkZ*16);
	}

}

private void generateOverworld(Random random, World world, int x, int z) {
	addOres(MWBlocks.ruby_ore, world, random, x, z, 4, 5, 0, 16);
	addOres(MWBlocks.sapphire_ore, world, random, x, z, 4, 5, 0, 16);
	addOres(MWBlocks.copper_ore, world, random, x, z, 6, 10, 0, 30);
	addOres(MWBlocks.bronze_ore, world, random, x, z, 6, 10, 0, 30);
	addOres(MWBlocks.silver_ore, world, random, x, z, 6, 10, 0, 20);
	addOres(MWBlocks.aluminium_ore, world, random, x, z, 6, 10, 0, 20);
	addOres(MWBlocks.pyrite_ore, world, random, x, z, 8, 20, 0, 50);
	addOres(MWMetadataBlocks.marble.getStateFromMeta(0).getBlock(), world, random, x, z, 6, 15, 0, 30);
	addOres(MWMetadataBlocks.marble.getStateFromMeta(1).getBlock(), world, random, x, z, 6, 15, 0, 30);

	for(int i = 0; i < 2; i++)
	{
		int randPosX = x + random.nextInt(16);
		int randPosY = random.nextInt(250);
		int randPosZ = z + random.nextInt(16);
		(new WorldGenFlowers((BlockFlower)MWBlocks.blue_flower, BlockFlower.EnumFlowerType.DANDELION)).generate(world, random, new BlockPos(randPosX, randPosY, randPosZ));
	}
}

private void addOres(Block block, World world, Random random, int blockXpos, int blockZpos, int MaxVein, int spawnChance, int minY, int maxY) {

	WorldGenMinable minable = new WorldGenMinable(block.getDefaultState(), random.nextInt(MaxVein));
	for (int i = 0; i < spawnChance; i++) {
		int posX = blockXpos + random.nextInt(16);
		int posZ = blockZpos + random.nextInt(16);
		int posY = minY + random.nextInt(maxY - minY);
		minable.generate(world, random, new BlockPos(posX, posZ, posY));
	}

}
}

 

The flower is generated while the ores not, i don't know why. In the main mod class, in the Init event, i register my world generator

 

GameRegistry.registerWorldGenerator(new WorldGenMinableMW(), 1);

 

According to some tutorials the code should be right, so why the ores doesn't generate? :/

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

new BlockPos(posX, posZ, posY)

You've made a mistake on that line, so double check it.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.