Jump to content

Weird vanilla code


ImaFool
 Share

Recommended Posts

Hey guys, I found this piece of code in the BlockTorch class:

    public int getMetaFromState(IBlockState state)
    {
        byte b0 = 0;
        int i;

        switch (BlockTorch.SwitchEnumFacing.FACING_LOOKUP[((EnumFacing)state.getValue(FACING)).ordinal()])
        {
            case 1:
                i = b0 | 1;
                break;
            case 2:
                i = b0 | 2;
                break;
            case 3:
                i = b0 | 3;
                break;
            case 4:
                i = b0 | 4;
                break;
            case 5:
            case 6:
            default:
                i = b0 | 5;
        }

        return i;
    }

Wouldn't this do the exact same thing as:

    public int getMetaFromState(IBlockState state)
    {
        return BlockTorch.SwitchEnumFacing.FACING_LOOKUP[((EnumFacing)state.getValue(FACING)).ordinal()]
    }

?

Then why is this so big?

Link to comment
Share on other sites

Hi

 

Well actually I think it wouldn't do the same thing...

            case 5:

            case 6:

            default:

                i = b0 | 5;

 

But most of the time when you find code like this that looks a bit strange, it's been autogenerated by the decompiler and probably looks very different in the native code.

 

-TGG

Link to comment
Share on other sites

This is due to the way switch on enum gets compiled.

The original code was probably something like this:

 

int result = 0;
switch (state.getValue(FACING)):
    case EAST:
        result |= 1;
        break;
    case WEST:
        result |= 2;
        break;

 

And so on. The SwitchEnumFacing class is completely synthetic and generated by the compiler to make the switch work.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.