Jump to content

Recommended Posts

Posted

I've upgraded my mod from 1.7 to 1.8. Everything looks good except... My enchantment is missing (or hidden). It hasn't shown up in an enchanting table, and there's no book in creative inventory (there was in v1.7).

 

I've walked through the constructors in Eclipse's debugger; the super executes, and all assignments look OK (then I "setName" and "addToBookList"). I've looked at how vanilla enchantments are constructed, and my addition looks right. I'd post a log or error, but there's nothing to see. It just vanishes silently, and the game comes up without it.

 

Is there some new twist to enchantments in mc1.8? Is there yet another call to be made before my enchantment will be seen? Do enchantments now need json files too? I've scoured the upgrade tutorials and forums, and I don't see any hints. I've tried resource locations both with and without a "<mod>:" prefix; no joy.

 

What am I missing?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

Enchantment.addBookToList(yourenchantment) should add it to the creative.

Yeah, I did all that (and it was working) back in 1.7. Something is missing in 1.8. Maybe there's some trick to the resource location in the new version? There isn't any texture, so I'm not sure where the resource should be located under the new scheme.

 

I'll look again tomorrow with fresh eyes.

 

 

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

Okay, time to show some source code. Here's my extension of the Enchantment interface:

 

package jrfnethergem;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnumEnchantmentType;
import net.minecraft.init.Items;
import net.minecraft.item.ItemHoe;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.common.util.EnumHelper;

public class classSmartHarvestEnchantment extends Enchantment {

  public static final EnumEnchantmentType enchantType = EnumHelper.addEnchantmentType ("farmer");
  private static final int SMART_HARVEST_ID = enchantType.ordinal ();
  protected static ResourceLocation resourceLoc = new ResourceLocation ("SmartHarvest");

  public classSmartHarvestEnchantment() {
    super (SMART_HARVEST_ID, resourceLoc, 11, enchantType); // Assigns effectId, weight & type; adds to list/map
    this.setName ("smartHarvest");
    this.addToBookList (this);
  }

  /*
   * The minimal value of enchantability needed on the enchantment level passed.
   */
  public int getMinEnchantability(int level) {
    return 11;
  }

  /*
   * The maximum value of enchantability allowed on the enchantment level passed. It is meant only to shift toward high-levels for
   * enchantments that have multiple levels. SmartHarvest has only one level (1), so this is irrelevant. This function has no effect
   * on the chance for multiple enchantments.
   */
  public int getMaxEnchantability(int level) {
    return 50;
  }

  @Override
  public boolean canApply(ItemStack s) {        // Applies only to hoes
    return (s.getItem () instanceof ItemHoe);
  }
}

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.