Jump to content

[1.8] Blockstates and Metadata , Blocks dont taking the variation model


Recommended Posts

Posted

 

So i resolved the blockstates, metadata block, no errors, but i have some problems with registering i think. First my block didnt appear in the inventory nor the game, so i created a new block like always, but using the blockstate class. all the 16 block variations appear but without model or texture when placed and in the hand.

 

My block variation class

package raflex14.pixarcraft.blocks;

import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import raflex14.pixarcraft.PixarCraft;

public class Balloon extends Block 
{
public enum EnumType implements IStringSerializable{
	WHITE(0, "white"),
    BLACK(1, "black"),
	GRAY(2, "gray"),
	BLUE(3, "blue"),
	LIGHT_GRAY(4, "light_gray"),
	BROWN(5, "brown"),
	CYAN(6, "cyan"),
	GREEN(7, "green"),
	LIGHT_BLUE(8, "light_blue"),
	LIME(9, "lime"),
	MAGENTA(10, "magenta"),
	ORANGE(11, "orange"),
	PINK(12, "pink"),
	PURPLE(13, "purple"),
	RED(14, "red"),
	YELLOW(15, "yellow");

	public int getMetadata()
    {
      return this.meta;
    }

    @Override
    public String toString()
    {
      return this.name;
    }

    public static EnumType byMetadata(int meta)
    {
      if (meta < 0 || meta >= META_LOOKUP.length)
      {
        meta = 0;
      }

      return META_LOOKUP[meta];
    }

    public String getName()
    {
      return this.name;
    }

    private final int meta;
    private final String name;
    private static final EnumType[] META_LOOKUP = new EnumType[values().length];

    private EnumType(int i_meta, String i_name)
    {
      this.meta = i_meta;
      this.name = i_name;
    }

    static
    {
      for (EnumType colortype : values()) {
        META_LOOKUP[colortype.getMetadata()] = colortype;
      }
    }
}

@Override
protected BlockState createBlockState() {
    return new BlockState(this, new IProperty[] { COLORTYPE });
}





public Balloon() {
        super(Material.cloth);
        this.setCreativeTab(PixarCraft.tabPixarCraftBlocks);
    }

@Override
  public int getRenderType() {
    return 3;
  }

public static final PropertyEnum COLORTYPE = PropertyEnum.create("colortype", Balloon.EnumType.class);

@Override
  public int damageDropped(IBlockState state)
  {
    EnumType enumType = (EnumType)state.getValue(COLORTYPE);
    return enumType.getMetadata();
  }

@Override
  @SideOnly(Side.CLIENT)
  public void getSubBlocks(Item itemIn, CreativeTabs tab, List list)
  {
    EnumType[] allColours = EnumType.values();
    for (EnumType colortype : allColours) {
      list.add(new ItemStack(itemIn, 1, colortype.getMetadata()));
    }
  }

@Override
  public IBlockState getStateFromMeta(int meta)
  {
    int colourbits = (meta & 0x0c) >> 2; // 0x0c is hexadecimal, in binary 1100
    EnumType colortype = EnumType.byMetadata(colourbits);
    return this.getDefaultState().withProperty(COLORTYPE, colortype);
  }

@Override
  public int getMetaFromState(IBlockState state)
  {
    EnumType colortype = (EnumType)state.getValue(COLORTYPE);
    

    
    int colourbits = colortype.getMetadata() << 2;
    return  colourbits;
  }





@Override
  public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing blockFaceClickedOn, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
  {


    EnumType colortype = EnumType.byMetadata(meta);
    // find the quadrant the player is facing


    return this.getDefaultState().withProperty(COLORTYPE, colortype);
  }



}

 

My Itemblockvariation class

package raflex14.pixarcraft.items;

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import raflex14.pixarcraft.blocks.Balloon;

public class ItemBalloon extends ItemBlock{

  public ItemBalloon(Block block)
  {
    super(block);
    this.setMaxDamage(0);
    this.setHasSubtypes(true);
  }

  @Override
  public int getMetadata(int metadata)
  {
    return metadata;
  }


  @Override
  public String getUnlocalizedName(ItemStack stack)
  {
    Balloon.EnumType colortype = Balloon.EnumType.byMetadata(stack.getMetadata());
    return super.getUnlocalizedName() + "." + colortype.toString();
  }

}

 

Startup Client

package raflex14.pixarcraft.proxy;

import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelBakery;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;
import raflex14.pixarcraft.blocks.Balloon;

public class StartupClientOnly
{
  public static void preInitClientOnly()
  {
    Item itemBalloon = GameRegistry.findItem("pc", "balloon_variants");

    
    ModelBakery.addVariantName(itemBalloon, "pc:balloon_variants_blue",
            "pc:balloon_variants_green",
            "pc:balloon_variants_red",
            "pc:balloon_variants_yellow",
            "pc:balloon_variants_cyan",
"pc:balloon_variants_light_blue",
"pc:balloon_variants_white",
"pc:balloon_variants_black",
"pc:balloon_variants_gray",
"pc:balloon_variants_light_gray",
"pc:balloon_variants_pink",
"pc:balloon_variants_magenta",
"pc:balloon_variants_lime",
"pc:balloon_variants_purple",
"pc:balloon_variants_brown",
"pc:balloon_variants_orange");
    		
    
  }

  public static void initClientOnly()
  {
   
    Item itemBalloon = GameRegistry.findItem("pc", "balloon_variants");
    ModelResourceLocation itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_blue", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.BLUE.getMetadata(), itemModelResourceLocation);

    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_green", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.GREEN.getMetadata(), itemModelResourceLocation);

    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_red", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.RED.getMetadata(), itemModelResourceLocation);

    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_yellow", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.YELLOW.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_cyan", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.CYAN.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_brown", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.BROWN.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_pink", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.PINK.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_magenta", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.MAGENTA.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_purple", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.PURPLE.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_light_blue", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.LIGHT_BLUE.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_gray", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.GRAY.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_light_gray", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.LIGHT_GRAY.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_black", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.BLACK.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_white", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.WHITE.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_lime", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.LIME.getMetadata(), itemModelResourceLocation);
    
    itemModelResourceLocation = new ModelResourceLocation("pc:balloon_variants_orange", "inventory");
    Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(itemBalloon, Balloon.EnumType.ORANGE.getMetadata(), itemModelResourceLocation);
  }

  public static void postInitClientOnly()
  {
  }
}

 

StartupCommon

package raflex14.pixarcraft.proxy;

import net.minecraftforge.fml.common.registry.GameRegistry;
import raflex14.pixarcraft.blocks.Balloon;
import raflex14.pixarcraft.items.ItemBalloon;


public class StartupCommon
{
  public static Balloon balloon;  

  public static void preInitCommon()
  {
   
    balloon = (Balloon)(new Balloon().setUnlocalizedName("balloon_variants"));
    GameRegistry.registerBlock(balloon, ItemBalloon.class, "balloon_variants");
   

  }

  public static void initCommon()
  {
  }

  public static void postInitCommon()
  {
  }
}

 

And finally

Blockstate

{
    "variants": {
    "COLORTYPE=red": { "model": "pc:balloon_variants_model_red"},
    "COLORTYPE=green": { "model": "pc:balloon_variants_model_green" },
    "COLORTYPE=yellow": { "model": "pc:balloon_variants_model_yellow" },
    "COLORTYPE=blue": { "model": "pc:balloon_variants_model_blue" },
"COLORTYPE=brown": { "model": "pc:balloon_variants_model_brown" },
"COLORTYPE=cyan": { "model": "pc:balloon_variants_model_cyan" },
"COLORTYPE=white": { "model": "pc:balloon_variants_model_white" },
"COLORTYPE=black": { "model": "pc:balloon_variants_model_black" },
"COLORTYPE=gray": { "model": "pc:balloon_variants_model_gray" },
"COLORTYPE=light_gray": { "model": "pc:balloon_variants_model_light_gray" },
"COLORTYPE=purple": { "model": "pc:balloon_variants_model_purple" },
"COLORTYPE=magenta": { "model": "pc:balloon_variants_model_magenta" },
"COLORTYPE=orange": { "model": "pc:balloon_variants_model_orange" },
"COLORTYPE=lime": { "model": "pc:balloon_variants_model_lime" },
"COLORTYPE=light_blue": { "model": "pc:balloon_variants_model_light_blue" },
"COLORTYPE=pink": { "model": "pc:balloon_variants_model_pink" }    
    }
}

Posted

i fixed the code but the block doesnt render

Then post your updated code. Also, next time, please be more specific than 'block doesn't render'.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

In your blockstate file try changing all the variants name (example BLACK, GREEN, ecc) with their respective name in the constructor (so BLACK will turn "black", WHITE will turn "white" and so on)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.