I think I'm just blind, or plain stupid.

[TomTheBeast]

Beacuse I'm lazy there's only a TLDR.

TL;DR: I have two methods in the same class, called at the same time in this case.  One of them outputs the correct 'energy' value, the other always returns 0, why?

 

Works:

@Override
    protected boolean addEnergy(int energy)
    {
        if (this.energy >= (this.energyCap * this.energyCapMultiplier))
        {
            return false;
        }
        this.energy += energy;
        if (this.energy > this.energyCap * this.energyCapMultiplier)
            this.energy = this.energyCap * this.energyCapMultiplier;
        System.out.println(this.getName() + " at " + this.getPos().toString() + ", added " + energy + " " + Reference.ENERGY_UNIT + "; it now has " + this.energy + " " + Reference.ENERGY_UNIT + ".");
        return true;
    }

 

DOESN'T WORK:

protected void sendEnergy()
    {
        if (checkLink()) 
        {
            int minEnergy = (getEnergyDistributeCap() * getEnergyDistributeCapMultiplier()) / 4;
            if (energy >= minEnergy)
            {
                if (link.sendEnergy(minEnergy, this.getPos()))
                {
                    //removeEnergy(minEnergy);
                }
            } 
            else
            {
                System.out.println("Not enough energy, MinEnergy:" + minEnergy + ", EnergyDistributeCap:" + getEnergyDistributeCap() + ", EDCM:" + getEnergyDistributeCapMultiplier() + ", Energy:" + energy);
            }
        }
    }

[Ernio]

One output is server-side, the "0" is on client. You need packets to update client's value. Note that you don't always need all data on clients (mostly for rendering).

[TomTheBeast]

They're in the exact same class, being called at the same time, there is no client and server effect in this at all.

[jeffryfisher]

How can the 2nd method even return zero? It's return "type" is void, so assigning it to an L-value should earn you a warning from Eclipse.

[TomTheBeast]

Post more code, where are these methods called from?

 

It's all in a tile entity class, and called on update,

 

update

@Override
    public void update()
    {
        generateEnergy();
        sendEnergy();

    }

 

sendEnergy()

protected void generateEnergy()
    {
        if (fuel != null)
        {
            int value = Fuel.getFuelValue(fuel.getUnlocalizedName().substring(5));
            if (sendEnergy(value, null))
            {
                decrStackSize(0, 1);
            }
        }
    }

 

sendEnergy(int,BlockPos)

@Override
    public boolean sendEnergy(int energy, BlockPos pos)
    {
        energyRecievedBlockPos = pos;
        return addEnergy(energy);
    }

 

addEnergy(above in first post)

@Override
    protected boolean addEnergy(int energy)
    {
        if (this.energy >= (this.energyCap * this.energyCapMultiplier))
        {
            return false;
        }
        this.energy += energy;
        if (this.energy > this.energyCap * this.energyCapMultiplier)
        {
            this.energy = this.energyCap * this.energyCapMultiplier;
        }
        System.out.println(this.getName() + " at " + this.getPos().toString() + ", added " + energy + " " + Reference.ENERGY_UNIT + "; it now has " + this.energy + " " + Reference.ENERGY_UNIT + ".");
        return true;
    }

 

sendEnergy() (posted above in firstpost)

protected void sendEnergy()
    {
        if (checkLink())
        {
            int minEnergy = (getEnergyDistributeCap() * getEnergyDistributeCapMultiplier()) / 4;
            if (energy >= minEnergy)
            {
                if (link.sendEnergy(minEnergy, this.getPos()))
                {
                    //removeEnergy(minEnergy);
                }
            } else
            {
                System.out.println("Not enough energy, MinEnergy:" + minEnergy + ", EnergyDistributeCap:" + getEnergyDistributeCap() + ", EDCM:" + getEnergyDistributeCapMultiplier() + ", Energy:" + energy);
            }
        }
    }

[TomTheBeast]

How can the 2nd method even return zero? It's return "type" is void, so assigning it to an L-value should earn you a warning from Eclipse.

 

I just used the term return to be lazy, I mean when the method reaches the sout, it prints 0, every time, where as the other method works perfectly fine and prints the correct value.

[TomTheBeast]

Already spotted a problem: update() is called on client and server, but energy transfers should be server only.

 

I'm new to MC modding, could you explain why? I kinda understand the concept of what you mean, but I don't follow fully; and how could I prevent that? using the World.isRemote boolean?

[TomTheBeast]

Well, Minecraft runs in "two parts". Server and Client. The server simulates the world, the client just displays it (basically). You can check whether or you are on server or client by using world.isRemote, yes.

 

Right, that's obvious, but how does the client/server work together in SMP and SP?  Like in SP, is there a instance of the server and client running?, and if there is a instance of a server and client running, would there be any real difference than running a SMP server, to where the client/server aren't integrated into eachother?

I'm just trying to think ahead incase I have to do something special for something to work on SMP if it works fine on SP.

[jabelar]

Well, Minecraft runs in "two parts". Server and Client. The server simulates the world, the client just displays it (basically). You can check whether or you are on server or client by using world.isRemote, yes.

 

Right, that's obvious, but how does the client/server work together in SMP and SP?  Like in SP, is there a instance of the server and client running?, and if there is a instance of a server and client running, would there be any real difference than running a SMP server, to where the client/server aren't integrated into eachother?

I'm just trying to think ahead incase I have to do something special for something to work on SMP if it works fine on SP.

 

Yes, for the most part in SP you can think of it as a "separate" server and client both running in same JVM. That is the one gotcha though -- that it is in same JVM -- because when you get to the topic of sided proxies there are some classes that are only guaranteed to be loaded on one side or the other. In SMP there is different JVM running the server and client so if you don't handle the sided proxy properly it will fail, however such problems can be masked in JVM because each side might still be able to "see" the class loaded on the other side. Anyway, my point is you should test pretty regularly in SMP because SP can mask some issues. Hopefully you see what I mean.

 

By the way, using Eclipse you can launch the server and client (or even multiple clients) simultaneously provided you have enough system memory in your computer. So you can test SMP on single computer.

 

Some people get confused about the idea of sided proxy versus the World#isRemote check. World#isRemote is used in cases where the code may run on both sides and you need to distinguish (this is your case with the onUpdate() method in your question above). Side proxies are used when you need to access classes, methods or fields that are marked @SideOnly and therefore are only guaranteed to load on that side.