Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED] [1.8] Custom Painting spawned but invisible

JimiIT92

By JimiIT92
in Modder Support

 Share

Recommended Posts

JimiIT92 Dragon Slayer

JimiIT92

Posted
Posted

As by title, i have a custom Item painting. I do a print in the code to see if spawns the paint and it actually does, also when i break the supporting blocks it drops the item as well, but the painting itself is not rendering in world.

This is my ItemCustomPainting class

package blaze.items;

import blaze.core.BLTabs;
import blaze.entities.EntityPaintingEB;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;

public class ItemCustomPainting extends Item
{
    private final Class hangingEntityClass;

    public ItemCustomPainting(Class entityClass)
    {
        this.hangingEntityClass = entityClass;
        this.setCreativeTab(BLTabs.tabBlocks);
    }

    /**
     * Called when a Block is right-clicked with this Item
     *  
     * @param pos The block being right-clicked
     * @param side The side being right-clicked
     */
    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        if (side == EnumFacing.DOWN)
        {
            return false;
        }
        else if (side == EnumFacing.UP)
        {
            return false;
        }
        else
        {
            BlockPos blockpos1 = pos.offset(side);

            if (!playerIn.canPlayerEdit(blockpos1, side, stack))
            {
                return false;
            }
            else
            {
            	EntityPaintingEB entityhanging = this.createEntity(worldIn, blockpos1, side);

                if (entityhanging != null && entityhanging.onValidSurface())
                {
                    if (!worldIn.isRemote)
                    {
                        worldIn.spawnEntityInWorld(entityhanging);
                        System.out.println("SPAWNED");
                    }

                    --stack.stackSize;
                }

                return true;
            }
        }
    }

    private EntityPaintingEB createEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return new EntityPaintingEB(worldIn, pos, clickedSide);
    }
}

 

And this is the EntityPainting

package blaze.entities;

import java.util.ArrayList;

import com.google.common.collect.Lists;

import blaze.core.BLItems;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityPaintingEB extends EntityHanging
{
    public EntityPaintingEB.EnumArt art;

    public EntityPaintingEB(World worldIn)
    {
        super(worldIn);
    }

    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side)
    {
        super(worldIn, pos);
        ArrayList arraylist = Lists.newArrayList();
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];
            this.art = enumart;
            this.func_174859_a(side);

            if (this.onValidSurface())
            {
                arraylist.add(enumart);
            }
        }

        if (!arraylist.isEmpty())
        {
            this.art = (EntityPaintingEB.EnumArt)arraylist.get(this.rand.nextInt(arraylist.size()));
        }

        this.func_174859_a(side);
    }

    @SideOnly(Side.CLIENT)
    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side, String name)
    {
        this(worldIn, pos, side);
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(name))
            {
                this.art = enumart;
                break;
            }
        }

        this.func_174859_a(side);
    }

    /**
     * (abstract) Protected helper method to write subclass entity data to NBT.
     */
    public void writeEntityToNBT(NBTTagCompound tagCompound)
    {
        tagCompound.setString("Motive", this.art.title);
        super.writeEntityToNBT(tagCompound);
    }

    /**
     * (abstract) Protected helper method to read subclass entity data from NBT.
     */
    public void readEntityFromNBT(NBTTagCompound tagCompund)
    {
        String s = tagCompund.getString("Motive");
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(s))
            {
                this.art = enumart;
            }
        }

        if (this.art == null)
        {
            this.art = EntityPaintingEB.EnumArt.EB;
        }

        super.readEntityFromNBT(tagCompund);
    }

    public int getWidthPixels()
    {
        return this.art.sizeX;
    }

    public int getHeightPixels()
    {
        return this.art.sizeY;
    }

    /**
     * Called when this entity is broken. Entity parameter may be null.
     */
    public void onBroken(Entity entity)
    {
        if (this.worldObj.getGameRules().getGameRuleBooleanValue("doTileDrops"))
        {
            if (entity instanceof EntityPlayer)
            {
                EntityPlayer entityplayer = (EntityPlayer)entity;

                if (entityplayer.capabilities.isCreativeMode)
                {
                    return;
                }
            }

            this.entityDropItem(new ItemStack(BLItems.painting_eb), 0.0F);
        }
    }

    /**
     * Sets the location and Yaw/Pitch of an entity in the world
     */
    public void setLocationAndAngles(double x, double y, double z, float yaw, float pitch)
    {
        BlockPos blockpos = new BlockPos(x - this.posX, y - this.posY, z - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    @SideOnly(Side.CLIENT)
    public void func_180426_a(double d1, double d2, double d3, float par4, float par5, int par6, boolean par7)
    {
        BlockPos blockpos = new BlockPos(d1 - this.posX, d2 - this.posY, d3 - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    public static enum EnumArt
    {
        EB("EB", 32, 32, 0, 0),
        SUBSCRIBE("SUBSCRIBE", 64, 16, 32, 0);
    	public static final int field_180001_A = "SkullAndRoses".length();
        /** Painting Title. */
        public final String title;
        public final int sizeX;
        public final int sizeY;
        public final int offsetX;
        public final int offsetY;


        private EnumArt(String name, int width, int height, int x, int y)
        {
            this.title = name;
            this.sizeX = width;
            this.sizeY = height;
            this.offsetX = x;
            this.offsetY = y;
        }
    }
}

 

And the EntityPainting Render class

package blaze.entities.renderer;

import blaze.core.BL;
import blaze.entities.EntityPaintingEB;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.OpenGlHelper;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.WorldRenderer;
import net.minecraft.client.renderer.entity.Render;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.entity.Entity;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.MathHelper;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class RenderPaintingEB extends Render
{
    private static final ResourceLocation textures = new ResourceLocation(BL.MODID + ":" + "textures/painting/painting_eb.png");

    public RenderPaintingEB(RenderManager manager)
    {
        super(manager);
    }

    /**
     * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
     * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
     * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
     * double d2, float f, float f1). But JAD is pre 1.5 so doe
     */
    public void doRender(EntityPaintingEB entity, double x, double y, double z, float par5, float partialTicks)
    {
        GlStateManager.pushMatrix();
        GlStateManager.translate(x, y, z);
        GlStateManager.rotate(180.0F - par5, 0.0F, 1.0F, 0.0F);
        GlStateManager.enableRescaleNormal();
        this.bindEntityTexture(entity);
        EntityPaintingEB.EnumArt enumart = entity.art;
        
        float f2 = 0.0625F;
        GlStateManager.scale(f2, f2, f2);
        this.func_77010_a(entity, enumart.sizeX, enumart.sizeY, enumart.offsetX, enumart.offsetY);
        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, par5, partialTicks);
    }

    protected ResourceLocation func_180562_a(EntityPaintingEB entity)
    {
        return textures;
    }

    private void func_77010_a(EntityPaintingEB painting, int par2, int par3, int par4, int par5)
    {
        float f = (float)(-par2) / 2.0F;
        float f1 = (float)(-par3) / 2.0F;
        float f2 = 0.5F;
        float f3 = 0.75F;
        float f4 = 0.8125F;
        float f5 = 0.0F;
        float f6 = 0.0625F;
        float f7 = 0.75F;
        float f8 = 0.8125F;
        float f9 = 0.001953125F;
        float f10 = 0.001953125F;
        float f11 = 0.7519531F;
        float f12 = 0.7519531F;
        float f13 = 0.0F;
        float f14 = 0.0625F;

        for (int i1 = 0; i1 < par2 / 16; ++i1)
        {
            for (int j1 = 0; j1 < par3 / 16; ++j1)
            {
                float f15 = f + (float)((i1 + 1) * 16);
                float f16 = f + (float)(i1 * 16);
                float f17 = f1 + (float)((j1 + 1) * 16);
                float f18 = f1 + (float)(j1 * 16);
                this.func_77008_a(painting, (f15 + f16) / 2.0F, (f17 + f18) / 2.0F);
                float f19 = (float)(par4 + par2 - i1 * 16) / 256.0F;
                float f20 = (float)(par4 + par2 - (i1 + 1) * 16) / 256.0F;
                float f21 = (float)(par5 + par3 - j1 * 16) / 256.0F;
                float f22 = (float)(par5 + par3 - (j1 + 1) * 16) / 256.0F;
                Tessellator tessellator = Tessellator.getInstance();
                WorldRenderer worldrenderer = tessellator.getWorldRenderer();
                worldrenderer.startDrawingQuads();
                worldrenderer.setNormal(0.0F, 0.0F, -1.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f20, (double)f21);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f19, (double)f21);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f19, (double)f22);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f20, (double)f22);
                worldrenderer.setNormal(0.0F, 0.0F, 1.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f3, (double)f5);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f4, (double)f5);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f4, (double)f6);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f3, (double)f6);
                worldrenderer.setNormal(0.0F, 1.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f7, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f8, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f8, (double)f10);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f7, (double)f10);
                worldrenderer.setNormal(0.0F, -1.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f7, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f8, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f8, (double)f10);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f7, (double)f10);
                worldrenderer.setNormal(-1.0F, 0.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f12, (double)f13);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f12, (double)f14);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f11, (double)f14);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f11, (double)f13);
                worldrenderer.setNormal(1.0F, 0.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f12, (double)f13);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f12, (double)f14);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f11, (double)f14);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f11, (double)f13);
                tessellator.draw();
            }
        }
    }

    private void func_77008_a(EntityPaintingEB painting, float par2, float par3)
    {
        int i = MathHelper.floor_double(painting.posX);
        int j = MathHelper.floor_double(painting.posY + (double)(par3 / 16.0F));
        int k = MathHelper.floor_double(painting.posZ);
        EnumFacing enumfacing = painting.field_174860_b;

        if (enumfacing == EnumFacing.NORTH)
        {
            i = MathHelper.floor_double(painting.posX + (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.WEST)
        {
            k = MathHelper.floor_double(painting.posZ - (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.SOUTH)
        {
            i = MathHelper.floor_double(painting.posX - (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.EAST)
        {
            k = MathHelper.floor_double(painting.posZ + (double)(par2 / 16.0F));
        }

        int l = this.renderManager.worldObj.getCombinedLight(new BlockPos(i, j, k), 0);
        int i1 = l % 65536;
        int j1 = l / 65536;
        OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, (float)i1, (float)j1);
        GlStateManager.color(1.0F, 1.0F, 1.0F);
    }

    /**
     * Returns the location of an entity's texture. Doesn't seem to be called unless you call Render.bindEntityTexture.
     */
    protected ResourceLocation getEntityTexture(Entity entity)
    {
        return this.func_180562_a((EntityPaintingEB)entity);
    }

    /**
     * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
     * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
     * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
     * double d2, float f, float f1). But JAD is pre 1.5 so doe
     */
    public void doRender(Entity entity, double x, double y, double z, float par5, float partialTicks)
    {
        this.doRender((EntityPaintingEB)entity, x, y, z, par5, partialTicks);
    }
}

 

The entity is registered as well and in Client Proxy is binded to it's rendering

RenderManager mgr = Minecraft.getMinecraft().getRenderManager();
RenderingRegistry.registerEntityRenderingHandler(EntityPaintingEB.class, new RenderPaintingEB(mgr));

 

So what am i missing? Why this painting is invisible? :/

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Ok, so i've change this

painting_eb = new ItemCustomPainting(EntityPaintingEB.class);

with this

painting_eb = new ItemCustomPainting(EntityPainting.class);

and also changed this

private EntityHanging createEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return (EntityHanging)(new EntityPaintingEB(worldIn, pos, clickedSide));
    }

with this

private EntityHanging createEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return (EntityHanging)(new EntityPainting(worldIn, pos, clickedSide));
    }

and everything works fine, so i believe that the problem is with my custom EntityPainting.

 

This is how i register my entity

-> Called from preInit method, before adding the custom painting item
public static EntityPaintingEB painting_eb;
painting_eb = new EntityPaintingEB(null);
-> Called from the init method, before registering the custom painting item
EntityRegistry.registerModEntity(EntityPaintingEB.class, "paintingEB", starting_id, BL.instance, 128, 1, true);

 

So what's wrong with this entity? It's just a copy of the normal EntityPainting, so why it doesn't work?

Don't blame me if i always ask for your help. I just want to learn to be better :)

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

It's near impossible to scan several large java scripts and then notice what's *not* there.

 

Have you set breakpoints in your custom renderer and then run the debugger? Have you searched the log for any registration or rendering errors? Start larding your code with temporary output statements to give yourself more info about what your program is really doing (it might not even be reaching your custom renderer for some reason). Then again, a simple minus sign could be rendering your entire painting bahind the surface of the block it's mounted on  :o

 

I did a paintings mod in 1.7, but it was over a year ago. I'll be upgrading it to 1.8 soon, so I'll be following this thread and have more to contribute when I get back into it.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

I do some debug try. As i said i'm sure the painting is placed and spawned (checked this with a print), also place some breakpoints in rendering class and they are being reached, so the rendering class is called.

Quick update:

I removed this check from my item class

if (!worldIn.isRemote)
{
    worldIn.spawnEntityInWorld(entityhanging);
}
[code]
and replacing it with only this
[code]
worldIn.spawnEntityInWorld(entityhanging);

spawn the painting in the world, but when i break the supporting block it doesn't disappear but it also drop me the painting item

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

This is the updated code

Rendering

package blaze.entities.renderer;

import blaze.core.BL;
import blaze.entities.EntityPaintingEB;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.OpenGlHelper;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.WorldRenderer;
import net.minecraft.client.renderer.entity.Render;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.entity.Entity;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.MathHelper;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class RenderPaintingEB extends Render
{
    private static final ResourceLocation paintings = new ResourceLocation(BL.MODID + ":" + "textures/painting/paintings.png");

    public RenderPaintingEB(RenderManager mgr)
    {
        super(mgr);
    }

    /**
     * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
     * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
     * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
     * double d2, float f, float f1). But JAD is pre 1.5 so doe
     */
    public void doRender(EntityPaintingEB entity, double x, double y, double z, float par5, float partialTicks)
    {
    	
        GlStateManager.pushMatrix();
        GlStateManager.translate(x, y, z);
        GlStateManager.rotate(180.0F - par5, 0.0F, 1.0F, 0.0F);
        GlStateManager.enableRescaleNormal();
        this.bindEntityTexture(entity);
        EntityPaintingEB.EnumArt enumart = entity.art;
        float f2 = 0.0625F;
        GlStateManager.scale(f2, f2, f2);
        this.func_77010_a(entity, enumart.sizeX, enumart.sizeY, enumart.offsetX, enumart.offsetY);
        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, par5, partialTicks);
    }

    protected ResourceLocation func_180562_a(EntityPaintingEB entity)
    {
        return paintings;
    }

    private void func_77010_a(EntityPaintingEB entity, int par2, int par3, int par4, int par5)
    {
        float f = (float)(-par2) / 2.0F;
        float f1 = (float)(-par3) / 2.0F;
        float f2 = 0.5F;
        float f3 = 0.75F;
        float f4 = 0.8125F;
        float f5 = 0.0F;
        float f6 = 0.0625F;
        float f7 = 0.75F;
        float f8 = 0.8125F;
        float f9 = 0.001953125F;
        float f10 = 0.001953125F;
        float f11 = 0.7519531F;
        float f12 = 0.7519531F;
        float f13 = 0.0F;
        float f14 = 0.0625F;

        for (int i1 = 0; i1 < par2 / 16; ++i1)
        {
            for (int j1 = 0; j1 < par3 / 16; ++j1)
            {
                float f15 = f + (float)((i1 + 1) * 16);
                float f16 = f + (float)(i1 * 16);
                float f17 = f1 + (float)((j1 + 1) * 16);
                float f18 = f1 + (float)(j1 * 16);
                this.func_77008_a(entity, (f15 + f16) / 2.0F, (f17 + f18) / 2.0F);
                float f19 = (float)(par4 + par2 - i1 * 16) / 256.0F;
                float f20 = (float)(par4 + par2 - (i1 + 1) * 16) / 256.0F;
                float f21 = (float)(par5 + par3 - j1 * 16) / 256.0F;
                float f22 = (float)(par5 + par3 - (j1 + 1) * 16) / 256.0F;
                Tessellator tessellator = Tessellator.getInstance();
                WorldRenderer worldrenderer = tessellator.getWorldRenderer();
                worldrenderer.startDrawingQuads();
                worldrenderer.setNormal(0.0F, 0.0F, -1.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f20, (double)f21);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f19, (double)f21);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f19, (double)f22);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f20, (double)f22);
                worldrenderer.setNormal(0.0F, 0.0F, 1.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f3, (double)f5);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f4, (double)f5);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f4, (double)f6);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f3, (double)f6);
                worldrenderer.setNormal(0.0F, 1.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f7, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f8, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f8, (double)f10);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f7, (double)f10);
                worldrenderer.setNormal(0.0F, -1.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f7, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f8, (double)f9);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f8, (double)f10);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f7, (double)f10);
                worldrenderer.setNormal(-1.0F, 0.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f12, (double)f13);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f12, (double)f14);
                worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f11, (double)f14);
                worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f11, (double)f13);
                worldrenderer.setNormal(1.0F, 0.0F, 0.0F);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f12, (double)f13);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f12, (double)f14);
                worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f11, (double)f14);
                worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f11, (double)f13);
                tessellator.draw();
            }
        }
    }

    private void func_77008_a(EntityPaintingEB entity, float par2, float par3)
    {
        int i = MathHelper.floor_double(entity.posX);
        int j = MathHelper.floor_double(entity.posY + (double)(par3 / 16.0F));
        int k = MathHelper.floor_double(entity.posZ);
        EnumFacing enumfacing = entity.field_174860_b;

        if (enumfacing == EnumFacing.NORTH)
        {
            i = MathHelper.floor_double(entity.posX + (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.WEST)
        {
            k = MathHelper.floor_double(entity.posZ - (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.SOUTH)
        {
            i = MathHelper.floor_double(entity.posX - (double)(par2 / 16.0F));
        }

        if (enumfacing == EnumFacing.EAST)
        {
            k = MathHelper.floor_double(entity.posZ + (double)(par2 / 16.0F));
        }

        int l = this.renderManager.worldObj.getCombinedLight(new BlockPos(i, j, k), 0);
        int i1 = l % 65536;
        int j1 = l / 65536;
        OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, (float)i1, (float)j1);
        GlStateManager.color(1.0F, 1.0F, 1.0F);
    }

    /**
     * Returns the location of an entity's texture. Doesn't seem to be called unless you call Render.bindEntityTexture.
     */
    protected ResourceLocation getEntityTexture(Entity entity)
    {
        return this.func_180562_a((EntityPaintingEB)entity);
    }

    /**
     * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
     * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
     * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
     * double d2, float f, float f1). But JAD is pre 1.5 so doe
     */
    public void doRender(Entity entity, double x, double y, double z, float par5, float partialTicks)
    {
        this.doRender((EntityPaintingEB)entity, x, y, z, par5, partialTicks);
    }
}

 

Entity

package blaze.entities;

import java.util.ArrayList;

import com.google.common.collect.Lists;

import blaze.core.BLItems;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityPaintingEB extends EntityHanging
{
    public EntityPaintingEB.EnumArt art;

    public EntityPaintingEB(World worldIn)
    {
        super(worldIn);
    }

    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side)
    {
        super(worldIn, pos);
        ArrayList arraylist = Lists.newArrayList();
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];
            this.art = enumart;
            this.func_174859_a(side);

            if (this.onValidSurface())
            {
                arraylist.add(enumart);
            }
        }

        if (!arraylist.isEmpty())
        {
            this.art = (EntityPaintingEB.EnumArt)arraylist.get(this.rand.nextInt(arraylist.size()));
        }

        this.func_174859_a(side);
    }

    @SideOnly(Side.CLIENT)
    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side, String name)
    {
        this(worldIn, pos, side);
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(name))
            {
                this.art = enumart;
                break;
            }
        }

        this.func_174859_a(side);
    }


/**
     * (abstract) Protected helper method to write subclass entity data to NBT.
     */
    public void writeEntityToNBT(NBTTagCompound tagCompound)
    {
        tagCompound.setString("Motive", this.art.title);
        super.writeEntityToNBT(tagCompound);
    }

    /**
     * (abstract) Protected helper method to read subclass entity data from NBT.
     */
    public void readEntityFromNBT(NBTTagCompound tagCompund)
    {
        String s = tagCompund.getString("Motive");
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(s))
            {
                this.art = enumart;
            }
        }

        if (this.art == null)
        {
            this.art = EntityPaintingEB.EnumArt.KEBAB;
        }

        super.readEntityFromNBT(tagCompund);
    }

    public int getWidthPixels()
    {
        return this.art.sizeX;
    }

    public int getHeightPixels()
    {
        return this.art.sizeY;
    }

    /**
     * Called when this entity is broken. Entity parameter may be null.
     */
    public void onBroken(Entity entity)
    {
        if (this.worldObj.getGameRules().getGameRuleBooleanValue("doTileDrops"))
        {
            if (entity instanceof EntityPlayer)
            {
                EntityPlayer entityplayer = (EntityPlayer)entity;

                if (entityplayer.capabilities.isCreativeMode)
                {
                    return;
                }
            }

            this.entityDropItem(new ItemStack(BLItems.painting_eb), 0.0F);
        }
    }

    /**
     * Sets the location and Yaw/Pitch of an entity in the world
     */
    public void setLocationAndAngles(double x, double y, double z, float yaw, float pitch)
    {
        BlockPos blockpos = new BlockPos(x - this.posX, y - this.posY, z - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    @SideOnly(Side.CLIENT)
    public void func_180426_a(double par1, double par2, double par3, float par4, float par5, int par6, boolean par7)
    {
        BlockPos blockpos = new BlockPos(par1 - this.posX, par2 - this.posY, par3 - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    public static enum EnumArt
    {
        KEBAB("Kebab", 16, 16, 0, 0),
        AZTEC("Aztec", 16, 16, 16, 0),
        ALBAN("Alban", 16, 16, 32, 0),
        AZTEC_2("Aztec2", 16, 16, 48, 0),
        BOMB("Bomb", 16, 16, 64, 0),
        PLANT("Plant", 16, 16, 80, 0),
        WASTELAND("Wasteland", 16, 16, 96, 0),
        POOL("Pool", 32, 16, 0, 32),
        COURBET("Courbet", 32, 16, 32, 32),
        SEA("Sea", 32, 16, 64, 32),
        SUNSET("Sunset", 32, 16, 96, 32),
        CREEBET("Creebet", 32, 16, 128, 32),
        WANDERER("Wanderer", 16, 32, 0, 64),
        GRAHAM("Graham", 16, 32, 16, 64),
        MATCH("Match", 32, 32, 0, 128),
        BUST("Bust", 32, 32, 32, 128),
        STAGE("Stage", 32, 32, 64, 128),
        VOID("Void", 32, 32, 96, 128),
        SKULL_AND_ROSES("SkullAndRoses", 32, 32, 128, 128),
        WITHER("Wither", 32, 32, 160, 128),
        FIGHTERS("Fighters", 64, 32, 0, 96),
        POINTER("Pointer", 64, 64, 0, 192),
        PIGSCENE("Pigscene", 64, 64, 64, 192),
        BURNING_SKULL("BurningSkull", 64, 64, 128, 192),
        SKELETON("Skeleton", 64, 48, 192, 64),
        DONKEY_KONG("DonkeyKong", 64, 48, 192, 112),
        EB("EB", 32, 32, 96, 80),
    	SUBSCRIBE("Subscribe", 64, 16, 96, 64);
        public static final int field_180001_A = "SkullAndRoses".length();
        /** Painting Title. */
        public final String title;
        public final int sizeX;
        public final int sizeY;
        public final int offsetX;
        public final int offsetY;


        private EnumArt(String name, int par1, int par2, int par3, int par4)
        {
            this.title = name;
            this.sizeX = par1;
            this.sizeY = par2;
            this.offsetX = par3;
            this.offsetY = par4;
        }
    }
}

 

Item

package blaze.items;

import blaze.core.BLTabs;
import blaze.entities.EntityPaintingEB;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemHangingEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;

public class ItemCustomPainting extends ItemHangingEntity
{
    private final Class hangingEntityClass;

    public ItemCustomPainting(Class entityClass)
    {
    	super(entityClass);
        this.hangingEntityClass = entityClass;
        this.setCreativeTab(CreativeTabs.tabDecorations);
    }

    /**
     * Called when a Block is right-clicked with this Item
     *  
     * @param pos The block being right-clicked
     * @param side The side being right-clicked
     */
    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        if (side == EnumFacing.DOWN)
        {
            return false;
        }
        else if (side == EnumFacing.UP)
        {
            return false;
        }
        else
        {
            BlockPos blockpos1 = pos.offset(side);

            if (!playerIn.canPlayerEdit(blockpos1, side, stack))
            {
                return false;
            }
            else
            {
            	EntityPaintingEB entityhanging = this.createEntity(worldIn, blockpos1, side);

                if (entityhanging != null && entityhanging.onValidSurface())
                {
                    if (!worldIn.isRemote)
                    {
                        worldIn.spawnEntityInWorld(entityhanging);
                    }

                    --stack.stackSize;
                }

                return true;
            }
        }
    }

    private EntityPaintingEB createEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return new EntityPaintingEB(worldIn, pos, clickedSide);
    }
}

 

 

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Another test. As i was suspecting the render methods are never called! I don't know why. Is somehow related to how i register the entities?

I do this

->from the preInit
public static EntityPaintingEB painting_eb;
painting_eb = new EntityPaintingEB(null);
->from the Init
EntityRegistry.registerModEntity(painting_eb, "painting_eb", EntityRegistry.findGlobalUniqueEntityId(), BL.instance, 128, 1, true);

The constructor takes a World argument, wich here i set it to null. I've tried setting it to this

Minecraft.getMinecraft().theWorld

but it doesn't change. Please i really need help with this :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

SanAndreaP World Shaper

SanAndreaP

Posted
Posted

Your registerModEntity call is messed up, this is how it's supposed to get called:

https://github.com/SanAndreasP/TurretModRebirth/blob/master/java/de/sanandrew/mods/turretmod/util/TmrEntities.java#L29-L35

 

1. parameter: the class of your entity, not the instance of said class.

2. parameter: the entity registration name

3. parameter: the mod-unique entity ID, beginning with 0. DO NOT use findGlobalUniqueEntityId, ever.

4. parameter: your mod instance

5. parameter: the tracking range. Look at EntityList EntityTracker on what value vanilla paintings use.

6. parameter: the tracking tick rate. Look at EntityList EntityTracker on what value vanilla paintings use.

7. parameter: send velocity updates, for paintings, you don't need to send them, so set it to false.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Ok i'll change it to that :)

Also, why i should never use the findGlobalUniqueEntityId? I always used that to register mobs and never had problems :/ I forgot to mention that is use it only once, to know "from wich value to start" and then i increment that, is this correct or i should always start with a specific value?

 

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Ok, i now have only this

EntityRegistry.registerModEntity(EntityPaintingEB.class, "paintingEB", 0, BL.instance, 160, Integer.MAX_VALUE, false);
//EntityPaintingEB is the entity class
//"paintingEB" is the entity name, is this related to something or can be whatever i want?
//0 is the id (it's totally a random number)
//BL.instance is my mod instance
//160 is the tracking range of vanilla painting
//Integer.MAX_VALUE is the update frequency of vanilla painting

so i removed this

painting_eb = new EntityPaintingEB(null);

But it's still not rendering at all :(

 

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

i followed your instructions SanAndreasP but it's still not rendering. I really don't know why this happening :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

I'm starting to guess that there is no answer to my problem :( If someone know why my entity is not rendering please tell me, i tried EVERYTHING but nothing worked :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

I've started upgrading my own paintings mod to 1.8 (so many red X's!). Though I am still contending with a new pattern of deobfucated names (there have been changes in both directions that have broken my code from 1.7.10), I have found some clues in my old code. One is the declaration of my entity class:

 

public class classAltPainting extends EntityPainting implements IEntityAdditionalSpawnData {

 

The first thing I notice is that I settled (in 1.7) on extending EntityPainting instead of EntityHanging. I recall wrestling with that decision, but I can't for the life of me recall what factor(s) made up my mind.

 

The second thing I notice is the implementation of IEntityAdditionalSpawnData. I think this has something to do with the fact that my painting come in 16 whole collections of paintings, not just one like the vanilla set. However, this aspect of my mod delves into reflection, so I haven't sorted it yet.

 

I think my custom renderer is sorted. I had to parlay my Tesselator into a WorldRenderer

 

It starts like this:

@SideOnly(Side.CLIENT)
public class classRenderAltPainting extends RenderPainting {...

 

And its drawQuads method starts like this:

protected void drawQuads(EntityPainting p, int pxWidth, int pxHeight, int pxOffRight, int pxOffDn) {
    Tessellator tess = Tessellator.getInstance ();
    WorldRenderer wr = tess.getWorldRenderer ();

 

All of the graphics methods (e.g. adding vertexes) are called via the wr; only the "draw" at the end is called via tesselator itself.

 

None of this has been test-run in 1.8 yet because there are still some red X's to iron out. I'll let you know if I make any more discoveries.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

I've started upgrading my own paintings mod to 1.8 (so many red X's!). Though I am still contending with a new pattern of deobfucated names (there have been changes in both directions that have broken my code from 1.7.10), I have found some clues in my old code. One is the declaration of my entity class:

 

public class classAltPainting extends EntityPainting implements IEntityAdditionalSpawnData {

 

The first thing I notice is that I settled (in 1.7) on extending EntityPainting instead of EntityHanging. I recall wrestling with that decision, but I can't for the life of me recall what factor(s) made up my mind.

 

The second thing I notice is the implementation of IEntityAdditionalSpawnData. I think this has something to do with the fact that my painting come in 16 whole collections of paintings, not just one like the vanilla set. However, this aspect of my mod delves into reflection, so I haven't sorted it yet.

 

I think my custom renderer is sorted. I had to parlay my Tesselator into a WorldRenderer

 

It starts like this:

@SideOnly(Side.CLIENT)
public class classRenderAltPainting extends RenderPainting {...

 

And its drawQuads method starts like this:

protected void drawQuads(EntityPainting p, int pxWidth, int pxHeight, int pxOffRight, int pxOffDn) {
    Tessellator tess = Tessellator.getInstance ();
    WorldRenderer wr = tess.getWorldRenderer ();

 

All of the graphics methods (e.g. adding vertexes) are called via the wr; only the "draw" at the end is called via tesselator itself.

 

None of this has been test-run in 1.8 yet because there are still some red X's to iron out. I'll let you know if I make any more discoveries.

 

Thanks man, can't wait to know if it works :) If you paste here all your painting related class i'll test by myself (so you can continue updating other stuff) :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

OH MY GOD! I've just solved this! Or well... the painting finally spawns! Ive just let the EntityClass implements the IEntityAdditionalSpawnData  interface, and then add it's related method and IT WORKED!

So this is now my class for the entity

package blaze.entities;

import java.util.ArrayList;

import com.google.common.collect.Lists;

import blaze.core.BLItems;
import io.netty.buffer.ByteBuf;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.registry.IEntityAdditionalSpawnData;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityPaintingEB extends EntityHanging implements IEntityAdditionalSpawnData 
{
    public EntityPaintingEB.EnumArt art;

    public EntityPaintingEB(World worldIn)
    {
        super(worldIn);
    }

    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side)
    {
        super(worldIn, pos);
        ArrayList arraylist = Lists.newArrayList();
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];
            this.art = enumart;
            this.func_174859_a(side);

            if (this.onValidSurface())
            {
                arraylist.add(enumart);
            }
        }

        if (!arraylist.isEmpty())
        {
            this.art = (EntityPaintingEB.EnumArt)arraylist.get(this.rand.nextInt(arraylist.size()));
        }

        this.func_174859_a(side);
    }

    @SideOnly(Side.CLIENT)
    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side, String name)
    {
        this(worldIn, pos, side);
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(name))
            {
                this.art = enumart;
                break;
            }
        }

        this.func_174859_a(side);
    }


/**
     * (abstract) Protected helper method to write subclass entity data to NBT.
     */
    public void writeEntityToNBT(NBTTagCompound tagCompound)
    {
        tagCompound.setString("Motive", this.art.title);
        super.writeEntityToNBT(tagCompound);
    }

    /**
     * (abstract) Protected helper method to read subclass entity data from NBT.
     */
    public void readEntityFromNBT(NBTTagCompound tagCompund)
    {
        String s = tagCompund.getString("Motive");
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(s))
            {
                this.art = enumart;
            }
        }

        if (this.art == null)
        {
            this.art = EntityPaintingEB.EnumArt.KEBAB;
        }

        super.readEntityFromNBT(tagCompund);
    }

    public int getWidthPixels()
    {
        return this.art.sizeX;
    }

    public int getHeightPixels()
    {
        return this.art.sizeY;
    }

    /**
     * Called when this entity is broken. Entity parameter may be null.
     */
    public void onBroken(Entity entity)
    {
        if (this.worldObj.getGameRules().getGameRuleBooleanValue("doTileDrops"))
        {
            if (entity instanceof EntityPlayer)
            {
                EntityPlayer entityplayer = (EntityPlayer)entity;

                if (entityplayer.capabilities.isCreativeMode)
                {
                    return;
                }
            }

            this.entityDropItem(new ItemStack(BLItems.painting_eb), 0.0F);
        }
    }

    /**
     * Sets the location and Yaw/Pitch of an entity in the world
     */
    public void setLocationAndAngles(double x, double y, double z, float yaw, float pitch)
    {
        BlockPos blockpos = new BlockPos(x - this.posX, y - this.posY, z - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    @SideOnly(Side.CLIENT)
    public void func_180426_a(double par1, double par2, double par3, float par4, float par5, int par6, boolean par7)
    {
        BlockPos blockpos = new BlockPos(par1 - this.posX, par2 - this.posY, par3 - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    public static enum EnumArt
    {
        KEBAB("Kebab", 16, 16, 0, 0),
        AZTEC("Aztec", 16, 16, 16, 0),
        ALBAN("Alban", 16, 16, 32, 0),
        AZTEC_2("Aztec2", 16, 16, 48, 0),
        BOMB("Bomb", 16, 16, 64, 0),
        PLANT("Plant", 16, 16, 80, 0),
        WASTELAND("Wasteland", 16, 16, 96, 0),
        POOL("Pool", 32, 16, 0, 32),
        COURBET("Courbet", 32, 16, 32, 32),
        SEA("Sea", 32, 16, 64, 32),
        SUNSET("Sunset", 32, 16, 96, 32),
        CREEBET("Creebet", 32, 16, 128, 32),
        WANDERER("Wanderer", 16, 32, 0, 64),
        GRAHAM("Graham", 16, 32, 16, 64),
        MATCH("Match", 32, 32, 0, 128),
        BUST("Bust", 32, 32, 32, 128),
        STAGE("Stage", 32, 32, 64, 128),
        VOID("Void", 32, 32, 96, 128),
        SKULL_AND_ROSES("SkullAndRoses", 32, 32, 128, 128),
        WITHER("Wither", 32, 32, 160, 128),
        FIGHTERS("Fighters", 64, 32, 0, 96),
        POINTER("Pointer", 64, 64, 0, 192),
        PIGSCENE("Pigscene", 64, 64, 64, 192),
        BURNING_SKULL("BurningSkull", 64, 64, 128, 192),
        SKELETON("Skeleton", 64, 48, 192, 64),
        DONKEY_KONG("DonkeyKong", 64, 48, 192, 112),
        EB("EB", 32, 32, 96, 80),
    	SUBSCRIBE("Subscribe", 64, 16, 96, 64);
        public static final int field_180001_A = "SkullAndRoses".length();
        /** Painting Title. */
        public final String title;
        public final int sizeX;
        public final int sizeY;
        public final int offsetX;
        public final int offsetY;


        private EnumArt(String name, int par1, int par2, int par3, int par4)
        {
            this.title = name;
            this.sizeX = par1;
            this.sizeY = par2;
            this.offsetX = par3;
            this.offsetY = par4;
        }
    }

@Override
public void writeSpawnData(ByteBuf buffer) {
	buffer.writeInt(this.art.ordinal());
        buffer.writeInt(this.chunkCoordX);       // x
        buffer.writeInt(this.chunkCoordY);       // y
        buffer.writeInt(this.chunkCoordZ);       // z
        buffer.writeByte(this.getHorizontalFacing().getIndex());
}

@Override
public void readSpawnData(ByteBuf buffer) {
	EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
	this.art = aenumart[buffer.readInt()];
        this.chunkCoordX = buffer.readInt();
        this.chunkCoordY = buffer.readInt();
        this.chunkCoordZ = buffer.readInt();
        this.func_174859_a(EnumFacing.getFront((buffer.readByte())));
}
}

 

I've also changed the Item class to this

package blaze.items;

import blaze.entities.EntityPaintingEB;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;

public class ItemCustomPainting extends Item
{
    private final Class hangingEntityClass;

    public ItemCustomPainting(Class entityClass)
    {
    	super();
        this.hangingEntityClass = entityClass;
        this.setCreativeTab(CreativeTabs.tabDecorations);
    }

    /**
     * Called when a Block is right-clicked with this Item
     *  
     * @param pos The block being right-clicked
     * @param side The side being right-clicked
     */
    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        if (side == EnumFacing.DOWN)
        {
            return false;
        }
        else if (side == EnumFacing.UP)
        {
            return false;
        }
        else
        {
            BlockPos blockpos1 = pos.offset(side);

            if (!playerIn.canPlayerEdit(blockpos1, side, stack))
            {
                return false;
            }
            else
            {
            	EntityHanging entityhanging = this.createHangingEntity(worldIn, blockpos1, side);

                if (entityhanging != null && entityhanging.onValidSurface())
                {
                    if (!worldIn.isRemote)
                    {
                        worldIn.spawnEntityInWorld(entityhanging);
                    }

                    --stack.stackSize;
                }

                return true;
            }
        }
    }

    private EntityHanging createHangingEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return new EntityPaintingEB(worldIn, pos, clickedSide);
    }
}

 

Now, the only issue remained is that if a painting of 32x32 pixels is spawned (for example the wither painting), it will actually spawns 1 block higher than where i clicked. So here is a picture of a 32x32 painting

nCc0brS.png

As you can see rendering is fine but i have clicked with the painting on the block above (so the first log block starting from bottom). It only happens with big painting, if a small painting or a "banner" painting is placed everything works fine :) Hope to find soon what is the problem and post here the solution. Thanks to all who show me support doing this, probably i will never figured out without you :) And for who is asking himself, i looked into the AtelierCanvas mod source code on Github :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Just fixed that by chaging the two functions above with this

@Override
public void writeSpawnData(ByteBuf buffer) {
	buffer.writeInt(this.art.ordinal());

        buffer.writeInt(this.hangingPosition.getX());       // x
        buffer.writeInt(this.hangingPosition.getY());       // y
        buffer.writeInt(this.hangingPosition.getZ());       // z
        buffer.writeByte(this.getHorizontalFacing().getIndex());
}

@Override
public void readSpawnData(ByteBuf buffer) {
	EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
	this.art = aenumart[buffer.readInt()];

        int x = buffer.readInt();
        int y = buffer.readInt();
        int z = buffer.readInt();
        
        BlockPos pos = new BlockPos(x, y, z);
        this.hangingPosition = pos;
        this.func_174859_a(EnumFacing.getFront((buffer.readByte())));
}

 

Finally this problem is solved, thanks to everyone of you!!!! Hope this will help you jeffryfisher in your updating process :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept