[SOLVED] [1.8] Custom Painting sometime is placing wrong

[JimiIT92]

As by title, i have a cutom painting but sometimes when i place it on a wall it has an incorrect position. This only occurs with big paintings, for 1x1 or 2x2 painitngs everything works fine.

Here is my entity painting class

package blaze.entities;

import java.util.ArrayList;

import com.google.common.collect.Lists;

import blaze.core.BLItems;
import io.netty.buffer.ByteBuf;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.registry.IEntityAdditionalSpawnData;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EntityPaintingEB extends EntityHanging implements IEntityAdditionalSpawnData 
{
    public EntityPaintingEB.EnumArt art;

    public EntityPaintingEB(World worldIn)
    {
        super(worldIn);
    }

    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side)
    {
        super(worldIn, pos);
        ArrayList arraylist = Lists.newArrayList();
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];
            this.art = enumart;
            this.func_174859_a(side);

            if (this.onValidSurface())
            {
                arraylist.add(enumart);
            }
        }

        if (!arraylist.isEmpty())
        {
            this.art = (EntityPaintingEB.EnumArt)arraylist.get(this.rand.nextInt(arraylist.size()));
        }

        this.func_174859_a(side);
    }

    @SideOnly(Side.CLIENT)
    public EntityPaintingEB(World worldIn, BlockPos pos, EnumFacing side, String name)
    {
        this(worldIn, pos, side);
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(name))
            {
                this.art = enumart;
                break;
            }
        }

        this.func_174859_a(side);
    }


/**
     * (abstract) Protected helper method to write subclass entity data to NBT.
     */
    public void writeEntityToNBT(NBTTagCompound tagCompound)
    {
        tagCompound.setString("Motive", this.art.title);
        super.writeEntityToNBT(tagCompound);
    }

    /**
     * (abstract) Protected helper method to read subclass entity data from NBT.
     */
    public void readEntityFromNBT(NBTTagCompound tagCompund)
    {
        String s = tagCompund.getString("Motive");
        EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
        int i = aenumart.length;

        for (int j = 0; j < i; ++j)
        {
            EntityPaintingEB.EnumArt enumart = aenumart[j];

            if (enumart.title.equals(s))
            {
                this.art = enumart;
            }
        }

        if (this.art == null)
        {
            this.art = EntityPaintingEB.EnumArt.KEBAB;
        }

        super.readEntityFromNBT(tagCompund);
    }

    public int getWidthPixels()
    {
        return this.art.sizeX;
    }

    public int getHeightPixels()
    {
        return this.art.sizeY;
    }

    /**
     * Called when this entity is broken. Entity parameter may be null.
     */
    public void onBroken(Entity entity)
    {
        if (this.worldObj.getGameRules().getGameRuleBooleanValue("doTileDrops"))
        {
            if (entity instanceof EntityPlayer)
            {
                EntityPlayer entityplayer = (EntityPlayer)entity;

                if (entityplayer.capabilities.isCreativeMode)
                {
                    return;
                }
            }

            this.entityDropItem(new ItemStack(BLItems.painting_eb), 0.0F);
        }
    }

    /**
     * Sets the location and Yaw/Pitch of an entity in the world
     */
    public void setLocationAndAngles(double x, double y, double z, float yaw, float pitch)
    {
        BlockPos blockpos = new BlockPos(x - this.posX, y - this.posY, z - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    @SideOnly(Side.CLIENT)
    public void func_180426_a(double par1, double par2, double par3, float par4, float par5, int par6, boolean par7)
    {
        BlockPos blockpos = new BlockPos(par1 - this.posX, par2 - this.posY, par3 - this.posZ);
        BlockPos blockpos1 = this.hangingPosition.add(blockpos);
        this.setPosition((double)blockpos1.getX(), (double)blockpos1.getY(), (double)blockpos1.getZ());
    }

    public static enum EnumArt
    {
        KEBAB("Kebab", 16, 16, 0, 0),
        AZTEC("Aztec", 16, 16, 16, 0),
        ALBAN("Alban", 16, 16, 32, 0),
        AZTEC_2("Aztec2", 16, 16, 48, 0),
        BOMB("Bomb", 16, 16, 64, 0),
        PLANT("Plant", 16, 16, 80, 0),
        WASTELAND("Wasteland", 16, 16, 96, 0),
        POOL("Pool", 32, 16, 0, 32),
        COURBET("Courbet", 32, 16, 32, 32),
        SEA("Sea", 32, 16, 64, 32),
        SUNSET("Sunset", 32, 16, 96, 32),
        CREEBET("Creebet", 32, 16, 128, 32),
        WANDERER("Wanderer", 16, 32, 0, 64),
        GRAHAM("Graham", 16, 32, 16, 64),
        MATCH("Match", 32, 32, 0, 128),
        BUST("Bust", 32, 32, 32, 128),
        STAGE("Stage", 32, 32, 64, 128),
        VOID("Void", 32, 32, 96, 128),
        SKULL_AND_ROSES("SkullAndRoses", 32, 32, 128, 128),
        WITHER("Wither", 32, 32, 160, 128),
        FIGHTERS("Fighters", 64, 32, 0, 96),
        POINTER("Pointer", 64, 64, 0, 192),
        PIGSCENE("Pigscene", 64, 64, 64, 192),
        BURNING_SKULL("BurningSkull", 64, 64, 128, 192),
        SKELETON("Skeleton", 64, 48, 192, 64),
        DONKEY_KONG("DonkeyKong", 64, 48, 192, 112),
        EB("EB", 32, 32, 96, 80),
    	SUBSCRIBE("Subscribe", 64, 16, 96, 64);
        public static final int field_180001_A = "SkullAndRoses".length();
        /** Painting Title. */
        public final String title;
        public final int sizeX;
        public final int sizeY;
        public final int offsetX;
        public final int offsetY;


        private EnumArt(String name, int par1, int par2, int par3, int par4)
        {
            this.title = name;
            this.sizeX = par1;
            this.sizeY = par2;
            this.offsetX = par3;
            this.offsetY = par4;
        }
    }

@Override
public void writeSpawnData(ByteBuf buffer) {
	buffer.writeInt(this.art.ordinal());

        buffer.writeInt(this.hangingPosition.getX());
        buffer.writeInt(this.hangingPosition.getY());
        buffer.writeInt(this.hangingPosition.getZ());
        buffer.writeByte(this.getHorizontalFacing().getIndex());
}

@Override
public void readSpawnData(ByteBuf buffer) {
	EntityPaintingEB.EnumArt[] aenumart = EntityPaintingEB.EnumArt.values();
	this.art = aenumart[buffer.readInt()];

        int x = buffer.readInt();
        int y = buffer.readInt();
        int z = buffer.readInt();
        
        BlockPos pos = new BlockPos(x, y, z);
        this.hangingPosition = pos;
        this.func_174859_a(EnumFacing.getFront((buffer.readByte())));
}
}

 

This is my item custom painting (from wich i place the entity in the world)

package blaze.items;

import blaze.entities.EntityPaintingEB;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityHanging;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.World;

public class ItemCustomPainting extends Item
{
    private final Class hangingEntityClass;

    public ItemCustomPainting(Class entityClass)
    {
    	super();
        this.hangingEntityClass = entityClass;
        this.setCreativeTab(CreativeTabs.tabDecorations);
    }

    /**
     * Called when a Block is right-clicked with this Item
     *  
     * @param pos The block being right-clicked
     * @param side The side being right-clicked
     */
    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        if (side == EnumFacing.DOWN)
        {
            return false;
        }
        else if (side == EnumFacing.UP)
        {
            return false;
        }
        else
        {
            BlockPos blockpos1 = pos.offset(side);

            if (!playerIn.canPlayerEdit(blockpos1, side, stack))
            {
                return false;
            }
            else
            {
            	EntityHanging entityhanging = this.createHangingEntity(worldIn, blockpos1, side);

                if (entityhanging != null && entityhanging.onValidSurface())
                {
                    if (!worldIn.isRemote)
                    {
                        worldIn.spawnEntityInWorld(entityhanging);
                    }

                    --stack.stackSize;
                }

                return true;
            }
        }
    }

    private EntityHanging createHangingEntity(World worldIn, BlockPos pos, EnumFacing clickedSide)
    {
        return new EntityPaintingEB(worldIn, pos, clickedSide);
    }
}

 

And this is the rendering class

package blaze.entities.renderer;

import blaze.core.BL;
import blaze.entities.EntityPaintingEB;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.OpenGlHelper;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.WorldRenderer;
import net.minecraft.client.renderer.entity.Render;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.entity.Entity;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.MathHelper;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class RenderPaintingEB extends Render
{
private static final ResourceLocation paintings = new ResourceLocation(BL.MODID + ":" + "textures/painting/paintings.png");

public RenderPaintingEB(RenderManager mgr)
{
	super(mgr);
}

/**
 * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
 * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
 * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
 * double d2, float f, float f1). But JAD is pre 1.5 so doe
 */
public void doRender(EntityPaintingEB entity, double x, double y, double z, float par5, float partialTicks)
{

	GlStateManager.pushMatrix();
	GlStateManager.translate(x, y, z);
	GlStateManager.rotate(180.0F - par5, 0.0F, 1.0F, 0.0F);
	GlStateManager.enableRescaleNormal();
	this.bindEntityTexture(entity);
	EntityPaintingEB.EnumArt enumart = entity.art;
	float f2 = 0.0625F;
	GlStateManager.scale(f2, f2, f2);
	this.func_77010_a(entity, enumart.sizeX, enumart.sizeY, enumart.offsetX, enumart.offsetY);
	GlStateManager.disableRescaleNormal();
	GlStateManager.popMatrix();
	super.doRender(entity, x, y, z, par5, partialTicks);
}

protected ResourceLocation func_180562_a(EntityPaintingEB entity)
{
	return paintings;
}

private void func_77010_a(EntityPaintingEB entity, int par2, int par3, int par4, int par5)
{
	float f = (float)(-par2) / 2.0F;
	float f1 = (float)(-par3) / 2.0F;
	float f2 = 0.5F;
	float f3 = 0.75F;
	float f4 = 0.8125F;
	float f5 = 0.0F;
	float f6 = 0.0625F;
	float f7 = 0.75F;
	float f8 = 0.8125F;
	float f9 = 0.001953125F;
	float f10 = 0.001953125F;
	float f11 = 0.7519531F;
	float f12 = 0.7519531F;
	float f13 = 0.0F;
	float f14 = 0.0625F;

	for (int i1 = 0; i1 < par2 / 16; ++i1)
	{
		for (int j1 = 0; j1 < par3 / 16; ++j1)
		{
			float f15 = f + (float)((i1 + 1) * 16);
			float f16 = f + (float)(i1 * 16);
			float f17 = f1 + (float)((j1 + 1) * 16);
			float f18 = f1 + (float)(j1 * 16);
			this.func_77008_a(entity, (f15 + f16) / 2.0F, (f17 + f18) / 2.0F);
			float f19 = (float)(par4 + par2 - i1 * 16) / 256.0F;
			float f20 = (float)(par4 + par2 - (i1 + 1) * 16) / 256.0F;
			float f21 = (float)(par5 + par3 - j1 * 16) / 256.0F;
			float f22 = (float)(par5 + par3 - (j1 + 1) * 16) / 256.0F;
			Tessellator tessellator = Tessellator.getInstance();
			WorldRenderer worldrenderer = tessellator.getWorldRenderer();
			worldrenderer.startDrawingQuads();
			worldrenderer.setNormal(0.0F, 0.0F, -1.0F);
			worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f20, (double)f21);
			worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f19, (double)f21);
			worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f19, (double)f22);
			worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f20, (double)f22);
			if(!entity.art.title.equals("EB"))
			{
				worldrenderer.setNormal(0.0F, 0.0F, 1.0F);
				worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f3, (double)f5);
				worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f4, (double)f5);
				worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f4, (double)f6);
				worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f3, (double)f6);
				worldrenderer.setNormal(0.0F, 1.0F, 0.0F);
				worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f7, (double)f9);
				worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f8, (double)f9);
				worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f8, (double)f10);
				worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f7, (double)f10);
				worldrenderer.setNormal(0.0F, -1.0F, 0.0F);
				worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f7, (double)f9);
				worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f8, (double)f9);
				worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f8, (double)f10);
				worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f7, (double)f10);
				worldrenderer.setNormal(-1.0F, 0.0F, 0.0F);
				worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f12, (double)f13);
				worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f12, (double)f14);
				worldrenderer.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f11, (double)f14);
				worldrenderer.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f11, (double)f13);
				worldrenderer.setNormal(1.0F, 0.0F, 0.0F);
				worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f12, (double)f13);
				worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f12, (double)f14);
				worldrenderer.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f11, (double)f14);
				worldrenderer.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f11, (double)f13);
			}
			tessellator.draw();
		}
	}
}

private void func_77008_a(EntityPaintingEB entity, float par2, float par3)
{
	int i = MathHelper.floor_double(entity.posX);
	int j = MathHelper.floor_double(entity.posY + (double)(par3 / 16.0F));
	int k = MathHelper.floor_double(entity.posZ);
	EnumFacing enumfacing = entity.field_174860_b;

	if (enumfacing == EnumFacing.NORTH)
	{
		i = MathHelper.floor_double(entity.posX + (double)(par2 / 16.0F));
	}

	if (enumfacing == EnumFacing.WEST)
	{
		k = MathHelper.floor_double(entity.posZ - (double)(par2 / 16.0F));
	}

	if (enumfacing == EnumFacing.SOUTH)
	{
		i = MathHelper.floor_double(entity.posX - (double)(par2 / 16.0F));
	}

	if (enumfacing == EnumFacing.EAST)
	{
		k = MathHelper.floor_double(entity.posZ + (double)(par2 / 16.0F));
	}

	int l = this.renderManager.worldObj.getCombinedLight(new BlockPos(i, j, k), 0);
	int i1 = l % 65536;
	int j1 = l / 65536;
	OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, (float)i1, (float)j1);
	GlStateManager.color(1.0F, 1.0F, 1.0F);
}

/**
 * Returns the location of an entity's texture. Doesn't seem to be called unless you call Render.bindEntityTexture.
 */
protected ResourceLocation getEntityTexture(Entity entity)
{
	return this.func_180562_a((EntityPaintingEB)entity);
}

/**
 * Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then
 * handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic
 * (Render<T extends Entity>) and this method has signature public void func_76986_a(T entity, double d, double d1,
 * double d2, float f, float f1). But JAD is pre 1.5 so doe
 */
public void doRender(Entity entity, double x, double y, double z, float par5, float partialTicks)
{
	this.doRender((EntityPaintingEB)entity, x, y, z, par5, partialTicks);
}
}

 

I've also made a video to better explain what is my problem

https://www.youtube.com/watch?v=piQWeUJI_uw&feature=youtu.be

 

[TheGreyGhost]

Hi

 

The vanilla logic for placing the painting entities is rather hard to follow.  Depending on the size of the painting, it moves the origin to a different position from where you clicked.  I suggest you find a vanilla painting which is the same size as yours and see what happens to the entity [x,y,z] when it is placed.

 

-TGG

[JimiIT92]

I tried printing out what it reads and what it writes and they are the same value, so it should not be any problem (while instead there is )

[jeffryfisher]

I'm currently upgrading my 1.7.10 paintings mod to 1.8, so I am comparing your mod to mine... amazing congruence. I hope to solve my own bug while looking for yours...

 

You chose to extend entityHanging (imitating entityPainting entirely), while I chose to extend entityPainting and override almost everything... The reading and writing from NBT might be the only methods I didn't replace.

 

Anyway, I watched the video you linked, and what I saw was WAD (works as designed). Paintings are designed to hang somewhat centered around the target tile, so the big ones are supposed to extend a little down and left of your aim point.

 

The shift occurs in EntityHanging.func_174856_o() with odds and evens adjusted by func_174858_a().

 

If yur problem was something else, then please clarify the symptom.

 

 

[JimiIT92]

Oh, i always supposed that the starting block was the bottom corner of the painting (not the center). Thanks for your explanation