Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.8] [SOLVED] Config not saving if changed in the Config GUI

xJon

By xJon
in Modder Support

 Share

Recommended Posts

xJon Stone Miner

xJon

Posted
Posted

Hi,

 

Recently I worked on a configuration GUI and when I tested it, it didn't save. The configuration file is working okay though.

I have a syncConfig method here, onConfigChanged method here, and this is my main class.

I'll really appreciate if someone could look at the code and see what's wrong. I'm trying for hours and I can't figure it out. I also tried searching online but nope - I did everything they said, well at least I think I did.

 

Thanks for any reply! :P

Why are you reading this?

Himself12794 Stone Miner

Himself12794

Posted
Posted

One thing I noticed is that every time syncConfig is called, you're registering the mod instance as an event handler. You don't need to do that.

 

You might also find it more convenient to put the configuration event change method in the configuration class. I just recently did something like what you did. Here is my solution: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/ModConfig.java

Main mod class here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/PowersAPI.java

And I register it here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/proxy/CommonProxy.java

 

Hopefully that helps. If not, I can look at what you've done again much better once I get access to more than just a mobile device.

With all due respect, sir: I do, what I do, the way I do it. ~ MacGyver

xJon Stone Miner

xJon

Posted
  • Author
Posted
  On 9/23/2015 at 11:42 PM, Himself12794 said:

One thing I noticed is that every time syncConfig is called, you're registering the mod instance as an event handler. You don't need to do that.

 

You might also find it more convenient to put the configuration event change method in the configuration class. I just recently did something like what you did. Here is my solution: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/ModConfig.java

Main mod class here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/PowersAPI.java

And I register it here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/proxy/CommonProxy.java

 

Hopefully that helps. If not, I can look at what you've done again much better once I get access to more than just a mobile device.

I tried removing mod instance event in the syncConfig method but it didn't do it unfortunately..

I looked at your way and it's completely different, you send it back to the main mod class and then use the instance? I didn't really understand that. :\

Why are you reading this?

Himself12794 Stone Miner

Himself12794

Posted
Posted

Found it.

 

In your config mod gui, here: https://github.com/xJon/Jons-Useless-Mod/blob/master/src/main/java/xjon/jum/client/gui/UselessConfigGui.java#L17

 

You are registering the gui with your mod name, not your mod id. That's why the event isn't triggering. I tested it and used the mod id instead of mod name, and I was able to get it to work.

With all due respect, sir: I do, what I do, the way I do it. ~ MacGyver

xJon Stone Miner

xJon

Posted
  • Author
Posted
  On 9/24/2015 at 3:38 PM, Himself12794 said:

Found it.

 

In your config mod gui, here: https://github.com/xJon/Jons-Useless-Mod/blob/master/src/main/java/xjon/jum/client/gui/UselessConfigGui.java#L17

 

You are registering the gui with your mod name, not your mod id. That's why the event isn't triggering. I tested it and used the mod id instead of mod name, and I was able to get it to work.

You're our saviour! :)

Why are you reading this?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Rodney Spenser
      How To Recover Lost Funds From Crypto Investment Scam

      By Rodney Spenser · Posted

      Betafort Recovery has emerged as a prominent figure in the realm of cryptocurrency recovery, gaining a reputation for their exceptional ability to retrieve lost Bitcoin (BTC) and other cryptocurrencies. Their expertise and track record have made them a beacon of hope for individuals facing the distressing situation of lost or inaccessible crypto assets.  
    • Ugdhar
      Help me with registries

      By Ugdhar · Posted

      When you name a method like that, with no return value, it is a constructor. The constructor must have the same name as the class it constructs, in this case, ModItems. I would strongly advise reading up on some basic Java tutorials, because you will definitely be running into a lot more issues as you go along without the basics. *I should also add that the Forge documentation is a reference, not a tutorial. Even following tutorials, you should know Java basics, otherwise the smallest of mistakes will trip you up as you copy someone elses code.
    • quase
      Help me with registries

      By quase · Posted

      so, I'm starting modding and I'm following the official documantation for forge: https://docs.minecraftforge.net, but in the registries part it is not working as it is in the docs:   public class ModItems { private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, DarkStarvation.MOD_ID); public static final RegistryObject<Item> TEST_ITEM = ITEMS.register("test_item", () -> new Item(new Item.Properties())); public DarkStarvation(FMLJavaModLoadingContext context) { ITEMS.register(context.getModEventBus()); } } in 'public DarkStarvation(...' the DarkStarvation has this error: Invalid method declaration; return type required and the getModEventBus(): Cannot resolve method 'getModEventBus' in 'FMLJavaModLoadingContext' please help, I asked gpt but it is saying that I'm using an old method, but I'm following the latest version of Forge Docs???
    • Ugdhar
      Reply to my question please

      By Ugdhar · Posted

      I merged your second post with the original , there is no need to post a new thread asking for an answer. If someone sees your post and can help, they will reply. If you are seeking a quicker response, you could try asking in the Minecraft Forge diacord.
    • TileEntity
      Cobblemon modpack keeps crashing idk why

      By TileEntity · Posted

      Create a new instance and start with cobblemon - if this works, add the rest of your mods in groups   Maybe another mod is conflicting - like Sodium/Iris or Radical Cobblemon Trainers

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept